Skip to content

TEZ-4727: Add ARM support of the dependent leveldbjni - #509

Merged
ayushtkn merged 5 commits into
apache:masterfrom
ayushtkn:TEZ-4727
Jun 23, 2026
Merged

TEZ-4727: Add ARM support of the dependent leveldbjni#509
ayushtkn merged 5 commits into
apache:masterfrom
ayushtkn:TEZ-4727

Conversation

@ayushtkn

@ayushtknayushtkn commented Jun 12, 2026

Copy link
Copy Markdown
Member

Description in Jira

@tez-yetus

tez-yetus commented Jun 12, 2026

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec9m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 43sMaven dependency ordering for branch
+1 💚mvninstall4m 45smaster passed
+1 💚compile3m 57smaster passed
+1 💚checkstyle1m 31smaster passed
+1 💚javadoc1m 51smaster passed
+0 🆗spotbugs0m 46stez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
+0 🆗spotbugs6m 59sroot in master has 1054 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 52sthe patch passed
+1 💚codespell1m 45sNo new issues.
+1 💚compile3m 56sthe patch passed
+1 💚javac3m 56sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 26sthe patch passed
+1 💚javadoc1m 50sthe patch passed
+1 💚spotbugs8m 7sthe patch passed
_ Other Tests _
+1 💚unit69m 59sroot in the patch passed.
+1 💚asflicense1m 21sThe patch does not generate ASF License warnings.
125m 33s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/1/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense javac javadoc codespell detsecrets xmllint spotbugs checkstyle
unameLinux d9f996e98603 5.15.0-177-generic #187-Ubuntu SMP Sat Apr 11 22:54:33 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / cba5689
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/1/testReport/
Max. process+thread count1392 (vs. ulimit of 5500)
modulesC: tez-plugins/tez-aux-services . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/1/console
versionsgit=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

abstractdog commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

minor question: could the aarch64 build success be validated by a github action?

@ayushtkn

ayushtkn commented Jun 18, 2026

Copy link
Copy Markdown
MemberAuthor

@abstractdog I have added in the github actions the ARM support: https://github.com/apache/tez/actions/runs/27742306971/job/82072186429?pr=509

Have to skip the UI build it is broken due to PhantomJS, Have to chase it seprately maybe migrate to selenium-java

@tez-yetus

tez-yetus commented Jun 18, 2026

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 42sMaven dependency ordering for branch
+1 💚mvninstall4m 47smaster passed
+1 💚compile3m 56smaster passed
+1 💚checkstyle1m 30smaster passed
+1 💚javadoc1m 50smaster passed
+0 🆗spotbugs0m 47stez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
+0 🆗spotbugs6m 58sroot in master has 1054 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 1sthe patch passed
+1 💚codespell1m 46sNo new issues.
+1 💚compile3m 57sthe patch passed
+1 💚javac3m 57sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 26sthe patch passed
-1 ❌yamllint0m 0s/results-yamllint.txtThe patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚javadoc1m 48sthe patch passed
+1 💚spotbugs8m 8sthe patch passed
_ Other Tests _
+1 💚unit73m 51sroot in the patch passed.
+1 💚asflicense1m 21sThe patch does not generate ASF License warnings.
120m 33s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/4/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets yamllint javac javadoc xmllint spotbugs checkstyle
unameLinux a106fd5cf7ea 5.15.0-177-generic #187-Ubuntu SMP Sat Apr 11 22:54:33 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 5766cda
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/4/testReport/
Max. process+thread count1331 (vs. ulimit of 5500)
modulesC: tez-plugins/tez-aux-services . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/4/console
versionsgit=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 yamllint=1.38.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

abstractdog commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@abstractdog I have added in the github actions the ARM support: https://github.com/apache/tez/actions/runs/27742306971/job/82072186429?pr=509

Have to skip the UI build it is broken due to PhantomJS, Have to chase it seprately maybe migrate to selenium-java

okay! there is only a yamllint warning left

@tez-yetus

tez-yetus commented Jun 20, 2026

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 41sMaven dependency ordering for branch
+1 💚mvninstall4m 49smaster passed
+1 💚compile3m 58smaster passed
+1 💚checkstyle1m 33smaster passed
+1 💚javadoc1m 51smaster passed
+0 🆗spotbugs0m 50stez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
+0 🆗spotbugs6m 57sroot in master has 1054 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 3sthe patch passed
+1 💚codespell1m 47sNo new issues.
+1 💚compile3m 57sthe patch passed
+1 💚javac3m 57sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 23sthe patch passed
+1 💚yamllint0m 2sNo new issues.
+1 💚javadoc1m 50sthe patch passed
+1 💚spotbugs8m 8sthe patch passed
_ Other Tests _
+1 💚unit72m 18sroot in the patch passed.
+1 💚asflicense1m 21sThe patch does not generate ASF License warnings.
119m 12s
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/5/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets yamllint javac javadoc xmllint spotbugs checkstyle
unameLinux 13a7b556610d 5.15.0-177-generic #187-Ubuntu SMP Sat Apr 11 22:54:33 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 72a42de
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/5/testReport/
Max. process+thread count1474 (vs. ulimit of 5500)
modulesC: tez-plugins/tez-aux-services . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/5/console
versionsgit=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 yamllint=1.38.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@ayushtkn

ayushtkn commented Jun 21, 2026

Copy link
Copy Markdown
MemberAuthor

Thanx @abstractdog for the review, Have fixed the yamlint warning

abstractdog
abstractdog requested changes Jun 22, 2026
View reviewed changes

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 more nit, other than that LGTM

Comment threadtez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java Outdated
Comment on lines +708 to +709
if (e instanceof IOException) {
throw (IOException) e;

@abstractdogabstractdogJun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about simply skipping this check, the next line takes care of wrapping it into an IOException anyway

@abstractdog
abstractdog self-requested a review June 23, 2026 06:36
@tez-yetus

tez-yetus commented Jun 23, 2026

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 43sMaven dependency ordering for branch
+1 💚mvninstall4m 52smaster passed
+1 💚compile3m 56smaster passed
+1 💚checkstyle1m 30smaster passed
+1 💚javadoc1m 50smaster passed
+0 🆗spotbugs0m 46stez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
+0 🆗spotbugs6m 54sroot in master has 1054 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 4sthe patch passed
+1 💚codespell1m 48sNo new issues.
+1 💚compile3m 57sthe patch passed
+1 💚javac3m 57sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 27sthe patch passed
+1 💚yamllint0m 1sNo new issues.
+1 💚javadoc1m 50sthe patch passed
+1 💚spotbugs8m 10sthe patch passed
_ Other Tests _
+1 💚unit71m 29sroot in the patch passed.
+1 💚asflicense1m 19sThe patch does not generate ASF License warnings.
118m 25s
SubsystemReport/Notes
DockerClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/6/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets yamllint javac javadoc xmllint spotbugs checkstyle
unameLinux 67cf53761eb5 5.15.0-177-generic #187-Ubuntu SMP Sat Apr 11 22:54:33 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / f924848
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/6/testReport/
Max. process+thread count1381 (vs. ulimit of 5500)
modulesC: tez-plugins/tez-aux-services . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-509/6/console
versionsgit=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 yamllint=1.38.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@ayushtkn
ayushtkn merged commit 61cc636 into apache:masterJun 23, 2026
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstractdogabstractdogabstractdog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ayushtkn@tez-yetus@abstractdog