Skip to content

[Relay][Op] Trilu operator implementation - #12124

Merged
mbrookhart merged 7 commits into
apache:mainfrom
jwfromm:trilu_op
Aug 2, 2022
Merged

[Relay][Op] Trilu operator implementation#12124
mbrookhart merged 7 commits into
apache:mainfrom
jwfromm:trilu_op

Conversation

@jwfromm

@jwfrommjwfromm commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

This PR adds a new operator that supports triangular masking similar to that in np.triu and np.tril. The addition of relay.trilu conveniently lets us pass many of the remaining onnx tests.

@jwfromm

jwfromm commented Jul 18, 2022

Copy link
Copy Markdown
ContributorAuthor

@sfvaroglu Can you take a look at this PR?

@sfvaroglu

sfvaroglu commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

LGTM! Thanks for doing this @jwfromm! cc @mikepapadim

@mikepapadim

mikepapadim commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

thanks @jwfromm, if this one is merged then we should close following as depreceated #11761#10873 and #9329

@jwfromm
jwfrommforce-pushed the trilu_op branch 2 times, most recently from 221026d to cc2864eCompareJuly 25, 2022 16:24
mbrookhart
mbrookhart approved these changes Jul 26, 2022
View reviewed changes
Comment threadtests/python/frontend/onnx/test_forward.py
"test_tril_one_row_neg",
"test_tril_out_neg",
"test_tril_out_pos",
"test_tril_zero",

@mbrookhartmbrookhartJul 26, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this op at all. How tricky would it be to support the zero case? Otherwise LGTM.

@jwfrommjwfrommJul 26, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually works on llvm and cuda. I was testing on my macbook and it seems like the metal backend in general doesnt support empty tensors. I think for CI we could add these cases.

@jwfrommjwfrommJul 26, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it also doesnt work with nvptx for the same issue with empty tensors. I'll add them here and see how it does in CI.

shingjan
shingjan approved these changes Jul 26, 2022
View reviewed changes

@shingjanshingjan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks for sending this in! Our pytorch frontend could use this new Trilu op as well. Just one nit.

Comment threadpython/tvm/relay/op/transform.py
@jwfromm

jwfromm commented Jul 27, 2022

Copy link
Copy Markdown
ContributorAuthor

I added pytorch testing and integration. Thanks for the recommendation @shingjan.

@jwfromm

jwfromm commented Jul 27, 2022

Copy link
Copy Markdown
ContributorAuthor

Unfortunately the empty tensor tests still fail on CI GPUs. I'm not sure why, it doesnt seem like its directly related to this PR so I'm going to reenable skips for those tests.

@jwfromm

jwfromm commented Aug 2, 2022

Copy link
Copy Markdown
ContributorAuthor

@mbrookhart I think this is ready to merge.

@mbrookhart
mbrookhart merged commit b8893b5 into apache:mainAug 2, 2022
@mbrookhart

mbrookhart commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @jwfromm@sfvaroglu@mikepapadim@shingjan

@AndrewZhaoLuoAndrewZhaoLuo mentioned this pull request Oct 4, 2022
Closed
@ganlerganler mentioned this pull request Oct 11, 2022
Closed
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Josh Fromm@xinetzone
[Relay][Op] Trilu operator implementation (apache#12124)
d2126de
* Added topi trilu implementation
* Implemented and tested full Trilu op.
* Fix test type.
* Add tril zero tests.
* Add pytorch trilu integration.
* Clean up torch integration.
* Readded skip for zero tests.
@jwfromm
jwfromm deleted the trilu_op branch April 12, 2023 15:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart approved these changes
+1 more reviewer
@shingjanshingjanshingjan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jwfromm@sfvaroglu@mikepapadim@mbrookhart@shingjan
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Relay][Op] Trilu operator implementation by jwfromm · Pull Request #12124 · apache/tvm · GitHub
Skip to content
[Relay][Op] Trilu operator implementation - #12124
Merged
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Aug 2, 2022
Merged
[Relay][Op] Trilu operator implementation#12124
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Conversation
@jwfromm
@jwfrommjwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

Contributor
This PR adds a new operator that supports triangular masking similar to that in np.triu and np.tril. The addition of relay.trilu conveniently lets us pass many of the remaining onnx tests.
@jwfromm
jwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@sfvaroglu Can you take a look at this PR?
@sfvaroglu
sfvaroglu
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
LGTM! Thanks for doing this @jwfromm! cc @mikepapadim
@mikepapadim
mikepapadim
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
thanks @jwfromm, if this one is merged then we should close following as depreceated #11761#10873 and #9329
@jwfromm
jwfrommforce-pushed
the
trilu_op
branch
2 times, most recently
from
221026d to
cc2864eCompareJuly 25, 2022 16:24
mbrookhart
mbrookhart
approved these changes
Jul 26, 2022
View reviewed changes
Comment threadtests/python/frontend/onnx/test_forward.py
 "test_tril_one_row_neg",
 "test_tril_out_neg",
 "test_tril_out_pos",
 "test_tril_zero",
@mbrookhartmbrookhartJul 26, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this op at all. How tricky would it be to support the zero case? Otherwise LGTM.
@jwfrommjwfrommJul 26, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually works on llvm and cuda. I was testing on my macbook and it seems like the metal backend in general doesnt support empty tensors. I think for CI we could add these cases.
@jwfrommjwfrommJul 26, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it also doesnt work with nvptx for the same issue with empty tensors. I'll add them here and see how it does in CI.
shingjan
shingjan
approved these changes
Jul 26, 2022
View reviewed changes
@shingjanshingjan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks for sending this in! Our pytorch frontend could use this new Trilu op as well. Just one nit.
Comment threadpython/tvm/relay/op/transform.py
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
I added pytorch testing and integration. Thanks for the recommendation @shingjan.
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
Unfortunately the empty tensor tests still fail on CI GPUs. I'm not sure why, it doesnt seem like its directly related to this PR so I'm going to reenable skips for those tests.
@jwfromm
jwfromm
commented
Aug 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@mbrookhart I think this is ready to merge.
@mbrookhart
mbrookhart
merged commit b8893b5
into
apache:mainAug 2, 2022
@mbrookhart
mbrookhart
commented
Aug 2, 2022

Copy link


Copy Markdown

Contributor
Thanks @jwfromm@sfvaroglu@mikepapadim@shingjan
@AndrewZhaoLuoAndrewZhaoLuo
mentioned this pull request
Oct 4, 2022

Closed

@ganlerganler
mentioned this pull request
Oct 11, 2022

Closed

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Josh Fromm@xinetzone
[Relay][Op] Trilu operator implementation (apache#12124)
d2126de
* Added topi trilu implementation
* Implemented and tested full Trilu op.
* Fix test type.
* Add tril zero tests.
* Add pytorch trilu integration.
* Clean up torch integration.
* Readded skip for zero tests.
@jwfromm
jwfromm
deleted the

trilu_op

branch
April 12, 2023 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart approved these changes

+1 more reviewer

@shingjanshingjanshingjan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jwfromm@sfvaroglu@mikepapadim@mbrookhart@shingjan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Relay][Op] Trilu operator implementation by jwfromm · Pull Request #12124 · apache/tvm · GitHub
Skip to content
[Relay][Op] Trilu operator implementation - #12124
Merged
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Aug 2, 2022
Merged
[Relay][Op] Trilu operator implementation#12124
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Conversation
@jwfromm
@jwfrommjwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

Contributor
This PR adds a new operator that supports triangular masking similar to that in np.triu and np.tril. The addition of relay.trilu conveniently lets us pass many of the remaining onnx tests.
@jwfromm
jwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@sfvaroglu Can you take a look at this PR?
@sfvaroglu
sfvaroglu
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
LGTM! Thanks for doing this @jwfromm! cc @mikepapadim
@mikepapadim
mikepapadim
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
thanks @jwfromm, if this one is merged then we should close following as depreceated #11761#10873 and #9329
@jwfromm
jwfrommforce-pushed
the
trilu_op
branch
2 times, most recently
from
221026d to
cc2864eCompareJuly 25, 2022 16:24
mbrookhart
mbrookhart
approved these changes
Jul 26, 2022
View reviewed changes
Comment threadtests/python/frontend/onnx/test_forward.py
 "test_tril_one_row_neg",
 "test_tril_out_neg",
 "test_tril_out_pos",
 "test_tril_zero",
@mbrookhartmbrookhartJul 26, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this op at all. How tricky would it be to support the zero case? Otherwise LGTM.
@jwfrommjwfrommJul 26, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually works on llvm and cuda. I was testing on my macbook and it seems like the metal backend in general doesnt support empty tensors. I think for CI we could add these cases.
@jwfrommjwfrommJul 26, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it also doesnt work with nvptx for the same issue with empty tensors. I'll add them here and see how it does in CI.
shingjan
shingjan
approved these changes
Jul 26, 2022
View reviewed changes
@shingjanshingjan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks for sending this in! Our pytorch frontend could use this new Trilu op as well. Just one nit.
Comment threadpython/tvm/relay/op/transform.py
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
I added pytorch testing and integration. Thanks for the recommendation @shingjan.
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
Unfortunately the empty tensor tests still fail on CI GPUs. I'm not sure why, it doesnt seem like its directly related to this PR so I'm going to reenable skips for those tests.
@jwfromm
jwfromm
commented
Aug 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@mbrookhart I think this is ready to merge.
@mbrookhart
mbrookhart
merged commit b8893b5
into
apache:mainAug 2, 2022
@mbrookhart
mbrookhart
commented
Aug 2, 2022

Copy link


Copy Markdown

Contributor
Thanks @jwfromm@sfvaroglu@mikepapadim@shingjan
@AndrewZhaoLuoAndrewZhaoLuo
mentioned this pull request
Oct 4, 2022

Closed

@ganlerganler
mentioned this pull request
Oct 11, 2022

Closed

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Josh Fromm@xinetzone
[Relay][Op] Trilu operator implementation (apache#12124)
d2126de
* Added topi trilu implementation
* Implemented and tested full Trilu op.
* Fix test type.
* Add tril zero tests.
* Add pytorch trilu integration.
* Clean up torch integration.
* Readded skip for zero tests.
@jwfromm
jwfromm
deleted the

trilu_op

branch
April 12, 2023 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart approved these changes

+1 more reviewer

@shingjanshingjanshingjan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jwfromm@sfvaroglu@mikepapadim@mbrookhart@shingjan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Relay][Op] Trilu operator implementation by jwfromm · Pull Request #12124 · apache/tvm · GitHub
Skip to content
[Relay][Op] Trilu operator implementation - #12124
Merged
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Aug 2, 2022
Merged
[Relay][Op] Trilu operator implementation#12124
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Conversation
@jwfromm
@jwfrommjwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

Contributor
This PR adds a new operator that supports triangular masking similar to that in np.triu and np.tril. The addition of relay.trilu conveniently lets us pass many of the remaining onnx tests.
@jwfromm
jwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@sfvaroglu Can you take a look at this PR?
@sfvaroglu
sfvaroglu
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
LGTM! Thanks for doing this @jwfromm! cc @mikepapadim
@mikepapadim
mikepapadim
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
thanks @jwfromm, if this one is merged then we should close following as depreceated #11761#10873 and #9329
@jwfromm
jwfrommforce-pushed
the
trilu_op
branch
2 times, most recently
from
221026d to
cc2864eCompareJuly 25, 2022 16:24
mbrookhart
mbrookhart
approved these changes
Jul 26, 2022
View reviewed changes
Comment threadtests/python/frontend/onnx/test_forward.py
 "test_tril_one_row_neg",
 "test_tril_out_neg",
 "test_tril_out_pos",
 "test_tril_zero",
@mbrookhartmbrookhartJul 26, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this op at all. How tricky would it be to support the zero case? Otherwise LGTM.
@jwfrommjwfrommJul 26, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually works on llvm and cuda. I was testing on my macbook and it seems like the metal backend in general doesnt support empty tensors. I think for CI we could add these cases.
@jwfrommjwfrommJul 26, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it also doesnt work with nvptx for the same issue with empty tensors. I'll add them here and see how it does in CI.
shingjan
shingjan
approved these changes
Jul 26, 2022
View reviewed changes
@shingjanshingjan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks for sending this in! Our pytorch frontend could use this new Trilu op as well. Just one nit.
Comment threadpython/tvm/relay/op/transform.py
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
I added pytorch testing and integration. Thanks for the recommendation @shingjan.
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
Unfortunately the empty tensor tests still fail on CI GPUs. I'm not sure why, it doesnt seem like its directly related to this PR so I'm going to reenable skips for those tests.
@jwfromm
jwfromm
commented
Aug 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@mbrookhart I think this is ready to merge.
@mbrookhart
mbrookhart
merged commit b8893b5
into
apache:mainAug 2, 2022
@mbrookhart
mbrookhart
commented
Aug 2, 2022

Copy link


Copy Markdown

Contributor
Thanks @jwfromm@sfvaroglu@mikepapadim@shingjan
@AndrewZhaoLuoAndrewZhaoLuo
mentioned this pull request
Oct 4, 2022

Closed

@ganlerganler
mentioned this pull request
Oct 11, 2022

Closed

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Josh Fromm@xinetzone
[Relay][Op] Trilu operator implementation (apache#12124)
d2126de
* Added topi trilu implementation
* Implemented and tested full Trilu op.
* Fix test type.
* Add tril zero tests.
* Add pytorch trilu integration.
* Clean up torch integration.
* Readded skip for zero tests.
@jwfromm
jwfromm
deleted the

trilu_op

branch
April 12, 2023 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart approved these changes

+1 more reviewer

@shingjanshingjanshingjan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jwfromm@sfvaroglu@mikepapadim@mbrookhart@shingjan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[Relay][Op] Trilu operator implementation by jwfromm · Pull Request #12124 · apache/tvm · GitHub
Skip to content
[Relay][Op] Trilu operator implementation - #12124
Merged
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Aug 2, 2022
Merged
[Relay][Op] Trilu operator implementation#12124
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Conversation
@jwfromm
@jwfrommjwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

Contributor
This PR adds a new operator that supports triangular masking similar to that in np.triu and np.tril. The addition of relay.trilu conveniently lets us pass many of the remaining onnx tests.
@jwfromm
jwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@sfvaroglu Can you take a look at this PR?
@sfvaroglu
sfvaroglu
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
LGTM! Thanks for doing this @jwfromm! cc @mikepapadim
@mikepapadim
mikepapadim
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
thanks @jwfromm, if this one is merged then we should close following as depreceated #11761#10873 and #9329
@jwfromm
jwfrommforce-pushed
the
trilu_op
branch
2 times, most recently
from
221026d to
cc2864eCompareJuly 25, 2022 16:24
mbrookhart
mbrookhart
approved these changes
Jul 26, 2022
View reviewed changes
Comment threadtests/python/frontend/onnx/test_forward.py
 "test_tril_one_row_neg",
 "test_tril_out_neg",
 "test_tril_out_pos",
 "test_tril_zero",
@mbrookhartmbrookhartJul 26, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this op at all. How tricky would it be to support the zero case? Otherwise LGTM.
@jwfrommjwfrommJul 26, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually works on llvm and cuda. I was testing on my macbook and it seems like the metal backend in general doesnt support empty tensors. I think for CI we could add these cases.
@jwfrommjwfrommJul 26, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it also doesnt work with nvptx for the same issue with empty tensors. I'll add them here and see how it does in CI.
shingjan
shingjan
approved these changes
Jul 26, 2022
View reviewed changes
@shingjanshingjan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks for sending this in! Our pytorch frontend could use this new Trilu op as well. Just one nit.
Comment threadpython/tvm/relay/op/transform.py
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
I added pytorch testing and integration. Thanks for the recommendation @shingjan.
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
Unfortunately the empty tensor tests still fail on CI GPUs. I'm not sure why, it doesnt seem like its directly related to this PR so I'm going to reenable skips for those tests.
@jwfromm
jwfromm
commented
Aug 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@mbrookhart I think this is ready to merge.
@mbrookhart
mbrookhart
merged commit b8893b5
into
apache:mainAug 2, 2022
@mbrookhart
mbrookhart
commented
Aug 2, 2022

Copy link


Copy Markdown

Contributor
Thanks @jwfromm@sfvaroglu@mikepapadim@shingjan
@AndrewZhaoLuoAndrewZhaoLuo
mentioned this pull request
Oct 4, 2022

Closed

@ganlerganler
mentioned this pull request
Oct 11, 2022

Closed

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Josh Fromm@xinetzone
[Relay][Op] Trilu operator implementation (apache#12124)
d2126de
* Added topi trilu implementation
* Implemented and tested full Trilu op.
* Fix test type.
* Add tril zero tests.
* Add pytorch trilu integration.
* Clean up torch integration.
* Readded skip for zero tests.
@jwfromm
jwfromm
deleted the

trilu_op

branch
April 12, 2023 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart approved these changes

+1 more reviewer

@shingjanshingjanshingjan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jwfromm@sfvaroglu@mikepapadim@mbrookhart@shingjan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Relay][Op] Trilu operator implementation by jwfromm · Pull Request #12124 · apache/tvm · GitHub
Skip to content
[Relay][Op] Trilu operator implementation - #12124
Merged
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Aug 2, 2022
Merged
[Relay][Op] Trilu operator implementation#12124
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Conversation
@jwfromm
@jwfrommjwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

Contributor
This PR adds a new operator that supports triangular masking similar to that in np.triu and np.tril. The addition of relay.trilu conveniently lets us pass many of the remaining onnx tests.
@jwfromm
jwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@sfvaroglu Can you take a look at this PR?
@sfvaroglu
sfvaroglu
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
LGTM! Thanks for doing this @jwfromm! cc @mikepapadim
@mikepapadim
mikepapadim
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
thanks @jwfromm, if this one is merged then we should close following as depreceated #11761#10873 and #9329
@jwfromm
jwfrommforce-pushed
the
trilu_op
branch
2 times, most recently
from
221026d to
cc2864eCompareJuly 25, 2022 16:24
mbrookhart
mbrookhart
approved these changes
Jul 26, 2022
View reviewed changes
Comment threadtests/python/frontend/onnx/test_forward.py
 "test_tril_one_row_neg",
 "test_tril_out_neg",
 "test_tril_out_pos",
 "test_tril_zero",
@mbrookhartmbrookhartJul 26, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this op at all. How tricky would it be to support the zero case? Otherwise LGTM.
@jwfrommjwfrommJul 26, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually works on llvm and cuda. I was testing on my macbook and it seems like the metal backend in general doesnt support empty tensors. I think for CI we could add these cases.
@jwfrommjwfrommJul 26, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it also doesnt work with nvptx for the same issue with empty tensors. I'll add them here and see how it does in CI.
shingjan
shingjan
approved these changes
Jul 26, 2022
View reviewed changes
@shingjanshingjan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks for sending this in! Our pytorch frontend could use this new Trilu op as well. Just one nit.
Comment threadpython/tvm/relay/op/transform.py
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
I added pytorch testing and integration. Thanks for the recommendation @shingjan.
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
Unfortunately the empty tensor tests still fail on CI GPUs. I'm not sure why, it doesnt seem like its directly related to this PR so I'm going to reenable skips for those tests.
@jwfromm
jwfromm
commented
Aug 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@mbrookhart I think this is ready to merge.
@mbrookhart
mbrookhart
merged commit b8893b5
into
apache:mainAug 2, 2022
@mbrookhart
mbrookhart
commented
Aug 2, 2022

Copy link


Copy Markdown

Contributor
Thanks @jwfromm@sfvaroglu@mikepapadim@shingjan
@AndrewZhaoLuoAndrewZhaoLuo
mentioned this pull request
Oct 4, 2022

Closed

@ganlerganler
mentioned this pull request
Oct 11, 2022

Closed

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Josh Fromm@xinetzone
[Relay][Op] Trilu operator implementation (apache#12124)
d2126de
* Added topi trilu implementation
* Implemented and tested full Trilu op.
* Fix test type.
* Add tril zero tests.
* Add pytorch trilu integration.
* Clean up torch integration.
* Readded skip for zero tests.
@jwfromm
jwfromm
deleted the

trilu_op

branch
April 12, 2023 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart approved these changes

+1 more reviewer

@shingjanshingjanshingjan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jwfromm@sfvaroglu@mikepapadim@mbrookhart@shingjan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Relay][Op] Trilu operator implementation by jwfromm · Pull Request #12124 · apache/tvm · GitHub
Skip to content
[Relay][Op] Trilu operator implementation - #12124
Merged
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Aug 2, 2022
Merged
[Relay][Op] Trilu operator implementation#12124
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Conversation
@jwfromm
@jwfrommjwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

Contributor
This PR adds a new operator that supports triangular masking similar to that in np.triu and np.tril. The addition of relay.trilu conveniently lets us pass many of the remaining onnx tests.
@jwfromm
jwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@sfvaroglu Can you take a look at this PR?
@sfvaroglu
sfvaroglu
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
LGTM! Thanks for doing this @jwfromm! cc @mikepapadim
@mikepapadim
mikepapadim
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
thanks @jwfromm, if this one is merged then we should close following as depreceated #11761#10873 and #9329
@jwfromm
jwfrommforce-pushed
the
trilu_op
branch
2 times, most recently
from
221026d to
cc2864eCompareJuly 25, 2022 16:24
mbrookhart
mbrookhart
approved these changes
Jul 26, 2022
View reviewed changes
Comment threadtests/python/frontend/onnx/test_forward.py
 "test_tril_one_row_neg",
 "test_tril_out_neg",
 "test_tril_out_pos",
 "test_tril_zero",
@mbrookhartmbrookhartJul 26, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this op at all. How tricky would it be to support the zero case? Otherwise LGTM.
@jwfrommjwfrommJul 26, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually works on llvm and cuda. I was testing on my macbook and it seems like the metal backend in general doesnt support empty tensors. I think for CI we could add these cases.
@jwfrommjwfrommJul 26, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it also doesnt work with nvptx for the same issue with empty tensors. I'll add them here and see how it does in CI.
shingjan
shingjan
approved these changes
Jul 26, 2022
View reviewed changes
@shingjanshingjan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks for sending this in! Our pytorch frontend could use this new Trilu op as well. Just one nit.
Comment threadpython/tvm/relay/op/transform.py
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
I added pytorch testing and integration. Thanks for the recommendation @shingjan.
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
Unfortunately the empty tensor tests still fail on CI GPUs. I'm not sure why, it doesnt seem like its directly related to this PR so I'm going to reenable skips for those tests.
@jwfromm
jwfromm
commented
Aug 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@mbrookhart I think this is ready to merge.
@mbrookhart
mbrookhart
merged commit b8893b5
into
apache:mainAug 2, 2022
@mbrookhart
mbrookhart
commented
Aug 2, 2022

Copy link


Copy Markdown

Contributor
Thanks @jwfromm@sfvaroglu@mikepapadim@shingjan
@AndrewZhaoLuoAndrewZhaoLuo
mentioned this pull request
Oct 4, 2022

Closed

@ganlerganler
mentioned this pull request
Oct 11, 2022

Closed

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Josh Fromm@xinetzone
[Relay][Op] Trilu operator implementation (apache#12124)
d2126de
* Added topi trilu implementation
* Implemented and tested full Trilu op.
* Fix test type.
* Add tril zero tests.
* Add pytorch trilu integration.
* Clean up torch integration.
* Readded skip for zero tests.
@jwfromm
jwfromm
deleted the

trilu_op

branch
April 12, 2023 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart approved these changes

+1 more reviewer

@shingjanshingjanshingjan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jwfromm@sfvaroglu@mikepapadim@mbrookhart@shingjan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[Relay][Op] Trilu operator implementation by jwfromm · Pull Request #12124 · apache/tvm · GitHub
Skip to content
[Relay][Op] Trilu operator implementation - #12124
Merged
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Aug 2, 2022
Merged
[Relay][Op] Trilu operator implementation#12124
mbrookhart merged 7 commits into
apache:mainfrom 
jwfromm:trilu_op
Conversation
@jwfromm
@jwfrommjwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

Contributor
This PR adds a new operator that supports triangular masking similar to that in np.triu and np.tril. The addition of relay.trilu conveniently lets us pass many of the remaining onnx tests.
@jwfromm
jwfromm
commented
Jul 18, 2022

Copy link


Copy Markdown

ContributorAuthor
@sfvaroglu Can you take a look at this PR?
@sfvaroglu
sfvaroglu
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
LGTM! Thanks for doing this @jwfromm! cc @mikepapadim
@mikepapadim
mikepapadim
commented
Jul 19, 2022

Copy link


Copy Markdown

Contributor
thanks @jwfromm, if this one is merged then we should close following as depreceated #11761#10873 and #9329
@jwfromm
jwfrommforce-pushed
the
trilu_op
branch
2 times, most recently
from
221026d to
cc2864eCompareJuly 25, 2022 16:24
mbrookhart
mbrookhart
approved these changes
Jul 26, 2022
View reviewed changes
Comment threadtests/python/frontend/onnx/test_forward.py
 "test_tril_one_row_neg",
 "test_tril_out_neg",
 "test_tril_out_pos",
 "test_tril_zero",
@mbrookhartmbrookhartJul 26, 2022

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this op at all. How tricky would it be to support the zero case? Otherwise LGTM.
@jwfrommjwfrommJul 26, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually works on llvm and cuda. I was testing on my macbook and it seems like the metal backend in general doesnt support empty tensors. I think for CI we could add these cases.
@jwfrommjwfrommJul 26, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it also doesnt work with nvptx for the same issue with empty tensors. I'll add them here and see how it does in CI.
shingjan
shingjan
approved these changes
Jul 26, 2022
View reviewed changes
@shingjanshingjan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks for sending this in! Our pytorch frontend could use this new Trilu op as well. Just one nit.
Comment threadpython/tvm/relay/op/transform.py
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
I added pytorch testing and integration. Thanks for the recommendation @shingjan.
@jwfromm
jwfromm
commented
Jul 27, 2022

Copy link


Copy Markdown

ContributorAuthor
Unfortunately the empty tensor tests still fail on CI GPUs. I'm not sure why, it doesnt seem like its directly related to this PR so I'm going to reenable skips for those tests.
@jwfromm
jwfromm
commented
Aug 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@mbrookhart I think this is ready to merge.
@mbrookhart
mbrookhart
merged commit b8893b5
into
apache:mainAug 2, 2022
@mbrookhart
mbrookhart
commented
Aug 2, 2022

Copy link


Copy Markdown

Contributor
Thanks @jwfromm@sfvaroglu@mikepapadim@shingjan
@AndrewZhaoLuoAndrewZhaoLuo
mentioned this pull request
Oct 4, 2022

Closed

@ganlerganler
mentioned this pull request
Oct 11, 2022

Closed

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Josh Fromm@xinetzone
[Relay][Op] Trilu operator implementation (apache#12124)
d2126de
* Added topi trilu implementation
* Implemented and tested full Trilu op.
* Fix test type.
* Add tril zero tests.
* Add pytorch trilu integration.
* Clean up torch integration.
* Readded skip for zero tests.
@jwfromm
jwfromm
deleted the

trilu_op

branch
April 12, 2023 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart approved these changes

+1 more reviewer

@shingjanshingjanshingjan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jwfromm@sfvaroglu@mikepapadim@mbrookhart@shingjan