Uh oh!
There was an error while loading. Please reload this page.
[Relay/TOPI][ONNX/TFLite] Refactor MATRIX_SET_DIAG Operator for Relay… - #9329
[Relay/TOPI][ONNX/TFLite] Refactor MATRIX_SET_DIAG Operator for Relay…#9329shengxinhu wants to merge 8 commits into
Conversation
…/TOPI to support ONNX Trilu operator
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
Looks mostly right to me, have a few comments. Will take a closer look later though.
Also please fix the lint issues so we can run CI
| // Determining which diagonal/sub-diagonal/super-diagonal it is | ||
| k = iter_vars[ndim] - iter_vars[ndim - 1]; | ||
| diagonal_indices.push_back(k2 - k); | ||
| diagonal_indices.push_back(k2(0) - k); |
There was a problem hiding this comment.
I believe (though please check) that you can just do k2() for 0-D tensor access.
There was a problem hiding this comment.
k2() will report error
| """Operator converter for Trilu""" | ||
| @classmethod | ||
| def _impl_v1(cls, inputs, attr, params): |
There was a problem hiding this comment.
this should be opset14 so _impl_v14
| @classmethod | ||
| def _impl_v1(cls, inputs, attr, params): | ||
| upper = attr.get("upper") |
There was a problem hiding this comment.
suggest attr.get("upper", 1) since this appears to be the default in onnx spec
onnx and onnxruntime version need to be updated to version 1.10.1 and 1.9.0 respectively for Trilu operator, |
AndrewZhaoLuo
commented
Oct 28, 2021
Let me talk to some folks about doing this. |
AndrewZhaoLuo
commented
Nov 1, 2021
Hmm this will eventually get merged, I might get to upgrading CI next week |
AndrewZhaoLuo
commented
Nov 15, 2021
Working on upgrading onnx right now #9511 |
shengxinhu
commented
Jan 11, 2022
wait for #9882 |
masahi
commented
Jan 18, 2022
The new image with updated ONNX should become available by this week. |
New CI image with updated onnx is (finally up)! Please jostle ci by sending an empty commit |
AndrewZhaoLuo
commented
Jan 24, 2022
@shengxinhu do you still have interest in working to get this PR merged? If not then I can try to shepard this in new branch. |
shengxinhu
commented
Jan 26, 2022
Thanks, please shepard it. |
…/TOPI to support ONNX Trilu operator This commit is based on PR apache#9329 proposed by @shengxinhu. Refactor MATRIX_SET_DIAG operator in Relay/TOPI to support ONNX Trilu operator; + Fixed issues related to shape transformation of inputs in tflite and onnx frontend ops.
Refactor MATRIX_SET_DIAG operator in Relay/TOPI to support ONNX Trilu operator