Uh oh!
There was an error while loading. Please reload this page.
[QNN] InferType changes that missed CI. - #3779
Conversation
| mod = relay.Module.from_expr(data[0]) | ||
| mod = relay.transform.InferType()(mod) | ||
| entry = mod["main"] | ||
| data0 = entry if isinstance(data[0], relay.Function) else entry.body |
There was a problem hiding this comment.
Why not use from ...frontend.common import infer_type. It seems unnecessary duplication of code. If the namespace is a problem we should probably move the existing method to a better place?
There was a problem hiding this comment.
Also, it seems the method from ...frontend.common import infer_type has more checks.
There was a problem hiding this comment.
It seems strange to import pass like infer_type from frontend. Should we consider create shortcut for infer_type? @jroesch
There was a problem hiding this comment.
Shortcut seems like a good idea.
Maybe, we can get this in to unblock CI and then follow up with another PR for shortcut and related changes to remove code duplication.
@vinx13@ZihengJiang
Added a quick fix to unblock CI. Will think about requantize default output_dtype to remove the dependence on InferType.