Skip to content

QNN quantize and dequantize operators. - #3745

Merged
vinx13 merged 13 commits into
apache:masterfrom
anijain2305:quantize-dequantize-v2
Aug 16, 2019
Merged

QNN quantize and dequantize operators.#3745
vinx13 merged 13 commits into
apache:masterfrom
anijain2305:quantize-dequantize-v2

Conversation

@shoubhik

@shoubhikshoubhik commented Aug 9, 2019

Copy link
Copy Markdown
Contributor

This is a followup PR for #3531. It has the implementations for the Quantize and Dequantize operators.

anijain2305
anijain2305 reviewed Aug 9, 2019
View reviewed changes
Comment threadpython/tvm/relay/qnn/op/qnn.py Outdated
Comment threadpython/tvm/relay/qnn/op/qnn.py Outdated
Comment threadpython/tvm/relay/qnn/op/qnn.py Outdated
Comment threadpython/tvm/relay/qnn/op/qnn.py Outdated
Comment threadpython/tvm/relay/qnn/op/qnn.py Outdated
Comment threadsrc/relay/qnn/op/quantize_op.cc Outdated
Comment threadsrc/relay/qnn/op/quantize_op.cc Outdated
Comment threadsrc/relay/qnn/op/quantize_op.cc
Comment threadsrc/relay/qnn/op/requantize.cc Outdated
Comment threadtests/python/relay/test_qnn_dequantize.py
anijain2305
anijain2305 reviewed Aug 9, 2019
View reviewed changes
Comment threadsrc/relay/qnn/op/quantize_op.cc
anijain2305
anijain2305 reviewed Aug 12, 2019
View reviewed changes
Comment threadpython/tvm/relay/qnn/op/qnn.py Outdated
anijain2305
anijain2305 reviewed Aug 12, 2019
View reviewed changes
Comment threadsrc/relay/qnn/op/dequantize.cc Outdated
anijain2305
anijain2305 reviewed Aug 12, 2019
View reviewed changes
Comment threadsrc/relay/qnn/op/quantize_op.cc Outdated
anijain2305
anijain2305 reviewed Aug 12, 2019
View reviewed changes
Comment threadtests/python/relay/test_qnn_quantize.py Outdated
anijain2305
anijain2305 approved these changes Aug 12, 2019
View reviewed changes

@anijain2305anijain2305 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

@shoubhik

shoubhik commented Aug 12, 2019

Copy link
Copy Markdown
ContributorAuthor

@u99127, @FrozenGene, @jackwish, @tqchen can you take a look at this PR.

@FrozenGene

FrozenGene commented Aug 13, 2019

Copy link
Copy Markdown
Member

@u99127, @FrozenGene, @jackwish, @tqchen can you take a look at this PR.

Hi @shoubhik I have a little busy today. I could have time to look tomorrow. Thanks.

zhenhuaw-me
zhenhuaw-me approved these changes Aug 13, 2019
View reviewed changes

@zhenhuaw-mezhenhuaw-me left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some naming things. Thank you.

Comment threadpython/tvm/relay/qnn/op/qnn.py Outdated
Comment threadpython/tvm/relay/qnn/op/qnn.py Outdated
Comment threadsrc/relay/qnn/op/dequantize.cc Outdated
Comment threadsrc/relay/qnn/op/quantize_op.cc Outdated
Comment threadsrc/relay/qnn/op/quantize_op.cc Outdated
leo-blonk
leo-blonk approved these changes Aug 13, 2019
View reviewed changes

@leo-blonkleo-blonk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jackwish's comments make sense to me but other than that LGTM.

@shoubhik

shoubhik commented Aug 14, 2019

Copy link
Copy Markdown
ContributorAuthor

Resolved all the style related comments.

@anijain2305

anijain2305 commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

@tqchen Can you please review and merge this, given we have approvals from all the stakeholders.

@tqchen

tqchen commented Aug 14, 2019

Copy link
Copy Markdown
Member

Sorry I will be traveling in the incoming weeks, perhaps @ZihengJiang@vinx13 can help manage QNN related PRs

@shoubhik

shoubhik commented Aug 14, 2019

Copy link
Copy Markdown
ContributorAuthor

@ZihengJiang@vinx13 can you review and merge this PR.

vinx13
vinx13 approved these changes Aug 14, 2019
View reviewed changes

@vinx13vinx13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change and please get CI passed

Comment threadsrc/relay/qnn/op/quantize.cc Outdated
@vinx13

vinx13 commented Aug 14, 2019

Copy link
Copy Markdown
Member

@shoubhik Please resolve the conflict (I have merged the other PR)

shoubhikbhatti@gmail.com
Merge branch 'master' into quantize-dequantize-v2
51044db
# Conflicts:
#	python/tvm/relay/qnn/op/qnn.py
@shoubhik

shoubhik commented Aug 15, 2019

Copy link
Copy Markdown
ContributorAuthor

There is a dependency on #3779. Once it is merged the test case can pass.

@anijain2305

anijain2305 commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

@vinx13 Can this be merged now?

@anijain2305anijain2305 mentioned this pull request Aug 15, 2019
Merged
vinx13
vinx13 reviewed Aug 16, 2019
View reviewed changes
Comment threadtests/python/relay/test_qnn_quantize.py Outdated
@shoubhik

shoubhik commented Aug 16, 2019

Copy link
Copy Markdown
ContributorAuthor

@vinx13 can it be merged now?

@vinx13
vinx13 merged commit d3eb9cb into apache:masterAug 16, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Aug 16, 2019
@shoubhikWei Chen
QNN quantize and dequantize operators. (apache#3745)
ff4c82c
* QNN quantize and dequantize operators.
* addressing review comments.
* addressing review comments.
* Adding new line at the end of the file.
* Adhering to styling guidelines.
* Adding name to contributors.
* Fixing lint issue.
* Fixing file name.
* Removing unnecessary code.
anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Aug 22, 2019
@shoubhik@anijain2305
QNN quantize and dequantize operators. (apache#3745)
b818fd5
* QNN quantize and dequantize operators.
* addressing review comments.
* addressing review comments.
* Adding new line at the end of the file.
* Adhering to styling guidelines.
* Adding name to contributors.
* Fixing lint issue.
* Fixing file name.
* Removing unnecessary code.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
@shoubhikWei Chen
QNN quantize and dequantize operators. (apache#3745)
1f5d289
* QNN quantize and dequantize operators.
* addressing review comments.
* addressing review comments.
* Adding new line at the end of the file.
* Adhering to styling guidelines.
* Adding name to contributors.
* Fixing lint issue.
* Fixing file name.
* Removing unnecessary code.
@tqchentqchen mentioned this pull request Nov 8, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinx13vinx13vinx13 approved these changes
@FrozenGeneFrozenGeneFrozenGene approved these changes
@anijain2305anijain2305anijain2305 approved these changes
+2 more reviewers
@zhenhuaw-mezhenhuaw-mezhenhuaw-me approved these changes
@leo-blonkleo-blonkleo-blonk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shoubhik@FrozenGene@anijain2305@tqchen@vinx13@zhenhuaw-me@leo-blonk