Skip to content

[Relay][TopHub] Add switch to disable TopHub download - #4015

Merged
tqchen merged 5 commits into
apache:masterfrom
soiferj:disable_tophub
Oct 3, 2019
Merged

[Relay][TopHub] Add switch to disable TopHub download#4015
tqchen merged 5 commits into
apache:masterfrom
soiferj:disable_tophub

Conversation

@soiferj

Copy link
Copy Markdown
Contributor

Add a switch to disable downloading from TopHub. On machines which don't have internet access, failing to download from TopHub slows down relay.build significantly.

@merrymercy would you be able to take a look?

@tqchen

Copy link
Copy Markdown
Member

This seems to be a behavior that can be configured by env variable, by specifying the tophub location rather than putting it into a build. We could avoid download when the location is specified to be none

@soiferj

Copy link
Copy Markdown
ContributorAuthor

I’m fine with that solution, but it doesn’t seem backward compatible for people who depend on tophub today. Do you know if a lot of people rely on it?

I suppose this could work if we used the default location when the environment variable isn’t set, and if we set it to NONE explicitly then we don’t download. That seems a little strange though.

@tqchen

Copy link
Copy Markdown
Member

Let us keep the backward compact by setting the default loc if not set for now.

@yzhliuyzhliu added the status: need update need update based on feedbacks label Sep 29, 2019
@soiferj

soiferj commented Sep 30, 2019

Copy link
Copy Markdown
ContributorAuthor

Updated to read from environment variable TOPHUB_LOCATION. If it's set to NONE, we will return EmptyContext.

@soiferj

Copy link
Copy Markdown
ContributorAuthor

@merrymercy@yzhliu would you be able to take a look?

@tqchen
tqchen merged commit 8111802 into apache:masterOct 3, 2019
@merrymercy

Copy link
Copy Markdown
Member

@soiferj Thanks. It is merged

@tqchentqchen added status: accepted and removed status: need update need update based on feedbacks labels Oct 4, 2019
anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Oct 17, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 18, 2019
@soiferj
soiferj deleted the disable_tophub branch October 23, 2019 22:06
petrex pushed a commit to petrex/tvm that referenced this pull request Oct 29, 2019
* master: (21 commits)
[Fix][VM] Fix VM invoke with set_params (apache#4079)
[QNN] Refactor fixed point multiplication in requantize (apache#4073)
Fix match case in Python-side expr functor (apache#4037)
Hide symbols from dependent libraries if HIDE_PRIVATE_SYMBOLS is ON. (apache#4041)
Add gradient for log-softmax (apache#4069)
[DOC] Fix typos in tutorials (apache#4066)
dicrease the complexity of CalcDep from exponential to linear (apache#4053)
[Relay][AlterOp] Minor refactor. (apache#4064)
[Relay][AlterOp] Improving support for broadcast layout alteration. (apache#4040)
Add parses support for zeros_like tflite operator (apache#4042)
[Bugfix][TF] reset graph after getting tag of savedmodel (apache#4055)
[Relay][VM] Add more passes to VMCompiler (apache#4058)
[Relay][VM] Add autotvm context when compile (apache#4062)
[Bugfix] Fix target host for vm compiler (apache#4057)
[Relay][Training] Add gradient for Crossentropy (apache#3925)
[llvm] switch to use Align for llvm trunk (apache#4051)
[Relay][TopHub] Add switch to disable TopHub download (apache#4015)
[Relay][Op] Add instance norm op (apache#4004)
[QNN][Relay] Calling Dialect passes from inside Relay Build API. (apache#3971)
[RELAY/PASS] Fix the extent for the post_stmt in the loop partition (apache#3734)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@soiferj@tqchen@merrymercy@yzhliu@jonso4