dicrease the complexity of CalcDep from exponential to linear by yaochengji · Pull Request #4053 · apache/tvm

yaochengji · 2019-10-03T14:38:18Z

The DCE pass bug is not caused by infinite loop, it is just time consuming.

@MarisaKirisame please review, thanks!

MarisaKirisame · 2019-10-03T17:16:19Z

LGTM.
note that you should not pass in a graph to DCE. We only intend for it to support tree form. In general, all the high level analysis/pass (pointer analysis, partial eval, dead code elimination, ad) all assume the input is in tree form.

yaochengji · 2019-10-04T00:27:16Z

Why is it assumed a tree form? I can see that the base class ExprVisitor also use the visit_counter_ to make sure all the expr are visited once.

MarisaKirisame · 2019-10-04T00:43:47Z

@yaochengji because what does it mean for a graph form program to have scope and effect?

yaochengji · 2019-10-04T07:05:05Z

@MarisaKirisame but I think since using a visit_counter to guarantee the complexity is a default behavior in ExprVisitor, it should not be dropped in CalcDep .

cc @icemelon9

MarisaKirisame · 2019-10-04T11:26:51Z

you can still has it. I just mean you should not pass graph in.

yaochengji · 2019-10-05T13:54:05Z

@MarisaKirisame do you think this commit should be merged?

MarisaKirisame · 2019-10-05T22:21:14Z

sure. It will increase the robustness of the DCE.

vinx13 · 2019-10-06T02:16:13Z

Please add a test case

yaochengji · 2019-10-06T04:07:56Z

@vinx13 Done.

vinx13 · 2019-10-06T14:56:09Z

 void VisitExpr(const Expr& e) final {
- return ExprFunctor<void(const Expr& e)>::VisitExpr(e);
+ visit_counter_[e.get()]++;
+ if (visit_counter_[e.get()] <= 2) {


the dce code seprate variable into three parts:
used 0 times (remove)
used 1 times (inline)
used 2 times (dont do anything).

okay, let's add a comment

vinx13 · 2019-10-07T03:02:37Z

Thanks @yaochengji @MarisaKirisame this is merged

…#4053)

* master: (21 commits) [Fix][VM] Fix VM invoke with set_params (apache#4079) [QNN] Refactor fixed point multiplication in requantize (apache#4073) Fix match case in Python-side expr functor (apache#4037) Hide symbols from dependent libraries if HIDE_PRIVATE_SYMBOLS is ON. (apache#4041) Add gradient for log-softmax (apache#4069) [DOC] Fix typos in tutorials (apache#4066) dicrease the complexity of CalcDep from exponential to linear (apache#4053) [Relay][AlterOp] Minor refactor. (apache#4064) [Relay][AlterOp] Improving support for broadcast layout alteration. (apache#4040) Add parses support for zeros_like tflite operator (apache#4042) [Bugfix][TF] reset graph after getting tag of savedmodel (apache#4055) [Relay][VM] Add more passes to VMCompiler (apache#4058) [Relay][VM] Add autotvm context when compile (apache#4062) [Bugfix] Fix target host for vm compiler (apache#4057) [Relay][Training] Add gradient for Crossentropy (apache#3925) [llvm] switch to use Align for llvm trunk (apache#4051) [Relay][TopHub] Add switch to disable TopHub download (apache#4015) [Relay][Op] Add instance norm op (apache#4004) [QNN][Relay] Calling Dialect passes from inside Relay Build API. (apache#3971) [RELAY/PASS] Fix the extent for the post_stmt in the loop partition (apache#3734) ...

yaochengji force-pushed the fix-dce-pass branch from fe3beaf to f75253cCompare October 3, 2019 14:48

MarisaKirisame approved these changes Oct 5, 2019
View reviewed changes

vinx13 added the status: need test case need test cases to cover the change label Oct 6, 2019

yaochengji force-pushed the fix-dce-pass branch from f75253c to e08a1f1Compare October 6, 2019 04:06

vinx13 reviewed Oct 6, 2019
View reviewed changes

vinx13 removed the status: need test case need test cases to cover the change label Oct 6, 2019

dicrease the complexity of CalcDep from exponential to linear
90c5b30

yaochengji force-pushed the fix-dce-pass branch from e08a1f1 to 90c5b30Compare October 7, 2019 00:47

yaochengji requested a review from vinx13 October 7, 2019 00:53

vinx13 approved these changes Oct 7, 2019
View reviewed changes

vinx13 merged commit 2241272 into apache:masterOct 7, 2019

vinx13 added the status: accepted label Oct 7, 2019

anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Oct 17, 2019
dicrease the complexity of CalcDep from exponential to linear (apache…
532b3fc
…#4053)

wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 18, 2019
dicrease the complexity of CalcDep from exponential to linear (apache…
4b1b88f
…#4053)

tqchen mentioned this pull request Nov 8, 2019
[RELEASE][DRAFT] TVM v0.6 Release candidate #4259
Closed

ANSHUMAN87 mentioned this pull request Mar 4, 2020
[Relay] Dead code elimination pass blows up call stack #4534
Closed

Uh oh!

Conversation

yaochengji commented Oct 3, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarisaKirisame commented Oct 3, 2019

Uh oh!

yaochengji commented Oct 4, 2019

Uh oh!

MarisaKirisame commented Oct 4, 2019

Uh oh!

yaochengji commented Oct 4, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarisaKirisame commented Oct 4, 2019

Uh oh!

yaochengji commented Oct 5, 2019

Uh oh!

MarisaKirisame commented Oct 5, 2019

Uh oh!

vinx13 commented Oct 6, 2019

Uh oh!

yaochengji commented Oct 6, 2019

Uh oh!

vinx13Oct 6, 2019

Choose a reason for hiding this comment

Uh oh!

MarisaKirisameOct 6, 2019

Choose a reason for hiding this comment

Uh oh!

vinx13Oct 6, 2019

Choose a reason for hiding this comment

Uh oh!

yaochengjiOct 7, 2019

Choose a reason for hiding this comment

Uh oh!

vinx13 commented Oct 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yaochengji commented Oct 3, 2019•
edited
Loading

yaochengji commented Oct 4, 2019•
edited
Loading