Skip to content

imp module is deprecated - #4275

Merged
tqchen merged 13 commits into
apache:masterfrom
were:deprecate
Nov 15, 2019
Merged

imp module is deprecated#4275
tqchen merged 13 commits into
apache:masterfrom
were:deprecate

Conversation

@were

@werewere commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

Python deprecated imp module, so we can no longer use imp.load_source to import a file by a path.

A workaround is to execute the source so that the defined closures are imported in the symbol table (aka. environment).

@were

were commented Nov 7, 2019

Copy link
Copy Markdown
ContributorAuthor

@junrushao1994 Can you take a look?

junrushao
junrushao reviewed Nov 7, 2019
View reviewed changes

@junrushaojunrushao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other workarounds to exec? Pylint doesn’t seem to like it. Otherwise you should disable pylint on that line

@junrushao

junrushao commented Nov 10, 2019

Copy link
Copy Markdown
Member

Seems like your PR failed on an irrelevant place, so feel free to re-trigger it.

BTW, I saw there is usage of import imp as well in topi/python/topi/cpp.py:21. Could you also fix this if it is easy?

@yzhliuyzhliu added the status: need update need update based on feedbacks label Nov 11, 2019
@were

were commented Nov 15, 2019

Copy link
Copy Markdown
ContributorAuthor

In topi.cpp, a bunch of dummy modules are created to get rid of a bunch of modules with only one line.

This can perfectly achieve exactly the same effect to replace imp.

On the other hand, I know it is acceptable to have modules just load FFI, like tvm.arith.

I am not sure which one is a better way to get rid of imp.

@were

were commented Nov 15, 2019

Copy link
Copy Markdown
ContributorAuthor

@Laurawly@Huyuwei Any suggestions?

junrushao
junrushao reviewed Nov 15, 2019
View reviewed changes
Comment threadtopi/python/topi/cpp/__init__.py
@@ -0,0 +1,9 @@
"""FFI for C++ TOPI ops and schedules"""

@junrushaojunrushaoNov 15, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this file does not have an ASF header and could still pass our test?

Comment threadtopi/python/topi/cpp/vision/__init__.py
@@ -0,0 +1,7 @@
"""FFI for vision TOPI ops and schedules"""

@junrushaojunrushaoNov 15, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this file does not have an ASF header and could still pass our test?

@werewereNov 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know. When linting, it just asks me to add ASF header to new files but init.py.

@werewereNov 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/incubator-tvm/blob/master/topi/python/topi/x86/__init__.py
This also does not have ASF header.
I do not know why either.

@junrushaojunrushaoNov 15, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I am fine with it :-)

@tqchen
tqchen merged commit 9e6371f into apache:masterNov 15, 2019
@tqchen

tqchen commented Nov 15, 2019

Copy link
Copy Markdown
Member

Thanks @were@junrushao1994

@tqchentqchen added status: accepted and removed status: need update need update based on feedbacks labels Nov 15, 2019
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Nov 15, 2019
Jian WengXingyu Zhou
imp module is deprecated (apache#4275)
15c8ae5
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Nov 15, 2019
Jian WengXingyu Zhou
imp module is deprecated (apache#4275)
8bf20c4
@yzhliuyzhliu mentioned this pull request Nov 22, 2019
Closed
kevinthesun pushed a commit to neo-ai/tvm that referenced this pull request Nov 25, 2019
Xingyu Zhou@kevinthesun
merge from apach/tvm to neo ai tvm (#59)
bece737
* [TOPI][OP] Support Faster-RCNN Proposal OP on CPU (apache#4297)
* Support Proposal operator on CPU.
* PyLint space issue
* PyLint space issue
* Pylint singleton-comparison issue
* [QNN][Legalize] Specialize for Platforms without any fast Int8 arithmetic units. (apache#4307)
* fix error when memory_id is VTA_MEM_ID_OUT (apache#4330)
* [CI][DOCKER] Add ONNX runtime dep (apache#4314)
* [DOCKER] Add ONNX runtime dep
* Improve ci script
* [QNN] Quantize - Fixing the sequence of lowering. (apache#4316)
* [QNN] Use Int16 upcast in Fallback Conv2D. Fix test names. (apache#4329)
* [doc][fix] fix sphinx parsing for pass infra tutorial (apache#4337)
* change ci image version (apache#4313)
* [Codegen] remove fp16 function override for cuda (apache#4331)
* add volatile override back
* [codegen] remove fp16 function override for cuda
* [CI] Set workspace to be per executor (apache#4336)
* [Build][Windows] Fix Windows build by including cctype (apache#4319)
* Fix build
* dummy change to retrigger CI
* dummy change to retrigger ci
* dummy change to retrigger ci
* Enable hipModuleGetGlobal() (apache#4321)
* [Relay][Pass] Add pass to remove unused functions in relay module (apache#4334)
* [Relay][Pass] Add pass to remove unused functions in relay module
* Add tests
* Fix lint
* Fix visit order
* Add pass argument
* Fix
* Add support for quant. mul operator in tflite frontend (apache#4283)
A test for qnn_mul has to be added when the qnn elemwise tests (apache#4282) get merged.
* Add topi.nn.fifo_buffer to TVM doc (apache#4343)
* Solve custom model of prelu (apache#4326)
* Deprecate NNVM warning msg (apache#4333)
* [Contrib] Add MKL DNN option (apache#4323)
* [Contrib] Add MKL DNN
* update
* update
* [Relay][Frontend][TF] Fix transpose when axes is not a param (apache#4327)
* [Relay][Frontend][TF] Use _infer_value_simulated when axes is not a const to Transpose
* uncomment tests
* dummy change to retrigger ci
* [RUNTIME] Add device query for AMD GcnArch (apache#4341)
* add gcnArch query
* kGcnArch query for cuda is a no-op
* [Test][Relay][Pass] Add test case for lambda lift (apache#4317)
* [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth (apache#4271)
* imp module is deprecated (apache#4275)
* [VTA] Bug fix for padded load with large inputs (apache#4293)
* bug fix for padded load with large inputs
* Update TensorLoad.scala
* Update test_vta_insn.py
* fix inconsistent tag name (apache#4134)
* [CodeGen] Add build config option disable_assert to control whether to generate assert (apache#4340)
* Bump up CUDA log version in tophub.py (apache#4347)
* Add check to ensure input file was successfully opened in NNVM deploy code demo (apache#4315)
* [COMMUNITY] Add DISCLAIMER, KEYS for ASF release (apache#4345)
* [COMMUNITY] Add DISCLAIMER, KEYS for ASF release
* Add file name spec
* [Relay][VM][Interpreter] Enable first-class constructors in VM and interpreter via eta expansion (apache#4218)
* Fix constructor pretty printing
* Make Module::HasDef name consistent with API
* Add VM constructor compilation via eta expansion
* Lint
* Fix CI
* Fix failing test
* Address comment
* Retrigger CI
* Retrigger CI
* Update dmlc_tvm_commit_id.txt
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tqchentqchentqchen approved these changes
@junrushaojunrushaojunrushao approved these changes
@HuyuweiHuyuweiAwaiting requested review from Huyuwei
@LaurawlyLaurawlyAwaiting requested review from Laurawly

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@were@junrushao@tqchen@yzhliu