Skip to content

[Relay][Pass] Add pass to remove unused functions in relay module - #4334

Merged
zhiics merged 6 commits into
apache:masterfrom
wweic:dce-relay
Nov 15, 2019
Merged

[Relay][Pass] Add pass to remove unused functions in relay module#4334
zhiics merged 6 commits into
apache:masterfrom
wweic:dce-relay

Conversation

@wweic

@wweicwweic commented Nov 14, 2019

Copy link
Copy Markdown

@MarisaKirisame

MarisaKirisame commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

can you make the function accept a set of root function? they will not get removed under any circumstance.
by default it is the main function.

@weberlo

weberlo commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

@MarisaKirisame is dead code elimination still broken? If not, we should try to merge these two passes, and add a few configuration knobs (e.g., interprocedural, intraprocedural).

@wweic

wweic commented Nov 14, 2019

Copy link
Copy Markdown
Author

@MarisaKirisame Changed as you suggested. Thank you!

@zhiics

zhiics commented Nov 14, 2019

Copy link
Copy Markdown
Member

Yes, we do need have a more powerful DCE pass. I think we may need to have some liveness analysis late on since @jroesch will probably need them for memory planning.

zhiics
zhiics approved these changes Nov 14, 2019
View reviewed changes

@zhiicszhiics left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarisaKirisame

MarisaKirisame commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

Dead Code Elimination is still broken until higher order pointer analysis is there. I will get back to it after the pldi dead line.

icemelon
icemelon reviewed Nov 14, 2019
View reviewed changes
Comment threadsrc/relay/backend/vm/compiler.cc
@zhiics
zhiics merged commit 7dca655 into apache:masterNov 15, 2019
@zhiics

zhiics commented Nov 15, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Thanks @wweic @icemelon9 @MarisaKirisame

@wweic
wweic deleted the dce-relay branch November 15, 2019 01:59
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Nov 15, 2019
Wei ChenXingyu Zhou
[Relay][Pass] Add pass to remove unused functions in relay module (ap…
38b45df
…ache#4334)
* [Relay][Pass] Add pass to remove unused functions in relay module
* Add tests
* Fix lint
* Fix visit order
* Add pass argument
* Fix
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Nov 15, 2019
Wei ChenXingyu Zhou
[Relay][Pass] Add pass to remove unused functions in relay module (ap…
32266bb
…ache#4334)
* [Relay][Pass] Add pass to remove unused functions in relay module
* Add tests
* Fix lint
* Fix visit order
* Add pass argument
* Fix
@tqchentqchen mentioned this pull request Nov 16, 2019
Closed
zhiics pushed a commit to zhiics/tvm that referenced this pull request Nov 22, 2019
Wei Chen@zhiics
[Relay][Pass] Add pass to remove unused functions in relay module (ap…
39a6e7e
…ache#4334)
* [Relay][Pass] Add pass to remove unused functions in relay module
* Add tests
* Fix lint
* Fix visit order
* Add pass argument
* Fix
kevinthesun pushed a commit to neo-ai/tvm that referenced this pull request Nov 25, 2019
Xingyu Zhou@kevinthesun
merge from apach/tvm to neo ai tvm (#59)
bece737
* [TOPI][OP] Support Faster-RCNN Proposal OP on CPU (apache#4297)
* Support Proposal operator on CPU.
* PyLint space issue
* PyLint space issue
* Pylint singleton-comparison issue
* [QNN][Legalize] Specialize for Platforms without any fast Int8 arithmetic units. (apache#4307)
* fix error when memory_id is VTA_MEM_ID_OUT (apache#4330)
* [CI][DOCKER] Add ONNX runtime dep (apache#4314)
* [DOCKER] Add ONNX runtime dep
* Improve ci script
* [QNN] Quantize - Fixing the sequence of lowering. (apache#4316)
* [QNN] Use Int16 upcast in Fallback Conv2D. Fix test names. (apache#4329)
* [doc][fix] fix sphinx parsing for pass infra tutorial (apache#4337)
* change ci image version (apache#4313)
* [Codegen] remove fp16 function override for cuda (apache#4331)
* add volatile override back
* [codegen] remove fp16 function override for cuda
* [CI] Set workspace to be per executor (apache#4336)
* [Build][Windows] Fix Windows build by including cctype (apache#4319)
* Fix build
* dummy change to retrigger CI
* dummy change to retrigger ci
* dummy change to retrigger ci
* Enable hipModuleGetGlobal() (apache#4321)
* [Relay][Pass] Add pass to remove unused functions in relay module (apache#4334)
* [Relay][Pass] Add pass to remove unused functions in relay module
* Add tests
* Fix lint
* Fix visit order
* Add pass argument
* Fix
* Add support for quant. mul operator in tflite frontend (apache#4283)
A test for qnn_mul has to be added when the qnn elemwise tests (apache#4282) get merged.
* Add topi.nn.fifo_buffer to TVM doc (apache#4343)
* Solve custom model of prelu (apache#4326)
* Deprecate NNVM warning msg (apache#4333)
* [Contrib] Add MKL DNN option (apache#4323)
* [Contrib] Add MKL DNN
* update
* update
* [Relay][Frontend][TF] Fix transpose when axes is not a param (apache#4327)
* [Relay][Frontend][TF] Use _infer_value_simulated when axes is not a const to Transpose
* uncomment tests
* dummy change to retrigger ci
* [RUNTIME] Add device query for AMD GcnArch (apache#4341)
* add gcnArch query
* kGcnArch query for cuda is a no-op
* [Test][Relay][Pass] Add test case for lambda lift (apache#4317)
* [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth (apache#4271)
* imp module is deprecated (apache#4275)
* [VTA] Bug fix for padded load with large inputs (apache#4293)
* bug fix for padded load with large inputs
* Update TensorLoad.scala
* Update test_vta_insn.py
* fix inconsistent tag name (apache#4134)
* [CodeGen] Add build config option disable_assert to control whether to generate assert (apache#4340)
* Bump up CUDA log version in tophub.py (apache#4347)
* Add check to ensure input file was successfully opened in NNVM deploy code demo (apache#4315)
* [COMMUNITY] Add DISCLAIMER, KEYS for ASF release (apache#4345)
* [COMMUNITY] Add DISCLAIMER, KEYS for ASF release
* Add file name spec
* [Relay][VM][Interpreter] Enable first-class constructors in VM and interpreter via eta expansion (apache#4218)
* Fix constructor pretty printing
* Make Module::HasDef name consistent with API
* Add VM constructor compilation via eta expansion
* Lint
* Fix CI
* Fix failing test
* Address comment
* Retrigger CI
* Retrigger CI
* Update dmlc_tvm_commit_id.txt
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icemelonicemelonicemelon approved these changes
@MarisaKirisameMarisaKirisameMarisaKirisame approved these changes
@zhiicszhiicszhiics approved these changes

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wweic@MarisaKirisame@weberlo@zhiics@icemelon