Skip to content

[Relay] Mutual Recursion Support - #5881

Closed
hypercubestart wants to merge 19 commits into
apache:masterfrom
hypercubestart:mutual-recursion
Closed

[Relay] Mutual Recursion Support#5881
hypercubestart wants to merge 19 commits into
apache:masterfrom
hypercubestart:mutual-recursion

Conversation

@hypercubestart

@hypercubestarthypercubestart commented Jun 21, 2020

Copy link
Copy Markdown
Contributor

Working on adding mutual recursion to as a relay pass.

cc for help and advice: @MarisaKirisame@jroesch

@jroesch

jroesch commented Aug 12, 2020

Copy link
Copy Markdown
Member

Sorry I meant to review this a long time ago and just got sidetracked by lots of things. I'm currently working on refactoring the type inferencer to use the new diagnostics. I should have a branch out by next week, could you potentially rebase on top of that and land these tests?

@hypercubestart

hypercubestart commented Aug 21, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

ready for review cc: @MarisaKirisame@jroesch@slyubomirsky@joshpoll@tqchen@wweic@weberlo

@hypercubestarthypercubestart changed the title [WIP][Relay] Mutual Recursion Support[Relay] Mutual Recursion SupportAug 21, 2020
@wweic

wweic commented Aug 23, 2020

Copy link
Copy Markdown

I'll try to take a pass today

MarisaKirisame
MarisaKirisame reviewed Aug 24, 2020
View reviewed changes
Comment threadsrc/relay/analysis/type_solver.h Outdated
Comment threadsrc/relay/op/type_relations.cc Outdated
Comment threadsrc/relay/transforms/type_infer.cc Outdated
Comment threadsrc/relay/transforms/type_infer.cc Outdated
Comment threadtests/python/relay/test_type_infer.py
@MarisaKirisame

MarisaKirisame commented Aug 24, 2020

Copy link
Copy Markdown
Contributor

Please rebase.

MarisaKirisame
MarisaKirisame requested changes Aug 24, 2020
View reviewed changes

@MarisaKirisameMarisaKirisame left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the change to type relation, and fix/remove the test.

@hypercubestart

hypercubestart commented Aug 25, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@wweic@jroesch could you review please?

@jroesch

jroesch commented Aug 25, 2020

Copy link
Copy Markdown
Member

Can we hold off on merging this until #6274 lands? This heavily changes the way the type inferencer works.

jroesch
jroesch requested changes Aug 25, 2020
View reviewed changes

@jroeschjroesch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this on top of the new type inferencer changes in #6274

@MarisaKirisame

MarisaKirisame commented Aug 25, 2020

Copy link
Copy Markdown
Contributor

@hypercubestart sorry to put this on hold, but IMHO 6274 is an essential PR and we should focus on it with stronger priority. everything is good and we will merge this after 6274.

wweic
wweic reviewed Aug 26, 2020
View reviewed changes
Comment threadpython/tvm/ir/module.py
var = _ty.GlobalTypeVar(var)
_ffi_api.Module_AddDef(self, var, val, update)

def add_unchecked(self, var, val):

@wweicwweicAug 23, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a doc string

Comment threadpython/tvm/relay/transform/transform.py
"""
return _ffi_api.InferType()

def InferTypeAll():

@wweicwweicAug 23, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a doc string

Comment threadsrc/relay/analysis/type_solver.h Outdated
TypeSolver(const GlobalVar& current_func, const IRModule& _mod, ErrorReporter* err_reporter);
~TypeSolver();

void SetCurrentFunc(GlobalVar current_func) { this->current_func = current_func; }

@wweicwweicAug 23, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment

Comment threadsrc/relay/transforms/type_infer.cc
}

void Solve();
Expr ResolveType(Expr expr);

@wweicwweicAug 23, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment.

@tqchentqchen closed this Oct 11, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wweicwweicwweic left review comments
@jroeschjroeschjroesch requested changes
@MarisaKirisameMarisaKirisameMarisaKirisame approved these changes

Assignees

@jroeschjroesch

Labels

status: need review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hypercubestart@jroesch@wweic@MarisaKirisame@tqchen