[Diagnostics][Relay][InferType] Refactor InferType to work on whole module, and use new diagnostics. by jroesch · Pull Request #6274 · apache/tvm

jroesch · 2020-08-13T23:27:43Z

This is now ready for full review. This has become a huge PR where I split the coupling between the type checker and the module enabling more flexible use of the module and type checker. Unfortunately people have heavily relied on implicit type checking occurring each time we add a function. This functionality is not longer supported and examples of fixing it can be found all over the test cases.

junrushao · 2020-08-14T20:31:34Z

May be out of the scope of this PR, but shall we also consider make type inference non-recursive some time?

jroesch · 2020-09-22T23:16:41Z

+ return self._add(var, val, True)

- def _add(self, var, val, update=False):
+ def _add(self, var, val, update=True):


Remove update/add in future PR.

jroesch · 2020-09-22T23:17:18Z

 """
 seq = tvm.transform.Sequential(
 [
+ # tvm.parser.AnnotateSpans(),


Should we provide a flag for spans here?

jroesch · 2020-09-22T23:18:31Z

 tensor_array_ops = TensorArrayOps(self, dtype)
 tensor_array_ops.register()
+
+ # Renamer doesn't properly deal with constructors, etc


I don't think this is true anymore.

tmoreau89 · 2020-10-09T18:44:30Z

Thank you @jroesch @mbrookhart @rkimball the PR has been merged.

…odule, and use new diagnostics. (apache#6274) * Refactor the type checker to use diagnostics Although this patch is very large and seemingly disjoint the fixes are required to get it working for the entire stack. I started with first changing InferType to use the diagnostics, these weren't yet in the pass manager so this required changes to module and module pass. InferType wasn't actually written correctly as a pass requring refactoring there, then in order to add spans to AST it required turning on AnnotateSpans which in term required changes to the parser, and module to make it possible to use the errors. These changes to parse and module required changes to diagnostics and InferType. Althought seemingly disconnected there are hidden cycles between the components which require simultaneous change in order to remove the old error reporting. A huge change due to this patch is that the module no longer implicitly type checks functions which are added. * Apply suggestions from code review Co-authored-by: Robert Kimball <bobkimball@gmail.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> * Apply suggestions from code review Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com> * Clean up parser * CR feedback * Apply Bobs suggestions * Fix up Python interface for diagnostics * Fix test_ir_parser and formatting * Fix cpplint * Fix lint * Fix format * More lint * Fix format * Kill dead doc comment * Fix documentation comment * Rebase fixups * Add docs for type.h * Fix parser.cc * Fix unittests * Fix black * Skip previously typechecked functions * fix ACL * Fix numerous issues * Add repr method * Fix issue with Pytest, I am ready to cry * Fix the rest of tests * Kill dead code * Fix dignostic tests * Fix more tests * fix more tests (neo-ai#11) * Fix diagnostic.py deinit bug * Fix deinit issue * Format * Tweak disabling of override * Format * Fix BYOC * Fix TensorArray stuff * Fix PyTorch * Format * Format Co-authored-by: Robert Kimball <bobkimball@gmail.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Zhi <5145158+zhiics@users.noreply.github.com>

…odule, and use new diagnostics. (apache#6274) * Refactor the type checker to use diagnostics Although this patch is very large and seemingly disjoint the fixes are required to get it working for the entire stack. I started with first changing InferType to use the diagnostics, these weren't yet in the pass manager so this required changes to module and module pass. InferType wasn't actually written correctly as a pass requring refactoring there, then in order to add spans to AST it required turning on AnnotateSpans which in term required changes to the parser, and module to make it possible to use the errors. These changes to parse and module required changes to diagnostics and InferType. Althought seemingly disconnected there are hidden cycles between the components which require simultaneous change in order to remove the old error reporting. A huge change due to this patch is that the module no longer implicitly type checks functions which are added. * Apply suggestions from code review Co-authored-by: Robert Kimball <bobkimball@gmail.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> * Apply suggestions from code review Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com> * Clean up parser * CR feedback * Apply Bobs suggestions * Fix up Python interface for diagnostics * Fix test_ir_parser and formatting * Fix cpplint * Fix lint * Fix format * More lint * Fix format * Kill dead doc comment * Fix documentation comment * Rebase fixups * Add docs for type.h * Fix parser.cc * Fix unittests * Fix black * Skip previously typechecked functions * fix ACL * Fix numerous issues * Add repr method * Fix issue with Pytest, I am ready to cry * Fix the rest of tests * Kill dead code * Fix dignostic tests * Fix more tests * fix more tests (#11) * Fix diagnostic.py deinit bug * Fix deinit issue * Format * Tweak disabling of override * Format * Fix BYOC * Fix TensorArray stuff * Fix PyTorch * Format * Format Co-authored-by: Robert Kimball <bobkimball@gmail.com> Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Zhi <5145158+zhiics@users.noreply.github.com>

junrushao reviewed Aug 14, 2020
View reviewed changes

Comment threadinclude/tvm/ir/diagnostic.h Outdated

junrushao reviewed Aug 14, 2020
View reviewed changes

Comment threadinclude/tvm/ir/diagnostic.h Outdated
Comment threadinclude/tvm/ir/diagnostic.h Outdated
Comment threadinclude/tvm/ir/diagnostic.h Outdated
Comment threadinclude/tvm/ir/diagnostic.h
Comment threadinclude/tvm/ir/diagnostic.h
Comment threadinclude/tvm/ir/diagnostic.h Outdated

zhiics mentioned this pull request Aug 17, 2020
[BYOC][ETHOSN] Introduce the Ethos-N BYOC integration #6222
Merged

jroesch force-pushed the diag_infer_type branch from 72ed73f to d0deb8fCompare August 25, 2020 18:59

jroesch mentioned this pull request Aug 25, 2020
[Relay] Mutual Recursion Support #5881
Closed

MarisaKirisame reviewed Aug 25, 2020
View reviewed changes

Comment threadsrc/ir/module.cc
Comment threadsrc/parser/parser.cc Outdated
Comment threadsrc/relay/transforms/type_infer.cc Outdated
Comment threadtests/python/relay/test_ir_parser.py

jroesch marked this pull request as ready for review September 4, 2020 02:10

jroesch force-pushed the diag_infer_type branch from d9bcbe6 to d3b0c22Compare September 4, 2020 02:18

tkonolige reviewed Sep 4, 2020
View reviewed changes

Comment threadsrc/ir/diagnostic.cc Outdated

tkonolige reviewed Sep 4, 2020
View reviewed changes

Comment threadsrc/ir/diagnostic.cc Outdated

tkonolige reviewed Sep 4, 2020
View reviewed changes

Comment threadsrc/ir/diagnostic.cc Outdated

tkonolige reviewed Sep 4, 2020
View reviewed changes

Comment threadsrc/ir/diagnostic.cc Outdated

jroesch force-pushed the diag_infer_type branch 2 times, most recently from eacb4a7 to da61680Compare September 14, 2020 08:16

This was referenced Sep 14, 2020
[BUG] Parser error with nn.dense #6470
Closed
[TypeChecker][Relay] Issue with return type not being properly inferred. #6489
Closed

jroesch force-pushed the diag_infer_type branch 4 times, most recently from 8cbc61d to 495606dCompare September 22, 2020 02:04

jroesch commented Sep 22, 2020
View reviewed changes

Comment threadinclude/tvm/ir/module.h

jroesch commented Sep 22, 2020
View reviewed changes

Comment threadpython/tvm/parser/__init__.py Outdated

jroesch commented Sep 22, 2020
View reviewed changes

Comment threadpython/tvm/relay/std/prelude.rly

jroesch commented Sep 22, 2020
View reviewed changes

Comment threadsrc/printer/relay_text_printer.cc

jroesch commented Sep 23, 2020
View reviewed changes

Comment threadsrc/parser/parser.cc Outdated

jroesch commented Sep 23, 2020
View reviewed changes

Comment threadsrc/parser/parser.cc Outdated

jroeschand others added 13 commits October 9, 2020 00:09

Fix dignostic tests
2209b08

Fix more tests
222b7c1

fix more tests (#11)
433deeb

Fix diagnostic.py deinit bug
e81eadb

Fix deinit issue
f81e85e

Format
ca065d8

Tweak disabling of override
46f9658

Format
885e404

Fix BYOC
f6c0524

Fix TensorArray stuff
b32cf3a

Fix PyTorch
d8c85b5

Format
9e22dbd

Format
c2f368b

jroesch force-pushed the diag_infer_type branch from c0094fd to c2f368bCompare October 9, 2020 08:19

tmoreau89 approved these changes Oct 9, 2020
View reviewed changes

tmoreau89 merged commit 98c2096 into apache:masterOct 9, 2020

tkonolige mentioned this pull request Nov 6, 2020
[TIR] Add spans to all ExprNodes #6860
Merged

t-vi mentioned this pull request Jan 29, 2021
Refactor Dynamic to Static #7368
Merged

jroesch deleted the diag_infer_type branch February 4, 2021 04:42

chiwwang mentioned this pull request Jun 11, 2021
[DOCS] Add docs for Pass Instrument #8220
Merged

junrushao mentioned this pull request Nov 1, 2021
Apache TVM v0.8 Release Note Candidate #9416
Closed

Uh oh!

Conversation

jroesch commented Aug 13, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

junrushao commented Aug 14, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jroeschSep 22, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jroeschSep 22, 2020

Choose a reason for hiding this comment

Uh oh!

jroeschSep 22, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tmoreau89 commented Oct 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jroesch commented Aug 13, 2020•
edited
Loading