Skip to content

[MetaSchedule][M3b] Builder - #9044

Merged
comaniac merged 3 commits into
apache:mainfrom
junrushao:feature/2021-09-18/builder
Sep 20, 2021
Merged

[MetaSchedule][M3b] Builder#9044
comaniac merged 3 commits into
apache:mainfrom
junrushao:feature/2021-09-18/builder

Conversation

@junrushao

@junrushaojunrushao commented Sep 18, 2021•
edited
Loading

Copy link
Copy Markdown
Member

This PR is part of the stage M3b of the meta schedule project (#8473).

The architecture is re-designed by Junru and Xiyou, and was first drafted by Junru, Wuwei, Ruihang, Bohan, Siyuan, Hongyi.

This Builder API in this PR allows any developers to implement Builder in either pure C++ (by inheriting meta_schedule::Builder) or pure python (by inheriting PyBuilder).

Review request: @jcf94@comaniac@icemelon@zhiics@mbrookhart.

Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>

@junrushao@zxybazh
@spectrometerHBH@MasterJH5574@jinhongyii@vinx13Siyuan Feng
[Meta Schedule][M3b] Builder
17d2d56
This PR is part of the meta schedule project (#8473)
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@junrushaojunrushao mentioned this pull request Sep 18, 2021
Closed
62 tasks
comaniac
comaniac approved these changes Sep 19, 2021
View reviewed changes

@comaniaccomaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some nits.
Will merge on Monday afternoon if no other objections.
Also it would be better to add at least one sentence to the PR description about what this PR does.

Comment threadpython/tvm/meta_schedule/builder/local_builder.py Outdated
Comment threadpython/tvm/meta_schedule/builder/local_builder.py
Comment threadpython/tvm/meta_schedule/builder/local_builder.py Outdated
Comment threadpython/tvm/meta_schedule/builder/local_builder.py Outdated
mbrookhart
mbrookhart approved these changes Sep 20, 2021
View reviewed changes

@mbrookhartmbrookhart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Clean, LGTM! One very minor nit. 😁

Comment threadpython/tvm/relay/transform/transform.py
| |
dq dq
\ /
\\ /

@mbrookhartmbrookhartSep 20, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Why is your code formatter screwing with my ASCII Art? 😁

@junrushaojunrushaoSep 20, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha yeah it is intentional. Otherwise the unhappy pytest reports a warning demanding escape characters

@mbrookhartmbrookhartSep 20, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wonder why I didn't see that in CI when I added this.

@zxybazhzxybazhSep 20, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here when I run the pytest, got a warning for this.

@comaniac
comaniac merged commit 44d3934 into apache:mainSep 20, 2021
@comaniac

comaniac commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Thanks @junrushao1994@mbrookhart

@comaniaccomaniac mentioned this pull request Sep 20, 2021
Merged
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 21, 2021
@AndrewZhaoLuo
Merge branch 'main' into aluo/onnx/unsqueeze-alt
dc17ada
* main:
Add back missing __init__.py to unbreak CI. (apache#9052)
[Meta Schedule][M3b] Builder (apache#9044)
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@junrushao@zxybazh
@spectrometerHBH@MasterJH5574@jinhongyii@vinx13Siyuan Feng@ylc
[Meta Schedule][M3b] Builder (apache#9044)
8f23d16
* [Meta Schedule][M3b] Builder
This PR is part of the meta schedule project (apache#8473)
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
* add typing
* unreachable
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@junrushaojunrushao mentioned this pull request Nov 1, 2021
Closed
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@junrushao@zxybazh
@spectrometerHBH@MasterJH5574@jinhongyii@vinx13Siyuan Feng@ylc
[Meta Schedule][M3b] Builder (apache#9044)
5ff8a9e
* [Meta Schedule][M3b] Builder
This PR is part of the meta schedule project (apache#8473)
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
* add typing
* unreachable
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@junrushaojunrushao changed the title [Meta Schedule][M3b] Builder[MetaSchedule][M3b] BuilderJan 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zxybazhzxybazhzxybazh left review comments
@mbrookhartmbrookhartmbrookhart approved these changes
@comaniaccomaniaccomaniac approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@jroeschjroeschAwaiting requested review from jroesch
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@junrushao@comaniac@zxybazh@mbrookhart