Skip to content

[MetaSchedule][M3a] TuneContext - #9053

Merged
junrushao merged 10 commits into
apache:mainfrom
zxybazh:tensorir-infra/upstream/2021-09-20/tune-context
Sep 22, 2021
Merged

[MetaSchedule][M3a] TuneContext#9053
junrushao merged 10 commits into
apache:mainfrom
zxybazh:tensorir-infra/upstream/2021-09-20/tune-context

Conversation

@zxybazh

@zxybazhzxybazh commented Sep 20, 2021•
edited
Loading

Copy link
Copy Markdown
Member

This PR is part of the stage M3a of the meta schedule project (#8473).

The architecture is re-designed by Junru and Xiyou. TuneContext contains all the resources, i.e., related classes for a single tuning task. The class can be accessed in both python side and c++ side. No function is designated inside.

More classes would be added to TuneContext as we proceed with the upstreaming.

Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>

@zxybazh
zxybazhforce-pushed the tensorir-infra/upstream/2021-09-20/tune-context branch from 6099add to e99bb33CompareSeptember 20, 2021 21:36
@comaniac

comaniac commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Hey you probably need to rebase after #9044 is merged?

@zxybazh

zxybazh commented Sep 20, 2021

Copy link
Copy Markdown
MemberAuthor

Hey you probably need to rebase after #9044 is merged?

Already rebaed : )

comaniac
comaniac approved these changes Sep 20, 2021
View reviewed changes

@comaniaccomaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

Comment threadCMakeLists.txt Outdated
junrushao
junrushao reviewed Sep 20, 2021
View reviewed changes
Comment threadpython/tvm/meta_schedule/__init__.py Outdated
junrushao
junrushao reviewed Sep 20, 2021
View reviewed changes
Comment threadpython/tvm/meta_schedule/tune_context.py Outdated
junrushao
junrushao reviewed Sep 20, 2021
View reviewed changes
Comment threadpython/tvm/meta_schedule/tune_context.py Outdated
junrushao
junrushao reviewed Sep 20, 2021
View reviewed changes
Comment threadpython/tvm/meta_schedule/tune_context.py Outdated
@junrushao

junrushao commented Sep 20, 2021

Copy link
Copy Markdown
Member

Otherwise looks good to me! Thanks @zxybazh

zxybazhand others added 8 commits September 20, 2021 16:23
@zxybazh@junrushao
@spectrometerHBH@MasterJH5574@jinhongyii@vinx13Siyuan Feng
Add TuneContext class.
fcb9cd4
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@zxybazh
Add tune context test.
72738ab
@zxybazh
Add meta_schedule to cmake.
ae58a95
@zxybazh
Add type.
c261133
@zxybazh
Rebase.
66eb668
@zxybazh
Disable MyPy for ethosu.
caa7b87
@zxybazh
Add new line.
7754e05
@zxybazh
Remove duplicate line.
9bc31d3
@zxybazh
zxybazhforce-pushed the tensorir-infra/upstream/2021-09-20/tune-context branch from cef26b3 to 9bc31d3CompareSeptember 20, 2021 23:24
@junrushaojunrushao mentioned this pull request Sep 21, 2021
Closed
62 tasks
Hzfengsy
Hzfengsy reviewed Sep 21, 2021
View reviewed changes
Comment threadpython/tvm/meta_schedule/tune_context.py
@zxybazhzxybazh mentioned this pull request Sep 21, 2021
Closed
@zxybazh

zxybazh commented Sep 22, 2021

Copy link
Copy Markdown
MemberAuthor

Please merge the PR if no further issues, thanks!

@junrushao
junrushao merged commit cd15b79 into apache:mainSep 22, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@zxybazh@junrushao
@spectrometerHBH@MasterJH5574@jinhongyii@vinx13Siyuan Feng@ylc
[Meta Schedule][M3a] TuneContext (apache#9053)
af2c67e
* Add TuneContext class.
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
* Add tune context test.
* Add meta_schedule to cmake.
* Add type.
* Rebase.
* Disable MyPy for ethosu.
* Add new line.
* Remove duplicate line.
* Minor fix.
* Add comments.
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@junrushaojunrushao mentioned this pull request Nov 1, 2021
Closed
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@zxybazh@junrushao
@spectrometerHBH@MasterJH5574@jinhongyii@vinx13Siyuan Feng@ylc
[Meta Schedule][M3a] TuneContext (apache#9053)
61ce6ed
* Add TuneContext class.
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
* Add tune context test.
* Add meta_schedule to cmake.
* Add type.
* Rebase.
* Disable MyPy for ethosu.
* Add new line.
* Remove duplicate line.
* Minor fix.
* Add comments.
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@junrushaojunrushao changed the title [Meta Schedule][M3a] TuneContext[MetaSchedule][M3a] TuneContextJan 26, 2022
manupak
manupak reviewed Jan 26, 2022
View reviewed changes
Comment threadtests/scripts/task_mypy.sh

echo "Checking MyPy Type defs in the tvm.relay.backend.contrib.ethosu package."
mypy --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/
#TODO(@mikepapadim): This is failing atm

@manupakmanupakJan 26, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue if things like this happens and possibly ping codeowners please, we were not aware that any of the checked in code was not tested until recently.

cc : @mikepapadim@junrushao1994

@junrushaojunrushaoJan 26, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I thought we did, but it turned out haven't...Please make sure to report in time :-)

@junrushaojunrushaoJan 26, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh actually we reported in this thread: #9050. definitely should submit it as a separate PR though

@manupakmanupakJan 27, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea but that PR was closed saying not needed. Thus, I was under the impression that was never merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junrushaojunrushaojunrushao approved these changes
@HzfengsyHzfengsyHzfengsy left review comments
@manupakmanupakmanupak left review comments
@comaniaccomaniaccomaniac approved these changes
@areuschareuschAwaiting requested review from areusch
@jroeschjroeschAwaiting requested review from jroesch
@merrymercymerrymercyAwaiting requested review from merrymercy
@tqchentqchenAwaiting requested review from tqchen
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zxybazh@comaniac@junrushao@Hzfengsy@manupak