Skip to content

[ONNX] [Relay] Dynamic squeeze - #9095

Merged
mbrookhart merged 11 commits into
apache:mainfrom
CircleSpin:dynamic_squeeze
Sep 28, 2021
Merged

[ONNX] [Relay] Dynamic squeeze#9095
mbrookhart merged 11 commits into
apache:mainfrom
CircleSpin:dynamic_squeeze

Conversation

@CircleSpin

@CircleSpinCircleSpin commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

mbrookhart
mbrookhart reviewed Sep 23, 2021
View reviewed changes

@mbrookhartmbrookhart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a couple of formatting/lint issues, and there's one print still in here, but otherwise LGTM

Comment threadpython/tvm/relay/frontend/onnx.py Outdated
AndrewZhaoLuo
AndrewZhaoLuo reviewed Sep 23, 2021
View reviewed changes

@AndrewZhaoLuoAndrewZhaoLuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly. A few comments

Comment threadpython/tvm/relay/frontend/onnx.py Outdated
Comment threadpython/tvm/relay/op/dyn/_transform.py Outdated
Comment threadsrc/relay/op/dyn/tensor/transform.cc
Comment threadsrc/relay/op/dyn/tensor/transform.cc Outdated
Comment threadsrc/relay/op/dyn/tensor/transform.cc Outdated
Comment threadsrc/relay/op/dyn/tensor/transform.cc Outdated
Comment threadsrc/relay/op/dyn/tensor/transform.cc Outdated
Comment threadtests/python/relay/dyn/test_dynamic_op_level3.py Outdated
@AndrewZhaoLuo

AndrewZhaoLuo commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

Please also change the title of this PR to something like "[ONNX] [Relay] Dynamic Squeeze"

@CircleSpinCircleSpin changed the title Dynamic squeeze[ONNX] [Relay] Dynamic squeezeSep 23, 2021
@AndrewZhaoLuoAndrewZhaoLuo mentioned this pull request Sep 24, 2021
Merged
AndrewZhaoLuo
AndrewZhaoLuo reviewed Sep 27, 2021
View reviewed changes

@AndrewZhaoLuoAndrewZhaoLuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM

@mbrookhart
mbrookhart merged commit 5e46e75 into apache:mainSep 28, 2021
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 28, 2021
@AndrewZhaoLuo
Merge branch 'main' into aluo/onnx/support-nllloss-tests
ec71db0
* main: (37 commits)
[ONNX] [Relay] Dynamic squeeze (apache#9095)
[Meta Schedule][M3b] Database (apache#9061)
[Bugfix] Add nullptr checking for `AttrStmt` with `coproc_uop_scope` attr key (apache#9123)
[Codegen] Swap out analyzer when outlining (apache#9117)
[CI] bash.sh, build.sh: add option to set the container name and hostname (apache#9110)
Ensure google-mock is installed and setup (apache#9107)
Arm(R) Ethos(TM)-U NPU TIR to CS for Conv2D (apache#8811)
Frontend: add onnx GlobalLpPool op (apache#8845)
[LLVM] Refactor MakeCallPacked, NFC (apache#9118)
prevent casting handle to other types (apache#9114)
fix annotation of tir generic (apache#9119)
[Relay] Register layout conversion function to more reduce ops (apache#9048)
Fix the missing `dtype` attribute of `tir.Shuffle` in Python level (apache#9131)
add `multiply` and remove `subtract` for dnnl json runtime (apache#9120)
relu of dnnl json runtime only support 4-dims input (apache#9122)
[Meta Schedule][M3a] SpaceGenerator (apache#9079)
[TensorIR][Bugfix] Disallow fusing loops with dependency (apache#9112)
adding Jorn to reviewers list (apache#9105)
[BYOC] Fix incorrect conv2d padding handling of `dnnl with c source runtime` (apache#9097)
[Frontend][TFLite] fixapache#9078 (apache#9099)
...
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@CircleSpinCircleSpin@ylc
[ONNX] [Relay] Dynamic squeeze (apache#9095)
45297c2
* adding dynamic squeeze first steps
* Matt B. implementing shape
* squeeze implemented, dynamic_to_static and onnx importer next
* add Squeeze op convert to onnx.py
* dynamic to static
* removed comments
* removed comments
* added comment
* adjusted comment
* black and lint
* ran make format in root directory
Co-authored-by: CircleSpin <jocelyn@pop-os.localdomain>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@CircleSpinCircleSpin@ylc
[ONNX] [Relay] Dynamic squeeze (apache#9095)
05ccb39
* adding dynamic squeeze first steps
* Matt B. implementing shape
* squeeze implemented, dynamic_to_static and onnx importer next
* add Squeeze op convert to onnx.py
* dynamic to static
* removed comments
* removed comments
* added comment
* adjusted comment
* black and lint
* ran make format in root directory
Co-authored-by: CircleSpin <jocelyn@pop-os.localdomain>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewZhaoLuoAndrewZhaoLuoAndrewZhaoLuo left review comments
@mbrookhartmbrookhartmbrookhart approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@HuyuweiHuyuweiAwaiting requested review from Huyuwei
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@kazumkazumAwaiting requested review from kazum
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@merrymercymerrymercyAwaiting requested review from merrymercy
@siju-samuelsiju-samuelAwaiting requested review from siju-samuel
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@srkreddy1238srkreddy1238Awaiting requested review from srkreddy1238
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CircleSpin@AndrewZhaoLuo@mbrookhart