Uh oh!
There was an error while loading. Please reload this page.
[4/6] Arm(R) Ethos(TM)-U NPU TIR to CS for Conv2D - #8811
Merged
Conversation
manupak
requested review from
a team, MarisaKirisame, ZihengJiang, anijain2305, areusch, comaniac, jroesch, junrushao, jwfromm, mbaret, mbrookhart, merrymercy, slyubomirsky, tqchen, trevor-m, vinx13, wweic, yzhliu and zhiics
as code ownersAugust 23, 2021 12:44
manupak
marked this pull request as draft
August 23, 2021 12:45
8 tasks
manupakforce-pushed
the
ethosu_upstreaming_p4
branch
from
August 25, 2021 12:52
1aab700 to
f784a74Comparemanupakforce-pushed
the
ethosu_upstreaming_p4
branch
2 times, most recently
from
August 26, 2021 16:36
449f8ed to
9f4cf68Comparemanupakforce-pushed
the
ethosu_upstreaming_p4
branch
2 times, most recently
from
September 13, 2021 18:15
5349732 to
d5fdaf6Comparemanupak
marked this pull request as ready for review
September 15, 2021 11:19
areusch
reviewed
Sep 21, 2021
areusch
left a comment
Contributor
There was a problem hiding this comment.
@manupa-arm did a pass through this one, can address comments in a follow on to whichever of the following ones we merge
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
manupakforce-pushed
the
ethosu_upstreaming_p4
branch
2 times, most recently
from
September 22, 2021 16:19
de13b68 to
5837179Comparemanupak
commented
Sep 23, 2021
ContributorAuthor
This is failing CI on an unrelated error (I think due to : #9013). I think #9076 should fix it (Thanks @mbs-octoml ). Looking for reviews/approval. |
This commit introduces the TIR to Command Stream(CS) translation using Vela API calls for conv2D and copy operations. It will create Vela npu_op objects for each command. Change-Id: I906d2cb333652813142cc70fb39b8372ec498bd0
manupakforce-pushed
the
ethosu_upstreaming_p4
branch
from
September 24, 2021 13:00
5837179 to
c4aaec7Compareareusch
approved these changes
Sep 27, 2021
areusch
left a comment
Contributor
There was a problem hiding this comment.
thanks @manupa-arm just a few things for follow-up PR
| output = auto() | ||
| _REGION_MAP = { |
Contributor
There was a problem hiding this comment.
for a follow-on: should this become enum.IntEnum?
| if __name__ == "__main__": | ||
| test_buffer_info_extraction() |
Contributor
There was a problem hiding this comment.
for a follow-on: sys.exit(pytest.main([__file__] + sys.argv[1:]))
jroesch
approved these changes
Sep 27, 2021
AndrewZhaoLuo added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Sep 28, 2021
* main: (37 commits) [ONNX] [Relay] Dynamic squeeze (apache#9095) [Meta Schedule][M3b] Database (apache#9061) [Bugfix] Add nullptr checking for `AttrStmt` with `coproc_uop_scope` attr key (apache#9123) [Codegen] Swap out analyzer when outlining (apache#9117) [CI] bash.sh, build.sh: add option to set the container name and hostname (apache#9110) Ensure google-mock is installed and setup (apache#9107) Arm(R) Ethos(TM)-U NPU TIR to CS for Conv2D (apache#8811) Frontend: add onnx GlobalLpPool op (apache#8845) [LLVM] Refactor MakeCallPacked, NFC (apache#9118) prevent casting handle to other types (apache#9114) fix annotation of tir generic (apache#9119) [Relay] Register layout conversion function to more reduce ops (apache#9048) Fix the missing `dtype` attribute of `tir.Shuffle` in Python level (apache#9131) add `multiply` and remove `subtract` for dnnl json runtime (apache#9120) relu of dnnl json runtime only support 4-dims input (apache#9122) [Meta Schedule][M3a] SpaceGenerator (apache#9079) [TensorIR][Bugfix] Disallow fusing loops with dependency (apache#9112) adding Jorn to reviewers list (apache#9105) [BYOC] Fix incorrect conv2d padding handling of `dnnl with c source runtime` (apache#9097) [Frontend][TFLite] fixapache#9078 (apache#9099) ...
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
This commit introduces the TIR to Command Stream(CS) translation using Vela API calls for conv2D and copy operations. It will create Vela npu_op objects for each command. Change-Id: I906d2cb333652813142cc70fb39b8372ec498bd0
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This commit introduces the TIR to Command Stream(CS) translation using Vela API calls for conv2D and copy operations. It will create Vela npu_op objects for each command. Change-Id: I906d2cb333652813142cc70fb39b8372ec498bd0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the TIR to Command Stream(CS) translation using Vela API calls for conv2D and copy operations. It will create Vela npu_op objects for each command.
This is blocked on merging #8795 and #8806 . Therefore this PR shows the accumulation of the content of all three PRs (including this one).