Skip to content

[2/3][AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close - #9500

Merged
manupak merged 2 commits into
apache:mainfrom
Mousius:device-api-activate
Nov 16, 2021
Merged

[2/3][AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close#9500
manupak merged 2 commits into
apache:mainfrom
Mousius:device-api-activate

Conversation

@Mousius

@MousiusMousius commented Nov 12, 2021•
edited
Loading

Copy link
Copy Markdown
Member

This adds the relevant hooks into their starting places in the code generation. As per the C Device API RFC

This stacks on top of #9395

@MousiusMousius mentioned this pull request Nov 12, 2021
Merged
@MousiusMousius changed the title [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close[2/3][AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/CloseNov 12, 2021
@Mousius
[AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close
4dbe678
This adds the relevant hooks into their starting places in the code
generation. As per the [C Device API
RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md)
manupak
manupak requested changes Nov 15, 2021
View reviewed changes

@manupakmanupak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mousius .

Few concerns around executor_factory APIs and others are basically nits.

Comment threadpython/tvm/relay/backend/executor_factory.py Outdated
Comment threadpython/tvm/relay/build_module.py
Comment threadpython/tvm/relay/build_module.py Outdated
Comment threadpython/tvm/relay/build_module.py Outdated
Comment threadsrc/relay/backend/aot_executor_codegen.cc
Comment threadsrc/relay/backend/aot_executor_codegen.cc
Mousius
Mousius commented Nov 15, 2021
View reviewed changes
Comment threadsrc/relay/backend/aot_executor_codegen.cc Outdated
gromero
gromero reviewed Nov 16, 2021
View reviewed changes
Comment threadtests/python/relay/aot/test_crt_aot.py

def representative_dataset():
for _ in range(100):
data = np.random.rand(*tuple([1, 3, 4, 3]))

@gromerogromeroNov 16, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mousius Could the unpack here be directly from the list? Like: ...rand(*[1, 3, 4, 3])?

@MousiusMousiusNov 16, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice spot @gromero, by the same token I don't think we even need to unpack the list? This is the same as rand(1, 3, 4,3), I'll clear this up 😸

@gromerogromeroNov 22, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mousius Hi! Yeah, I thought of that too (avoiding the unpack too), however I assumed you would like to keep it as [1, 3, 4, 3] just to be "more explicit" by keeping the dimensions written in a form as you pass later for example to tf.TensorSpec. Either way looks fine to me, just the form with "tuple" seems superfluous :)

areusch
areusch approved these changes Nov 16, 2021
View reviewed changes

@areuschareusch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbs-octoml can you take a look too?

@areusch

areusch commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

@manupa-arm can you take another look?

manupak
manupak approved these changes Nov 16, 2021
View reviewed changes

@manupakmanupak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manupak

manupak commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

Thanks @Mousius@areusch .

Lets follow up with any outstanding comments in 3/3. @gromero@mbs-octoml

@manupak
manupak merged commit 948641c into apache:mainNov 16, 2021
@Mousius
Mousius deleted the device-api-activate branch November 16, 2021 09:38
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
@Mousius@mehrdadh
[2/3][AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close (a…
4d5c56a
…pache#9500)
* [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close
This adds the relevant hooks into their starting places in the code
generation. As per the [C Device API
RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md)
* Standardise on `lowered_ir_mods` and correct device_hook variable name
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
@Mousius@mehrdadh
[2/3][AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close (a…
c64057f
…pache#9500)
* [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close
This adds the relevant hooks into their starting places in the code
generation. As per the [C Device API
RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md)
* Standardise on `lowered_ir_mods` and correct device_hook variable name
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@Mousius@ylc
[2/3][AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close (a…
3dbf6b5
…pache#9500)
* [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close
This adds the relevant hooks into their starting places in the code
generation. As per the [C Device API
RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md)
* Standardise on `lowered_ir_mods` and correct device_hook variable name
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
@Mousius@yangulei
[2/3][AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close (a…
523b28d
…pache#9500)
* [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close
This adds the relevant hooks into their starting places in the code
generation. As per the [C Device API
RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md)
* Standardise on `lowered_ir_mods` and correct device_hook variable name
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@Mousius@ylc
[2/3][AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close (a…
d1be382
…pache#9500)
* [AOT][DeviceAPI] Add Hooks for Activate/Deactivate/Open/Close
This adds the relevant hooks into their starting places in the code
generation. As per the [C Device API
RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0031-devices-api.md)
* Standardise on `lowered_ir_mods` and correct device_hook variable name
@driazatidriazati mentioned this pull request Jul 14, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gromerogromerogromero left review comments
@areuschareuschareusch approved these changes
@manupakmanupakmanupak approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@comaniaccomaniacAwaiting requested review from comaniac
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@kazumkazumAwaiting requested review from kazum
@kparzysz-quickparzysz-quicAwaiting requested review from kparzysz-quic
@leandronleandronAwaiting requested review from leandron
@liangfuliangfuAwaiting requested review from liangfu
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@masahimasahiAwaiting requested review from masahi
@mbaretmbaretAwaiting requested review from mbaret
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tmoreau89tmoreau89Awaiting requested review from tmoreau89
@tqchentqchenAwaiting requested review from tqchen
@trevor-mtrevor-mAwaiting requested review from trevor-m
@vinx13vinx13Awaiting requested review from vinx13
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mousius@areusch@manupak@gromero