Uh oh!
There was an error while loading. Please reload this page.
[3/3][AOT][DeviceAPI] Wire up cpacked Device API context - #9501
Merged
Conversation
Mousius
requested review from
Hzfengsy, MarisaKirisame, ZihengJiang, anijain2305, areusch, comaniac, icemelon, jroesch, junrushao, jwfromm, kazum, kparzysz-quic, leandron, liangfu, manupak, masahi, mbaret, mbrookhart, merrymercy, slyubomirsky, tmoreau89, tqchen, trevor-m, vinx13, wweic, yzhliu and zhiics
as code ownersNovember 12, 2021 11:17
Mousiusforce-pushed
the
device-api-cpacked
branch
3 times, most recently
from
November 12, 2021 13:38
b08b6f3 to
e685a20CompareMousiusforce-pushed
the
device-api-cpacked
branch
2 times, most recently
from
November 16, 2021 09:41
f443604 to
aff40bbComparembs-octoml
approved these changes
Nov 16, 2021
Uh oh!
There was an error while loading. Please reload this page.
Mousiusforce-pushed
the
device-api-cpacked
branch
3 times, most recently
from
November 18, 2021 09:46
263e030 to
9bcbf27Comparemanupak
reviewed
Nov 22, 2021
manupak
left a comment
Contributor
There was a problem hiding this comment.
Broadly looks good!. Just one question but could do in a follow up since this is green.
Uh oh!
There was an error while loading. Please reload this page.
Adding the same functionality for the Device API to the cpacked calling convention. The MakePackedAPI pass now implicitly uses any variable named `kDeviceContextVar` as the `resource_handle` and this is then used in the `cpacked` calling convention which always expects some form of resource_handle to be passed.
Mousiusforce-pushed
the
device-api-cpacked
branch
from
November 22, 2021 10:59
9bcbf27 to
1839fb1Comparemanupak
approved these changes
Nov 23, 2021
manupak
commented
Nov 23, 2021
Contributor
Thanks @mbs-octoml@Mousius . This is merged now! |
mehrdadh pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* [AOT][DeviceAPI] Wire up cpacked Device API context Adding the same functionality for the Device API to the cpacked calling convention. The MakePackedAPI pass now implicitly uses any variable named `kDeviceContextVar` as the `resource_handle` and this is then used in the `cpacked` calling convention which always expects some form of resource_handle to be passed. * Document calling conventions * Remove superfluous variable
mehrdadh pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* [AOT][DeviceAPI] Wire up cpacked Device API context Adding the same functionality for the Device API to the cpacked calling convention. The MakePackedAPI pass now implicitly uses any variable named `kDeviceContextVar` as the `resource_handle` and this is then used in the `cpacked` calling convention which always expects some form of resource_handle to be passed. * Document calling conventions * Remove superfluous variable
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* [AOT][DeviceAPI] Wire up cpacked Device API context Adding the same functionality for the Device API to the cpacked calling convention. The MakePackedAPI pass now implicitly uses any variable named `kDeviceContextVar` as the `resource_handle` and this is then used in the `cpacked` calling convention which always expects some form of resource_handle to be passed. * Document calling conventions * Remove superfluous variable
yangulei pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
* [AOT][DeviceAPI] Wire up cpacked Device API context Adding the same functionality for the Device API to the cpacked calling convention. The MakePackedAPI pass now implicitly uses any variable named `kDeviceContextVar` as the `resource_handle` and this is then used in the `cpacked` calling convention which always expects some form of resource_handle to be passed. * Document calling conventions * Remove superfluous variable
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [AOT][DeviceAPI] Wire up cpacked Device API context Adding the same functionality for the Device API to the cpacked calling convention. The MakePackedAPI pass now implicitly uses any variable named `kDeviceContextVar` as the `resource_handle` and this is then used in the `cpacked` calling convention which always expects some form of resource_handle to be passed. * Document calling conventions * Remove superfluous variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the same functionality for the Device API to the cpacked calling convention. The MakePackedAPI pass now implicitly uses any variable named
kDeviceContextVaras theresource_handleand this is then used in thecpackedcalling convention which always expects some form of resource_handle to be passed.This is stacked on top of #9500 and #9395