Skip to content

[HOTFIX] Fix flaky AuthenticationIT - #1084

Closed
prabhjyotsingh wants to merge 1 commit into
apache:masterfrom
prabhjyotsingh:hotfix/testGroupPermission
Closed

[HOTFIX] Fix flaky AuthenticationIT#1084
prabhjyotsingh wants to merge 1 commit into
apache:masterfrom
prabhjyotsingh:hotfix/testGroupPermission

Conversation

@prabhjyotsingh

@prabhjyotsinghprabhjyotsingh commented Jun 24, 2016

Copy link
Copy Markdown
Contributor

What is this PR for?

This is hotfix for CI failing for

Tests in error:
AuthenticationIT.testGroupPermission:177->authenticationUser:109->AbstractZeppelinIT.pollingWait:114 » Timeout

What type of PR is it?

[Hot Fix]

Todos

  • - Add check for request.status === 500, while logout

What is the Jira issue?

How should this be tested?

Check for CI green

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? n/a
  • Is there breaking changes for older versions? n/a
  • Does this needs documentation? n/a

@prabhjyotsinghprabhjyotsingh changed the title [WIF] Fix flaky AuthenticationIT[WIP] Fix flaky AuthenticationITJun 24, 2016
@prabhjyotsingh
prabhjyotsinghforce-pushed the hotfix/testGroupPermission branch from d387163 to 47cf1aaCompareJune 24, 2016 19:12
@prabhjyotsingh
prabhjyotsinghforce-pushed the hotfix/testGroupPermission branch from 5dcbabe to 50b479bCompareJune 25, 2016 03:02
@prabhjyotsinghprabhjyotsingh changed the title [WIP] Fix flaky AuthenticationIT[HOTFIX] Fix flaky AuthenticationITJun 25, 2016
@prabhjyotsingh

Copy link
Copy Markdown
ContributorAuthor

CI green ready for review!

@minahlee

Copy link
Copy Markdown
Member

Awesome!!! let's merge it

@prabhjyotsingh

Copy link
Copy Markdown
ContributorAuthor

Thanks a lot, I'll merge this as a hot fix.

asfgit pushed a commit that referenced this pull request Jun 25, 2016
### What is this PR for?
This is hotfix for CI failing for
Tests in error:
AuthenticationIT.testGroupPermission:177->authenticationUser:109->AbstractZeppelinIT.pollingWait:114 » Timeout
### What type of PR is it?
[Hot Fix]
### Todos
* [x] - Add check for request.status === 500, while logout
### What is the Jira issue?
- [ZEPPELIN-1009](https://issues.apache.org/jira/browse/ZEPPELIN-1009)
### How should this be tested?
Check for CI green
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Closes#1084 from prabhjyotsingh/hotfix/testGroupPermission and squashes the following commits:
50b479b [Prabhjyot Singh] check for request.status === 500
(cherry picked from commit 510cecd)
Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
@prabhjyotsingh

Copy link
Copy Markdown
ContributorAuthor

@minahlee@bzz@Leemoonsoo After merging this CI is now failing (Build #5323.1) with

-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.zeppelin.python.PythonInterpreterTest
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/zeppelin-interpreter-0.6.0-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
log4j:WARN No appenders could be found for logger (org.apache.zeppelin.interpreter.Interpreter).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.365 sec <<< FAILURE! - in org.apache.zeppelin.python.PythonInterpreterTest
testClose(org.apache.zeppelin.python.PythonInterpreterTest) Time elapsed: 0.262 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at org.apache.zeppelin.python.PythonInterpreterTest.testClose(PythonInterpreterTest.java:168)
Results :
Failed tests: PythonInterpreterTest.testClose:168 null

https://s3.amazonaws.com/archive.travis-ci.org/jobs/140172363/log.txt

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prabhjyotsingh@minahlee