Uh oh!
There was an error while loading. Please reload this page.
[Bugfix] init RepoSetting values - #1097
Closed
astroshim wants to merge 1 commit into
Closed
Conversation
ContributorAuthor
It seems that the CI error is not related this PR. I updated CI issue on https://issues.apache.org/jira/browse/ZEPPELIN-878 |
jongyoul
commented
Jun 28, 2016
Member
Could you please re-trigger it? |
ContributorAuthor
I re-triggered but other error occurred. |
jongyoul
commented
Jun 29, 2016
Member
It's flaky test but we need to ensure all the test passed. Could you please do it once again? |
astroshim
commented
Jun 29, 2016
ContributorAuthor
CI has passed. Thanks. |
jongyoul
commented
Jun 29, 2016
Member
I'll merge it |
asfgit pushed a commit
that referenced
this pull request
Jul 18, 2016
### What is this PR for? This PR fixes initialize value bug of ```Add New Repository```. ### What type of PR is it? Bug Fix ### How should this be tested? 1. launch the ```Add New Repository``` modal window. 2. put URL value 3. hit Cancel button 4. launch the ```Add New Repository``` modal window again. ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <hsshim@nflabs.com> Closes#1097 from astroshim/bugfix/initRepositoryValues and squashes the following commits: f5a08d5 [astroshim] init newRepoSetting values (cherry picked from commit d4e3d8c) Signed-off-by: Mina Lee <minalee@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR fixes initialize value bug of
Add New Repository.What type of PR is it?
Bug Fix
How should this be tested?
Add New Repositorymodal window.Add New Repositorymodal window again.Screenshots (if appropriate)
Questions: