[ZEPPELIN-2234] Can't display the same chart again (master)

[1ambda]

What is this PR for?

Can't display the same chart again. I attached a screenshot.

• This should be backported into 0.7.0 as well.

Implementation Details

After #2092,

• result.html will draw chart every time since we use ng-if instead of ng-show
• that means DOM is deleted, and created too
• so we have to create visualization instance every time which requires a newly created DOM.

builtInViz.instance=newVisualization(loadedElem,config);// `loadedElem` is the newly created DOM.

What type of PR is it?

[Bug Fix]

Todos

NONE

What is the Jira issue?

• Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
• Put link here, and add [ZEPPELIN-Jira number] in PR title, eg. [ZEPPELIN-533]

How should this be tested?

I attached a screenshot

Screenshots (if appropriate)

Before: buggy

After: fixed

Questions:

• Does the licenses files need update? - NO
• Is there breaking changes for older versions? - NO
• Does this needs documentation? - NO

[soralee]

Let me test master and branch-0.7 out!

[Leemoonsoo]

Tested and it fixes the problem.

However, since the change #2092, visualization is re-created everytime when switching. I'd suggest find a way restore ng-show and address problem ZEPPELIN-2148 in different way. So we can leverage activate() deactivate() function. Otherwise it is bit annoying especially with visualization that takes long time to create/initialize.

[1ambda]

@Leemoonsoo Thanks for review.

Then I will revert 1bdab41 and #2092 while trying to use ng-show instead of.

[1ambda]

I'v just updated code. @Leemoonsoo Could you review again? Thanks!

[Leemoonsoo]

Tested and LGTM!

[prabhjyotsingh]

@1ambda Thank you for fixing this.
Tested on local, works well. LGTM.

[Leemoonsoo]

Merge to master if no further discussions.

[1ambda]

Thanks @Leemoonsoo@prabhjyotsingh!