Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-2234][BUG] Can't display the same chart again (branch-0.7) - #2114
Closed
1ambda wants to merge 2 commits into
Closed
[ZEPPELIN-2234][BUG] Can't display the same chart again (branch-0.7)#21141ambda wants to merge 2 commits into
1ambda wants to merge 2 commits into
Conversation
Leemoonsoo
commented
Mar 11, 2017
Member
1ambda
commented
Mar 11, 2017
MemberAuthor
@Leemoonsoo Thanks for caring. The implementation we talked in #2110 is not applied yet. I will modify and comment soon. |
1ambdaforce-pushed
the
ZEPPELIN-2234/cant-display-same-chart-again-for-070
branch
from
March 15, 2017 20:37
140e79b to
936123dCompare1ambda
commented
Mar 15, 2017
MemberAuthor
Rebased and fixed using the implementation discussed in #2110
|
Leemoonsoo
commented
Mar 15, 2017
Member
@1ambda Thanks! LGTM and merge to branch-0.7 if no further discussions. |
asfgit pushed a commit
that referenced
this pull request
Mar 16, 2017
### What is this PR for? Can't display the same chart again. I attached a screenshot. - this is the same fix with #2110 - except refactoring PR - based on branch-0.7 and - CI failure might be related with #2103 #### Implementation Details After #2092, - result.html will draw chart every time since we use `ng-if` instead of `ng-show` - that means DOM is deleted, and created too - so we have to create visualization instance every time which requires a newly created DOM. ```js builtInViz.instance = new Visualization(loadedElem, config); // `loadedElem` is the newly created DOM. ``` ### What type of PR is it? [Bug Fix] ### Todos NONE ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? I attached a screenshot ### Screenshots (if appropriate) ##### Before: buggy  ##### After: fixed  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1amb4a@gmail.com> Closes#2114 from 1ambda/ZEPPELIN-2234/cant-display-same-chart-again-for-070 and squashes the following commits: 936123d [1ambda] fix: Retry until graph DOM is ready 475b532 [1ambda] fix: Reert #2092 for 0.7.0
Leemoonsoo
commented
Mar 16, 2017
Member
1ambda
commented
Mar 17, 2017
MemberAuthor
@Leemoonsoo Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Can't display the same chart again. I attached a screenshot.
and
Implementation Details
After #2092,
ng-ifinstead ofng-showWhat type of PR is it?
[Bug Fix]
Todos
NONE
What is the Jira issue?
How should this be tested?
I attached a screenshot
Screenshots (if appropriate)
Before: buggy
After: fixed
Questions: