Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-6307] Rename fieldname in NewNoteRequest class - #5055
Merged
Conversation
ParkGyeongTae
approved these changes
Aug 29, 2025
ParkGyeongTae
left a comment
Member
There was a problem hiding this comment.
I think this change makes the variable name clearer.
Uh oh!
There was an error while loading. Please reload this page.
ParkGyeongTae pushed a commit
that referenced
this pull request
Aug 30, 2025
### What is this PR for? This PR renames the field 'name' to 'notePath' in the NewNoteRequest class to better reflect its purpose. The field actually represents the note's path rather than just a name, making the code more semantically clear and addressing the TODO comment that requested this change. ### What type of PR is it? Refactoring ### Todos * [x] - Rename field 'name' to 'notePath' in NewNoteRequest class ### What is the Jira issue? [ZEPPELIN-6307](https://issues.apache.org/jira/browse/ZEPPELIN-6307) ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes#5055 from celinayk/ZEPPELIN-6307. Signed-off-by: ParkGyeongTae <gyeongtae@apache.org> (cherry picked from commit d6ec974) Signed-off-by: ParkGyeongTae <gyeongtae@apache.org>
ParkGyeongTae
commented
Aug 30, 2025
Member
Merged into master and branch-0.12 |
ParkGyeongTae pushed a commit
that referenced
this pull request
Sep 4, 2025
### What is this PR for? After a field name change in `NewNoteRequest`, several tests are failing. ``` Error: Failures: Error: NotebookRestApiTest.testCreateNote:555->lambda$testCreateNote$17:557 expected: <test1> but was: <Untitled Note> Error: ZeppelinRestApiTest.testCloneNote:440->lambda$testCloneNote$8:443 Compare note names ==> expected: <clone Note Name> but was: <Cloned Note_2M6SWJ8WV> Error: ZeppelinRestApiTest.testNoteCreateWithName:159->testNoteCreate:235->lambda$testNoteCreate$2:245 compare note name ==> expected: <Test note name> but was: <Untitled Note> Error: ZeppelinRestApiTest.testNoteCreateWithParagraphs:181 test note create method: ``` Related Issue: #5055 ### What type of PR is it? Fixing broken tests ### What is the Jira issue? [ZEPPELIN-6316](https://issues.apache.org/jira/browse/ZEPPELIN-6316) ### How should this be tested? - Check if tests success in `core-modules` job. - `NotebookRestApiTest.testCreateNote` - `ZeppelinRestApiTest.testCloneNote` - `ZeppelinRestApiTest.testNoteCreateWithName` - `ZeppelinRestApiTest.testNoteCreateWithParagraphs` ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes#5066 from tbonelee/fix-tests. Signed-off-by: ParkGyeongTae <gyeongtae@apache.org>
ParkGyeongTae pushed a commit
that referenced
this pull request
Sep 4, 2025
### What is this PR for? After a field name change in `NewNoteRequest`, several tests are failing. ``` Error: Failures: Error: NotebookRestApiTest.testCreateNote:555->lambda$testCreateNote$17:557 expected: <test1> but was: <Untitled Note> Error: ZeppelinRestApiTest.testCloneNote:440->lambda$testCloneNote$8:443 Compare note names ==> expected: <clone Note Name> but was: <Cloned Note_2M6SWJ8WV> Error: ZeppelinRestApiTest.testNoteCreateWithName:159->testNoteCreate:235->lambda$testNoteCreate$2:245 compare note name ==> expected: <Test note name> but was: <Untitled Note> Error: ZeppelinRestApiTest.testNoteCreateWithParagraphs:181 test note create method: ``` Related Issue: #5055 ### What type of PR is it? Fixing broken tests ### What is the Jira issue? [ZEPPELIN-6316](https://issues.apache.org/jira/browse/ZEPPELIN-6316) ### How should this be tested? - Check if tests success in `core-modules` job. - `NotebookRestApiTest.testCreateNote` - `ZeppelinRestApiTest.testCloneNote` - `ZeppelinRestApiTest.testNoteCreateWithName` - `ZeppelinRestApiTest.testNoteCreateWithParagraphs` ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes#5066 from tbonelee/fix-tests. Signed-off-by: ParkGyeongTae <gyeongtae@apache.org> (cherry picked from commit 3a0e421) Signed-off-by: ParkGyeongTae <gyeongtae@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR renames the field 'name' to 'notePath' in the NewNoteRequest class to better reflect its purpose. The field actually represents the note's path rather than just a name, making the code more semantically clear and addressing the TODO comment that requested this change.
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
ZEPPELIN-6307
How should this be tested?
Screenshots (if appropriate)
Questions: