Skip to content

[ZEPPELIN-6316] Fix broken tests caused by field name change - #5066

Merged
ParkGyeongTae merged 5 commits into
apache:masterfrom
tbonelee:fix-tests
Sep 4, 2025
Merged

[ZEPPELIN-6316] Fix broken tests caused by field name change#5066
ParkGyeongTae merged 5 commits into
apache:masterfrom
tbonelee:fix-tests

Conversation

@tbonelee

@tboneleetbonelee commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

What is this PR for?

After a field name change in NewNoteRequest, several tests are failing.

Error: Failures:
Error: NotebookRestApiTest.testCreateNote:555->lambda$testCreateNote$17:557 expected: <test1> but was: <Untitled Note>
Error: ZeppelinRestApiTest.testCloneNote:440->lambda$testCloneNote$8:443 Compare note names ==> expected: <clone Note Name> but was: <Cloned Note_2M6SWJ8WV>
Error: ZeppelinRestApiTest.testNoteCreateWithName:159->testNoteCreate:235->lambda$testNoteCreate$2:245 compare note name ==> expected: <Test note name> but was: <Untitled Note>
Error: ZeppelinRestApiTest.testNoteCreateWithParagraphs:181 test note create method:

Related Issue: #5055

What type of PR is it?

Fixing broken tests

What is the Jira issue?

ZEPPELIN-6316

How should this be tested?

  • Check if tests success in core-modules job.
    • NotebookRestApiTest.testCreateNote
    • ZeppelinRestApiTest.testCloneNote
    • ZeppelinRestApiTest.testNoteCreateWithName
    • ZeppelinRestApiTest.testNoteCreateWithParagraphs

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

ParkGyeongTae
ParkGyeongTae previously approved these changes Sep 4, 2025

@ParkGyeongTaeParkGyeongTae left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Reamer

Copy link
Copy Markdown
Contributor

I think the following test errors are also due to the change and should also be corrected.

Error: Errors: Error: ZeppelinClientIntegrationTest.testCloneNote:170 » Unable to call rest api, status: 500, statusText: Server Error, message: org.apache.zeppelin.notebook.exception.NotePathAlreadyExistsException: Note '/Untitled Note' existed
Error: ZeppelinClientIntegrationTest.testExecuteNote:355 » Unable to call rest api, status: 500, statusText: Server Error, message: org.apache.zeppelin.notebook.exception.NotePathAlreadyExistsException: Note '/Untitled Note' existed
Error: ZeppelinClientIntegrationTest.testNoteOperation:127 » Unable to call rest api, status: 500, statusText: Server Error, message: org.apache.zeppelin.notebook.exception.NotePathAlreadyExistsException: Note '/Untitled Note' existed
Error: ZeppelinClientIntegrationTest.testRenameNote:195 » Unable to call rest api, status: 500, statusText: Server Error, message: org.apache.zeppelin.notebook.exception.NotePathAlreadyExistsException: Note '/Untitled Note' existed
Error: ZeppelinClientIntegrationTest.testSubmitNote:426 » Unable to call rest api, status: 500, statusText: Server Error, message: org.apache.zeppelin.notebook.exception.NotePathAlreadyExistsException: Note '/Untitled Note' existed
Error: ZeppelinClientIntegrationTest.testSubmitParagraph:283 » Unable to call rest api, status: 500, statusText: Server Error, message: org.apache.zeppelin.notebook.exception.NotePathAlreadyExistsException: Note '/Untitled Note' existed

@ParkGyeongTae

Copy link
Copy Markdown
Member

Could this line at zeppelin/zeppelin-client/src/main/java/org/apache/zeppelin/client/ZeppelinClient.java:306

bodyObject.put("name", notePath);

be the reason for the issue?

@ParkGyeongTaeParkGyeongTae self-assigned this Sep 4, 2025
@ParkGyeongTae
ParkGyeongTae merged commit 3a0e421 into apache:masterSep 4, 2025
16 of 18 checks passed
ParkGyeongTae pushed a commit that referenced this pull request Sep 4, 2025
### What is this PR for?
After a field name change in `NewNoteRequest`, several tests are failing.
```
Error: Failures:
Error: NotebookRestApiTest.testCreateNote:555->lambda$testCreateNote$17:557 expected: <test1> but was: <Untitled Note>
Error: ZeppelinRestApiTest.testCloneNote:440->lambda$testCloneNote$8:443 Compare note names ==> expected: <clone Note Name> but was: <Cloned Note_2M6SWJ8WV>
Error: ZeppelinRestApiTest.testNoteCreateWithName:159->testNoteCreate:235->lambda$testNoteCreate$2:245 compare note name ==> expected: <Test note name> but was: <Untitled Note>
Error: ZeppelinRestApiTest.testNoteCreateWithParagraphs:181 test note create method:
```
Related Issue: #5055
### What type of PR is it?
Fixing broken tests
### What is the Jira issue?
[ZEPPELIN-6316](https://issues.apache.org/jira/browse/ZEPPELIN-6316)
### How should this be tested?
- Check if tests success in `core-modules` job.
- `NotebookRestApiTest.testCreateNote`
- `ZeppelinRestApiTest.testCloneNote`
- `ZeppelinRestApiTest.testNoteCreateWithName`
- `ZeppelinRestApiTest.testNoteCreateWithParagraphs`
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Closes#5066 from tbonelee/fix-tests.
Signed-off-by: ParkGyeongTae <gyeongtae@apache.org>
(cherry picked from commit 3a0e421)
Signed-off-by: ParkGyeongTae <gyeongtae@apache.org>
@ParkGyeongTae

Copy link
Copy Markdown
Member

Merged into master and branch-0.12

@tbonelee
tbonelee deleted the fix-tests branch September 6, 2025 07:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tbonelee@Reamer@ParkGyeongTae