Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-559] Cassandra interpreter v2 - #600
Conversation
1ceb25d to
1fa7558Comparecorneadoug
commented
Jan 5, 2016
@doanduyhai thanks for the contribution, I know you gave some details in the JIRA issue, but could you update this PR description with our PR template? (https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md#creating-a-pull-request) |
victorcouste
commented
Jan 6, 2016
Leemoonsoo
commented
Jan 7, 2016
@doanduyhai Great improvement! Somehow last commit didn't trigger CI. Could you trigger CI for last commit? |
There was a problem hiding this comment.
Are these Options? A more idiomatic way to do this would beparsed should be Some(List(DescribeFunctionCmd(None,"toto")))
There was a problem hiding this comment.
Agree, will update the code to use more idiomatic Scala Option
6dd7a82 to
4342c0dComparedoanduyhai
commented
Jan 10, 2016
Code review has been done by @brianwawok and I pushed some refactoring. The build succeeded but Travis marked it as failed because : The log length has exceeded the limit of 4 Megabytes (this usually means that test suite is raising the same exception over and over) Looks like this is a very common issue with Travis, it is reported here: travis-ci/travis-ci#3865 |
f8bfc03 to
06a9da5Compare06a9da5 to
36e3bdbComparedoanduyhai
commented
Jan 14, 2016
@Leemoonsoo@corneadoug Finally successful build |
corneadoug
commented
Jan 14, 2016
Those headers :) |
Leemoonsoo
commented
Jan 15, 2016
Thanks @doanduyhai for big improvement! |
felixcheung
commented
Jan 20, 2016
LGTM. Any more comments or discussion on this PR? |
Leemoonsoo
commented
Jan 23, 2016
Merge if there're no more discussions |
felixcheung
commented
Jan 24, 2016
Tested, very nice interpreter thank you @doanduyhai ! Let's merge it |
### What is this PR for? Update official documentation for **Cassandra interpreter V2** Related to PR: apache#600 ### What type of PR is it? [Documentation] ### Is there a relevant Jira issue? **[ZEPPELIN-575]** ### How should this be tested? Just check the doc after the build to see if you can see the **chapter 14 Change Log** ### Questions: * Does the licenses files need update? --> **No** * Is there breaking changes for older versions? --> **No** * Does this needs documentation? --> **No** [ZEPPELIN-575]: https://issues.apache.org/jira/browse/ZEPPELIN-575 Author: DuyHai DOAN <doanduyhai@gmail.com> Closesapache#604 from doanduyhai/CassandraInterpreterDocumentation and squashes the following commits: d3f7871 [DuyHai DOAN] Use ZEPPELIN_VERSION variable instead of hard-coding c05d489 [DuyHai DOAN] Revert commit of doc cleaning PR apache#64888811ee [DuyHai DOAN] Add Zeppelin version along-side with interpreter version 01716e1 [DuyHai DOAN] Cassandra Interpreter V2 doc e3dd18b [DuyHai DOAN] [ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc pages
### What is this PR for? Update official documentation for **Cassandra interpreter V2** Related to PR: #600 ### What type of PR is it? [Documentation] ### Is there a relevant Jira issue? **[ZEPPELIN-575]** ### How should this be tested? Just check the doc after the build to see if you can see the **chapter 14 Change Log** ### Questions: * Does the licenses files need update? --> **No** * Is there breaking changes for older versions? --> **No** * Does this needs documentation? --> **No** [ZEPPELIN-575]: https://issues.apache.org/jira/browse/ZEPPELIN-575 Author: DuyHai DOAN <doanduyhai@gmail.com> Closes#604 from doanduyhai/CassandraInterpreterDocumentation and squashes the following commits: b1e70cb [DuyHai DOAN] Remove un-necessary whitespaces 80fcea4 [DuyHai DOAN] Add ZEPPELIN_VERSION in _config.yml f052bd8 [DuyHai DOAN] Fixes reference to ZEPPELIN_VERSION in markdown d3f7871 [DuyHai DOAN] Use ZEPPELIN_VERSION variable instead of hard-coding c05d489 [DuyHai DOAN] Revert commit of doc cleaning PR #64888811ee [DuyHai DOAN] Add Zeppelin version along-side with interpreter version 01716e1 [DuyHai DOAN] Cassandra Interpreter V2 doc e3dd18b [DuyHai DOAN] [ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc pages

What is this PR for?
What type of PR is it?
[Improvement]
Todos
Is there a relevant Jira issue?
ZEPPELIN-559
ZEPPELIN-575 for doc
How should this be tested?
Questions: