Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-575] Cassandra interpreter V2 documentation - #604
Conversation
There was a problem hiding this comment.
this versioning might be a bit confusing? I don't know if we have separate version for built-in interpreters but it is definitely useful to highlight changes.
There was a problem hiding this comment.
The versioning of the interpreter is here to track changes/bug fixes and new features in line with Cassandra versions.
I don't see why it is confusing. Zeppelin version relates to all core/infrastructure code. Interpreter version relates to features of custom backend
There was a problem hiding this comment.
what I mean is the interpreter jar or code itself does not have 1.0 or 2.0 version though? how would a user know which one they have? or which binary release of zeppelin has which?
There was a problem hiding this comment.
I think 1.0 and 2.0 versioning here could confusing while users can not know which Zeppelin version includes 1.0 and which Zeppelin version includes 2.0 of Cassandra interpreter.
At least mapping version with Zeppelin release version, like
2.0 - (zeppelin 0.5.6-incubating)
1.0 - (zeppelin 0.5.5-incubating)
would help user get idea about the version he is using.
Or just removing Cassandera interpreter version information (1.0, 2.0) from this doc would also fine, while the Zeppelin documentation it-self published version by version
It implies which features of Cassandera interpreters are release with which version of Zeppelin.
There was a problem hiding this comment.
I'm pretty attached to the versioning of the Cassandra interpreter because it allows users to know what has been changed/added/removed.
But your remark also makes sense because this specific versioning can be confusing for people.
The best strategy would be to specify the interpreter version along side with the Zeppelin version (SNAPSHOT or RELEASE does not matter)
elbamos
commented
Jan 13, 2016
@doanduyhai Its fine. Its not confusing at all. |
felixcheung
commented
Jan 24, 2016
You probably want to merge with master and bring this up-to-date with changes from PR #648 as well. |
bc5538f to
88811eeComparedoanduyhai
commented
Jan 27, 2016
@Leemoonsoo Done, I've added corresponding Zeppelin version along with each Cassandra interpreter version |
There was a problem hiding this comment.
I'm not sure we're planning to have 0.5.7 before we go 0.6.0.
If you mean current version of Zeppelin, i think you can define a variable ZEPPELIN_VERSIONhttps://github.com/apache/incubator-zeppelin/blob/master/docs/_config.yml, like BASE_PATH.
And reference it in the mdZeppelin {{ ZEPPELIN_VERSION}} :
There was a problem hiding this comment.
Didn't know about the {{ ZEPPELIN_VERSION}} trick, will update the doc right now. Thanks
648c6f9 to
d3f7871Compare### What is this PR for? Update official documentation for **Cassandra interpreter V2** Related to PR: apache#600 ### What type of PR is it? [Documentation] ### Is there a relevant Jira issue? **[ZEPPELIN-575]** ### How should this be tested? Just check the doc after the build to see if you can see the **chapter 14 Change Log** ### Questions: * Does the licenses files need update? --> **No** * Is there breaking changes for older versions? --> **No** * Does this needs documentation? --> **No** [ZEPPELIN-575]: https://issues.apache.org/jira/browse/ZEPPELIN-575 Author: DuyHai DOAN <doanduyhai@gmail.com> Closesapache#604 from doanduyhai/CassandraInterpreterDocumentation and squashes the following commits: d3f7871 [DuyHai DOAN] Use ZEPPELIN_VERSION variable instead of hard-coding c05d489 [DuyHai DOAN] Revert commit of doc cleaning PR apache#64888811ee [DuyHai DOAN] Add Zeppelin version along-side with interpreter version 01716e1 [DuyHai DOAN] Cassandra Interpreter V2 doc e3dd18b [DuyHai DOAN] [ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc pages
Leemoonsoo
commented
Feb 4, 2016
Regarding version, I tried and it seems need to be defined in this way https://github.com/Leemoonsoo/incubator-zeppelin/blob/ZEPPELIN-559-ver/docs/_config.yml#L24 and reference like |
doanduyhai
commented
Feb 4, 2016
Ok, will fix |
Leemoonsoo
commented
Feb 4, 2016
Could you also add ZEPPELIN_VERSION field in _config.yml like https://github.com/Leemoonsoo/incubator-zeppelin/blob/ZEPPELIN-559-ver/docs/_config.yml#L24 ? |
doanduyhai
commented
Feb 5, 2016
Done |
Leemoonsoo
commented
Feb 5, 2016
Thanks @doanduyhai |
| </td> | ||
| </tr> | ||
| </table> | ||
| ## 6. Comments in statements |
There was a problem hiding this comment.
Hi @doanduyhai : )
I think there are still some rest of numbering.
doanduyhai
commented
Feb 5, 2016
Thank you @AhyoungRyu !!! Good catch! Those whitespaces are tricky errors |
49192a6 to
4f6c07fCompare4f6c07f to
b1e70cbComparedoanduyhai
commented
Feb 9, 2016
@AhyoungRyu Can you please tell me if the last update is ok ? |
What is this PR for?
Update official documentation for Cassandra interpreter V2
Related to PR: #600
What type of PR is it?
[Documentation]
Is there a relevant Jira issue?
ZEPPELIN-575
How should this be tested?
Just check the doc after the build to see if you can see the chapter 14 Change Log
Questions: