Skip to content

[ZEPPELIN-576] Support Apache Drill Interpreter - #644

Closed
ramumalur wants to merge 10 commits into
apache:masterfrom
walmart:master
Closed

[ZEPPELIN-576] Support Apache Drill Interpreter#644
ramumalur wants to merge 10 commits into
apache:masterfrom
walmart:master

Conversation

@ramumalur

Copy link
Copy Markdown
Contributor

What is this PR for?

Supports Apache Drill Interpreter

What type of PR is it?

Improvement, Feature

Todos

  • - Documentation with Screenshots on how to use the Interpreter

Is there a relevant Jira issue?

Yes. ZEPPELIN-576

How should this be tested?

Choose a new Interpreter and provide the required details, necessary to connect to a running Apache Drill Instance. After which you can start firing Queries

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
    No
  • Is there breaking changes for older versions?
    No
  • Does this needs documentation?
    Yes

@felixcheung

Copy link
Copy Markdown
Member

Previously we have a contribution for Drill interpreter (PR #110) and it seems we have concluded that it should be on top of a generic JDBC interpreter - what you think about that approach?

In any case, the use of org.apache.drill.exec would need to be added to licenses, could you look into that?

@ramumalur

Copy link
Copy Markdown
ContributorAuthor

I looked into the Generic JDBC approach. Looks good.
So,

  • We need to use the Generic JDBC Interpreter code & extend that to provide specific properties of Drill?
  • I should wait for the pull request JDBC generic interpreter #361 to be merged to work on this?

Drill JDBC driver is Apache 2.0 License. Do we still need to add entry in Licenses folder? I can add it. Please confirm.

@vgmartinez

Copy link
Copy Markdown

Hi @Malur,
I think it's a good idea to wait to be done merge the Generic JDBC and work on that to add support for everything related to JDBC connectors. What do you think...?

@ramumalur

Copy link
Copy Markdown
ContributorAuthor

@vgmartinez, that would be right approach. I will wait for the merge to happen.

@jongyoul

Copy link
Copy Markdown
Member

@Malur Sorry for late reply. In my opinion, JDBCInterpreter can cover this feature. If it's not, please let me know. Otherwise, how about updating docs for using Drill with JDBC? https://github.com/apache/incubator-zeppelin/blob/master/docs/interpreter/hive.md will help you improve docs because the configuration of JDBCInterpreter is based on HiveInterpreter.

@ramumalur

Copy link
Copy Markdown
ContributorAuthor

@jongyoul Sure. I will check the latest code with Drill & Update docs, if needed.

@jongyoul

Copy link
Copy Markdown
Member

@Malur Thanks for positive answer. And could you please close this PR?

@ramumalur

Copy link
Copy Markdown
ContributorAuthor

Closing this PR, as generic JDBC provides the needed functionality.

@tmx11

tmx11 commented Feb 1, 2016

Copy link
Copy Markdown

Are you using the psql or hive interpreter for this to work?

Also presumably we need to copy in the drill-jdbc-all-1.1.0.jar or drill-jdbc-1.1.0.jar into the classpath.

Putting the all-jar under zeppelin/lib means the daemon can't start.

If only the other one is under lib you get commons-lang3 errors but when putting this under lib also seems to still not find.

@jongyoul

Copy link
Copy Markdown
Member

@tmx11 Hi, could you please those jars under /interpreters/jdbc/? I think this would be more general position to use that interpreter. If it still doesn't work, tell me again. Thanks.

@smartinsightsfromdata

Copy link
Copy Markdown

@jongyoul@Malur I think the relevance of Apache Drill deserves at the very least a document with a dedicated set of instructions on how to configure a Drill interpreter (i.e. a mini-tutorial).

At the moment this is missing but it would be great to have it.

E.g. 1bdf1ff doesn't even refer to Drill!!

@ramumalur

Copy link
Copy Markdown
ContributorAuthor

Agreed.
I had this in my list of TODO. Will take some time out over weekend & try to add this information.

@jongyoul

Copy link
Copy Markdown
Member

@smartinsightsfromdata@Malur I also have a plan to enable customization for specific jdbc driver, for example, completers and dedicated word and so on. Jdbc interpreter will get better.

@ramumalur

Copy link
Copy Markdown
ContributorAuthor

Cool.
Meanwhile I have added documentation around using Drill with JDBC Interpreter via PR #718

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ramumalur@felixcheung@vgmartinez@jongyoul@tmx11@smartinsightsfromdata