Skip to content

Added details on using Drill with JDBC Interpreter - #718

Closed
ramumalur wants to merge 3 commits into
apache:masterfrom
walmart:drill-documentation
Closed

Added details on using Drill with JDBC Interpreter#718
ramumalur wants to merge 3 commits into
apache:masterfrom
walmart:drill-documentation

Conversation

@ramumalur

Copy link
Copy Markdown
Contributor

What is this PR for?

Documentation to configure Drill using JDBC Interpreter

What type of PR is it?

Documentation

Todos

Is there a relevant Jira issue?

No. But there is related PR: https://issues.apache.org/jira/browse/ZEPPELIN-614

How should this be tested?

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Comment threaddocs/interpreter/drill.md Outdated
## How to use
Basically, you can use

```%jdbc(drill)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Malur! Thanks for the documentation : )

Zeppelin is using jekyll when it builds the website. But when it renders this markdown docs to html page, an error is occured because of the %jdbc(drill) which is next to the ``` as below.
screen shot 2016-02-16 at 12 40 50 am

So, could you add a new line between ``` and %jdbc(drill) ?

@AhyoungRyu

Copy link
Copy Markdown
Contributor

@Malur If you want to find this docs in Zeppelin documentation web page, you have to add <li><a href="{{BASE_PATH}}/interpreter/drill.html">Drill</a></li> below this line.

@jongyoul

Copy link
Copy Markdown
Member

@Malur Thanks for the documentation, but how about improving JDBC document? It looks good by itself, but basically, because drill is using JDBC interpreter, It looks better to improve the jdbc.md. How about you?

@ramumalur

Copy link
Copy Markdown
ContributorAuthor

@jongyoul Are you talking about adding sections in jdbc.md for configuring different Databases? Wouldn't the JDBC page be too lengthy, if we add all in one page ? How about adding Drill to the Supported Databases section & provide a link to this drill.md from there?

@corneadoug

Copy link
Copy Markdown
Contributor

@Malur yes adding drill to the supported DB in the JDBC documentation.
However most of the content of your document is already inside the JDBC, so I doubt there is a need for a separate document

@ramumalur

Copy link
Copy Markdown
ContributorAuthor

@corneadoug Sounds good.
I saw specific files for different DBs thats supported by JDBC Interpreter & added one for drill. I have deleted drill.md & updated jdbc.md accordingly.

Also, the step, informing the placement of jars in a folder & updating CLASSPATH, for configuring other drivers doesn't seem to work.

What worked for me is placing the jars under ZEPPELIN_HOME/interpreter/jdbc/. Should I raise JIRA or am I missing anything?

@minahlee

Copy link
Copy Markdown
Member

@Malur I recently made a PR for updating Zeppelin classpath via GUI for different JDBC drivers. Please see #717

@ramumalur

Copy link
Copy Markdown
ContributorAuthor

@minahlee Awesome!

@corneadoug

Copy link
Copy Markdown
Contributor

LGTM

@jongyoul

Copy link
Copy Markdown
Member

Merging if there's no more discussion

@anthonycorbacho

Copy link
Copy Markdown
Contributor

👍

prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Feb 19, 2016
## What is this PR for?
Documentation to configure Drill using JDBC Interpreter
## What type of PR is it?
Documentation
## Todos
## Is there a relevant Jira issue?
No. But there is related PR: https://issues.apache.org/jira/browse/ZEPPELIN-614
## How should this be tested?
## Screenshots (if appropriate)
## Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
Author: Ramu Malur <Ramu.Malursr@walmart.com>
Closesapache#718 from malur/drill-documentation and squashes the following commits:
0946f5b [Ramu Malur] Merge remote-tracking branch 'apache/master' into drill-documentation
5f94ef2 [Ramu Malur] Updated adbc.md with Drill support
4b6f825 [Ramu Malur] Added details on using Drill with JDBC Interpreter
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ramumalur@AhyoungRyu@jongyoul@corneadoug@minahlee@anthonycorbacho