Uh oh!
There was an error while loading. Please reload this page.
chore(clippy): allow too_many_arguments on cross_provider_dispatch (post-#363) - #369
Conversation
…ost-#363) PR #363 added cross_provider_dispatch with 11 args. clippy's too_many_arguments lint trips (threshold 7), failing 'lint (fmt + clippy)' on every workspace-wide check since #363 merged. The codebase already uses #[allow(clippy::too_many_arguments)] on five other functions of similar shape (chat.rs:1334, 1418, 1517; audio.rs:497; messages.rs:901) — matching the established pattern. A proper refactor into a context struct is the right follow-up direction; this 1-line change unblocks the queue today.
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above. Comment |
There was a problem hiding this comment.
Pull request overview
This PR restores a green CI lint pipeline by silencing Clippy’s too_many_arguments warning for the cross_provider_dispatch helper introduced in #363. It aligns messages.rs with the existing codebase pattern of using a targeted #[allow(clippy::too_many_arguments)] on dispatch/telemetry-style functions rather than refactoring signatures in a “chore” fix.
Changes:
- Add
#[allow(clippy::too_many_arguments)]tocross_provider_dispatchincrates/aisix-proxy/src/messages.rsto prevent workspace-wide Clippy failures under-D warnings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
PR #363 (
fix(proxy): record messages stream telemetry) addedcross_provider_dispatchwith 11 args. clippy'stoo_many_argumentslint trips (threshold 7), solint (fmt + clippy)has been failing on the workspace-wide check (cargo clippy --workspace --all-targets -- -D warnings) on every PR since #363 merged.This is the same pattern that #366 just fixed for #362's fmt drift. Surgical 1-line restore so the queue can move.
Why
#[allow]not refactorThe codebase already uses
#[allow(clippy::too_many_arguments)]on five other functions of similar dispatch / handler shape:crates/aisix-proxy/src/chat.rs:1334, 1418, 1517crates/aisix-proxy/src/audio.rs:497crates/aisix-proxy/src/messages.rs:901So the established convention is the attribute, not a refactor. A proper context-struct refactor for the dispatch functions is the right follow-up; that's a separate, deeper change that shouldn't sit in front of CI green.
Verification
cargo clippy --workspace --all-targets -- -D warningsclean locally on this branch (took a while from a cold cache; reusing the cache from chore(fmt): restore rustfmt on aisix-etcd loader test (post-#362) #366's worktree the run completes faster).Surfaced from
Debugging the
lint (fmt + clippy)job on ai-gateway#360 (the AISIX-Cloud#410 fix). Keeping isolated from #360 per surgical-changes discipline.