Uh oh!
There was an error while loading. Please reload this page.
chore(fmt): restore rustfmt on aisix-admin apikey-rotate concurrent test (post-#374) - #376
Conversation
…#374) PR #374 introduced two assert_eq! calls in concurrent_rotation_both_succeed_with_no_double_decrement that rustfmt expands across 5 lines. main has been failing 'lint (fmt + clippy)' on every PR since #374 merged. Same pattern as #366 (post-#362) and #369 (post-#363). Surgical 1-line-of-diff restore so the queue can move.
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above. Comment |
There was a problem hiding this comment.
Pull request overview
Restores rustfmt-compliant formatting in the aisix-admin concurrent API key rotation unit test so workspace cargo fmt -- --check stops failing after the changes introduced in #374.
Changes:
- Reformat multi-argument
assert_eq!/assert_ne!calls into rustfmt-expanded multi-line form. - Reformat some chained/conditional expressions (
final_hash, winner/loser selection) to match rustfmt output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let resp_a = task_a.await.unwrap(); | ||
| let resp_b = task_b.await.unwrap(); | ||
| assert_eq!(resp_a.status(), StatusCode::OK, "concurrent rotation a must succeed"); | ||
| assert_eq!(resp_b.status(), StatusCode::OK, "concurrent rotation b must succeed"); | ||
| assert_eq!( | ||
| resp_a.status(), | ||
| StatusCode::OK, | ||
| "concurrent rotation a must succeed" | ||
| ); |
Uh oh!
There was an error while loading. Please reload this page.
Summary
PR #374 introduced two
assert_eq!calls inconcurrent_rotation_both_succeed_with_no_double_decrementthat rustfmt expands across 5 lines each.cargo fmt --all -- --check(the CI command) has been failing on every PR since #374 merged.Third one of these in a row, same pattern as #366 (post-#362) and #369 (post-#363) — surgical fmt restore. Diff is the rustfmt-expansion exactly, no logic change.
Verification
cargo fmt --all -- --checkclean locally on this branch.cargo clippy --workspace --all-targets -- -D warningsclean (verified after chore(clippy): allow too_many_arguments on cross_provider_dispatch (post-#363) #369 merged).Surfaced from
Debugging
lint (fmt + clippy)on ai-gateway#360 (the AISIX-Cloud#410 fix) after rebasing onto fresh main with #369 landed.Suggestion (out of scope)
Three consecutive merge-with-broken-CI events on
lint (fmt + clippy)suggests the workflow's failure on the offending PR didn't block the merge. Worth a separate look at branch protection rules — but that's not this PR.