Uh oh!
There was an error while loading. Please reload this page.
fix: Do not mask unrelated import errors when guarding optional dependencies - #1009
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #1009 +/- ##
==========================================
+ Coverage 94.86% 94.89% +0.02%
==========================================
Files 58 58 Lines 5357 5366 +9 ==========================================
+ Hits 5082 5092 +10 + Misses 275 274 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
August 17, 2026 09:57
Pijukatel
approved these changes
Aug 17, 2026
Uh oh!
There was an error while loading. Please reload this page.
vdusek added a commit
that referenced
this pull request
Aug 17, 2026
…onses (#1010) `HttpResponse` now comes from `typing_extensions`, whose runtime protocol check looks attributes up statically. The `typing` implementation on Python 3.11 calls `hasattr`, which evaluates properties, so `isinstance(response, HttpResponse)` on an unread streaming response either raised or silently buffered the whole body. Adds streaming regression tests (unit and integration) and a parametrized built-in-client fixture they run on. Split out of #1006. Stacked on #1009. *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try_importnow swallows only theModuleNotFoundErrorof the optional dependency it names, so an import error raised by the importing module itself or by another dependency propagates instead of being masked.__all__ofapify_client.http_compressorsomitsBrotliHttpCompressorwhen thebrotliextra is not installed, since the symbol was never provided.Split out of #1006.
✍️ Drafted by Claude Code