Uh oh!
There was an error while loading. Please reload this page.
fix: Unify the request pipeline and retry policy across HTTP clients - #1006
Closed
vdusek wants to merge 3 commits into
Closed
fix: Unify the request pipeline and retry policy across HTTP clients#1006vdusek wants to merge 3 commits into
vdusek wants to merge 3 commits into
Conversation
Move `call`, the retry loop, and the per-attempt request handling from `ImpitHttpClient` into `HttpClient` and `HttpClientAsync`, leaving Impit as a thin adapter over the `send_request`, error-classification, and lifecycle hooks. A custom client that overrides `call` keeps working unchanged and opts out of the shared pipeline. The same pass fixes: - Transport errors a retry cannot fix (`UnsupportedProtocol`, `LocalProtocolError`, `TooManyRedirects`) fail on the first attempt instead of burning the whole backoff. Every other error in the `impit.HTTPError` tree stays retryable, including a bare `HTTPError` from a body that ends mid-chunk and a `ProxyError` from a proxy answering CONNECT with a transient status. - A failure while reading a streamed error response is classified and retried like a send failure, and the response is closed instead of being left open. - `HttpResponse` comes from `typing_extensions`, whose runtime protocol check looks attributes up statically, so `isinstance(response, HttpResponse)` no longer buffers or rejects an unread streaming body. - `try_import` only substitutes failed imports for the optional dependency it names, so an `ImportError` from the importing module or another dependency is no longer masked, and `__all__` omits what a missing extra never provided.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #1006 +/- ##
==========================================
+ Coverage 94.86% 94.91% +0.04%
==========================================
Files 58 58 Lines 5357 5406 +49 ==========================================
+ Hits 5082 5131 +49
Misses 275 275
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 17, 2026
vdusek added a commit
that referenced
this pull request
Aug 17, 2026
…dencies (#1009) `try_import` now swallows only the `ModuleNotFoundError` of the optional dependency it names, so an import error raised by the importing module itself or by another dependency propagates instead of being masked. `__all__` of `apify_client.http_compressors` omits `BrotliHttpCompressor` when the `brotli` extra is not installed, since the symbol was never provided. Split out of #1006. *✍️ Drafted by Claude Code*
vdusek added a commit
that referenced
this pull request
Aug 17, 2026
…onses (#1010) `HttpResponse` now comes from `typing_extensions`, whose runtime protocol check looks attributes up statically. The `typing` implementation on Python 3.11 calls `hasattr`, which evaluates properties, so `isinstance(response, HttpResponse)` on an unread streaming response either raised or silently buffered the whole body. Adds streaming regression tests (unit and integration) and a parametrized built-in-client fixture they run on. Split out of #1006. Stacked on #1009. *✍️ Drafted by Claude Code*
vdusek
commented
Aug 18, 2026
ContributorAuthor
This will be split into several smaller PRs |
This was referenced Aug 18, 2026
vdusek added a commit
that referenced
this pull request
Aug 18, 2026
`_utils/errors.py::is_retryable_error` is a stale copy of `http_clients/_impit.py::_is_retryable_error`. No production code calls it — only its own tests did — and it sits in a private module, so nothing depends on it. Once #1019 narrows the real policy, keeping a second copy that still claims every `impit.HTTPError` is transient is actively misleading. Removes the function, its two test cases, and the imports they alone needed. Split out of #1006. *✍️ Drafted by Claude Code*
vdusek added a commit
that referenced
this pull request
Aug 18, 2026
Every `impit.HTTPError` counted as transient, so a transport failure a retry cannot fix burned the whole backoff before surfacing. The permanent classes now fail on the first attempt instead: - `LocalProtocolError` - a request Impit rejects before sending it, e.g. one carrying an invalid header value. - `TooManyRedirects` - a routing loop, which repeating the request cannot break. - `UnsupportedProtocol` - the class Impit declares for a scheme it refuses to speak, but does not raise today; an unsupported scheme arrives as `impit.InvalidURL`, outside the `impit.HTTPError` tree and non-retryable already. Listed so the classifier stays right if Impit switches over. - `HTTPStatusError` - only `Response.raise_for_status()` raises it and the client never calls it; `_make_request` decides on status codes from the response itself. Everything else in the `impit.HTTPError` tree stays retryable, including a bare `HTTPError` - Impit wraps a failure its internal HTTP library did not classify in one, e.g. a non-HTTP response or a connection reset - and a `ProxyError`, which covers a rejected CONNECT tunnel and a 407 alike, so a transient case cannot be told from a permanent one. Also drops `InvalidResponseBodyError` from the retry check. Only `key_value_store.py` raises it, once `call` has already returned, so it can never reach the classifier. Its docstring no longer claims the client retries such requests. The duplicate `is_retryable_error` in `_utils/errors.py`, which carried the old policy, is gone. Split out of #1006 and re-targeted at `master`, so the retry fixes can ship in a patch release ahead of the pipeline refactor in #1011. *✍️ Drafted by Claude Code*
vdusek added a commit
that referenced
this pull request
Aug 18, 2026
…1020) Before raising `ApifyApiError`, `_make_request` buffers the response so a streamed error body reaches the exception. That read sat outside the `try` block that classifies an attempt, so a failure there escaped the retry policy entirely: a non-retryable failure was retried through the whole backoff, and the response was left open. The read now goes through the same classification as a failed send — retried when it is a transient transport failure, surfaced immediately when it is not — and the response is closed before the exception propagates. Split out of #1006 and re-targeted at `master`, so the retry fixes can ship in a patch release ahead of the pipeline refactor in #1011. *✍️ Drafted by Claude Code*
vdusek added a commit
that referenced
this pull request
Aug 19, 2026
Moves `call`, the retry loop, and the per-attempt request handling from `ImpitHttpClient` and `ImpitHttpClientAsync` into `HttpClient` and `HttpClientAsync`, leaving Impit as a thin adapter over the transport hooks: `send_request`, `is_retryable_transport_error`, `is_timeout_error`, and `close()` / `aclose()` plus context managers. A custom client that overrides `call` keeps working unchanged and opts out of the shared pipeline. `StreamedLog` classifies timeouts through the transport-neutral `is_timeout_error` hook instead of importing Impit. No behavior change for the built-in clients: the retry policy shipped in #1019 (permanent transport errors fail fast) and #1020 (a failed read of a streamed error body is classified like a failed send and the response is closed) is preserved — the classification now lives in the `is_retryable_transport_error` hook, and the error-body read handling in the shared pipeline. Supersedes #1011, rebased onto current master and squashed. Originally split out of #1006. *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
call, the retry loop, and the per-attempt request handling fromImpitHttpClientintoHttpClientandHttpClientAsync, leaving Impit as a thin adapter over the transport hooks:send_request,is_retryable_transport_error,is_timeout_error, andclose()/aclose()plus context managers. A custom client that overridescallkeeps working unchanged and opts out of the shared pipeline.The same pass fixes:
UnsupportedProtocol,LocalProtocolError,TooManyRedirects) fail on the first attempt instead of burning the whole backoff. Everything else in theimpit.HTTPErrortree stays retryable, including a bareHTTPErrorfrom a body that ends mid-chunk and aProxyErrorfrom a proxy answering CONNECT with a transient status.HttpResponsecomes fromtyping_extensions, whose runtime protocol check looks attributes up statically, soisinstance(response, HttpResponse)no longer buffers or rejects an unread streaming body.try_importonly substitutes failed imports for the optional dependency it names, so anImportErrorfrom the importing module or another dependency is no longer masked, and__all__omits what a missing extra never provided.Split out of #1004, which adds the built-in HTTPX client on top of this contract.
✍️ Drafted by Claude Code