Uh oh!
There was an error while loading. Please reload this page.
fix: Classify and retry failures while reading a streamed error body - #1020
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #1020 +/- ##
==========================================
- Coverage 94.87% 94.87% -0.01%
==========================================
Files 58 58 Lines 5367 5384 +17 ==========================================
+ Hits 5092 5108 +16 - Misses 275 276 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
August 18, 2026 13:48
Pijukatel
approved these changes
Aug 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 18, 2026
vdusek added a commit
that referenced
this pull request
Aug 19, 2026
Moves `call`, the retry loop, and the per-attempt request handling from `ImpitHttpClient` and `ImpitHttpClientAsync` into `HttpClient` and `HttpClientAsync`, leaving Impit as a thin adapter over the transport hooks: `send_request`, `is_retryable_transport_error`, `is_timeout_error`, and `close()` / `aclose()` plus context managers. A custom client that overrides `call` keeps working unchanged and opts out of the shared pipeline. `StreamedLog` classifies timeouts through the transport-neutral `is_timeout_error` hook instead of importing Impit. No behavior change for the built-in clients: the retry policy shipped in #1019 (permanent transport errors fail fast) and #1020 (a failed read of a streamed error body is classified like a failed send and the response is closed) is preserved — the classification now lives in the `is_retryable_transport_error` hook, and the error-body read handling in the shared pipeline. Supersedes #1011, rebased onto current master and squashed. Originally split out of #1006. *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before raising
ApifyApiError,_make_requestbuffers the response so a streamed error body reaches the exception. That read sat outside thetryblock that classifies an attempt, so a failure there escaped the retry policy entirely: a non-retryable failure was retried through the whole backoff, and the response was left open.The read now goes through the same classification as a failed send — retried when it is a transient transport failure, surfaced immediately when it is not — and the response is closed before the exception propagates.
Split out of #1006 and re-targeted at
master, so the retry fixes can ship in a patch release ahead of the pipeline refactor in #1011.✍️ Drafted by Claude Code