Skip to content

refactor: Remove the unused retry classification helper - #1021

Merged
vdusek merged 1 commit into
masterfrom
refactor-drop-dead-retry-helper
Aug 18, 2026
Merged

refactor: Remove the unused retry classification helper#1021
vdusek merged 1 commit into
masterfrom
refactor-drop-dead-retry-helper

Conversation

@vdusek

Copy link
Copy Markdown
Contributor

_utils/errors.py::is_retryable_error is a stale copy of http_clients/_impit.py::_is_retryable_error. No production code calls it — only its own tests did — and it sits in a private module, so nothing depends on it. Once #1019 narrows the real policy, keeping a second copy that still claims every impit.HTTPError is transient is actively misleading.

Removes the function, its two test cases, and the imports they alone needed.

Split out of #1006.

✍️ Drafted by Claude Code

@vdusekvdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Aug 18, 2026
@vdusekvdusek self-assigned this Aug 18, 2026
@github-actionsgithub-actionsBot added the tested Temporary label used only programatically for some analytics. label Aug 18, 2026
@codecov

codecovBot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.87%. Comparing base (334e131) to head (b0939e3).

Additional details and impacted files
@@ Coverage Diff @@## master #1021 +/- ##
==========================================
- Coverage 94.87% 94.87% -0.01% 
==========================================
Files 58 58 Lines 5367 5364 -3 ==========================================
- Hits 5092 5089 -3 
Misses 275 275 
FlagCoverage Δ
integration92.20% <100.00%> (-0.01%)⬇️
unit85.14% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek requested a review from PijukatelAugust 18, 2026 13:47
@vdusek
vdusek marked this pull request as ready for review August 18, 2026 13:47
@vdusek
vdusek merged commit 3e1d8b4 into masterAug 18, 2026
30 checks passed
@vdusek
vdusek deleted the refactor-drop-dead-retry-helper branch August 18, 2026 14:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhocAd-hoc unplanned task added during the sprint.t-toolingIssues with this label are in the ownership of the tooling team.testedTemporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vdusek@Pijukatel@apify-service-account