Uh oh!
There was an error while loading. Please reload this page.
Conversation
fryanpan added a commit
that referenced
this pull request
Jul 30, 2026
reliability-gaps: summary cut to three bullets, table promoted to the decision content. #87 demoted - it only fires in projects with an annotation processor, which is a minority and an area Quick Build does not really support yet. #88 raised to the top: deterministic on every rebaseline reinstall, so it reaches everyone. #90 kept as blocking - a rebaseline runs long enough that backgrounding is the normal thing to do, not an edge case. Blocks-v1 is now TBD on every row for the team to decide; priority is the sort order and is stated once, not encoded three ways. Detail sections keyed by task number now that the # column is gone. Frequency cells say which rows are code-reading-only. on-device-storage-performance: rewritten as a fileable ticket and cut from 1476 to ~965 words. Kept what was run and what is slow; dropped the mechanism digression and the duplicated scope prose. perf-roadmap: provenance section cut to one line. Added a bulleted explanation of the five warm-edit stages, from the daemon source, plus two caveats the table was hiding - policy+walks sums a host-side span with a daemon-side one, and the walk time is already inside the compile RPC, so the column is not additive with total. benchmarking: dropped the "which number to quote" framing throughout. The team wants all the readings and the tradeoffs between them, not one blessed figure. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MkdFG7t9oNJtiayQzUQf89
fryanpan added a commit
that referenced
this pull request
Jul 31, 2026
…arted Audited what QB already emits vs David's three tuning questions (edit category/trigger, multi-module encounter rate, resulting timing). The Firebase analytics pipeline is real and already default-wired (AnalyticsQuickBuildMetricsSink); edit-category and timing were already fully covered. Multi-module encounter rate was not: the only existing signal, InvalidationReason.NON_APP_MODULE_SOURCE_CHANGED, only fires when an edit lands outside the app module, so a multi-module project edited entirely within the app module looked identical to single-module. IProjectManager.getAndroidModules() already gives a direct module count with no new project-analysis work, so forward it: a new moduleCount supplier on AnalyticsQuickBuildMetricsSink (default no-op, source compatible), a new optional moduleCount field on QuickBuildStartedMetric, and the DI wiring supplying the real count. moduleCount > 1 answers "was this project multi-module" directly. Full audit, including the resulting-timing gap this pass did NOT close (recovered defect-#88 deploys are an unflagged, reload-segment-inflating subpopulation - needs new instrumentation, not a wiring change), is in the wrapper repo's analytics-gap-note-2026-07-31.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fryanpan added a commit
that referenced
this pull request
Jul 31, 2026
Cleanup plan commit 3 of 8: everything from the deploy decision onward - hot swap vs restart, the binder-death wait, the relaunch + reconnect verification, the defect-#88 launch-and-retry, and the failure mapping - moves to internal PayloadDeployer (deployDecided/deployPayload/ deployRestart/deployRecovering/metadata/failureOf, verbatim). The executor constructs it from its own ctor params (clean partition; only clock and deploy shared), so its constructor, the Koin wiring, and LiveReloadExecutorImplTest are untouched. The two direct deployPayload call sites (resources-only, assets-only) route through the seam with an explicit DeployDecision.Recreate - same code path as before. New seam tests cover reconnect-generation honesty, the ack-without-exit fallback, and the exactly-one launch-and-retry recovery. No existing test edited. :quick-build:test 3582 tests, 0 failures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QTVTzgiPq4evYCuPLTNUvL
fryanpan added a commit
that referenced
this pull request
Aug 27, 2026
Six places where a Quick Build doc contradicted the code it describes. Each was re-verified against the source rather than taken from the review comment. - debugging.md: the deploy round-trip row said the 15 s bound covers "one AIDL onPayload call". IQuickBuildTarget is a oneway interface, so that call returns immediately; DeployChannel wraps the call plus the wait for a generation-matched report, which is what its own KDoc already said. - why-not-android-jar.md: listed native libs as hot-loadable. A .so under jniLibs forces a Gradle fallback (ChangeClassifier). Loadable at runtime and changeable via live reload are different properties. - reliability-gaps.md: "five user-facing defects" against three fixed and four open. Seven were surfaced; the fixed three are relink-stuck, #88 and #90. Also states why Blocks v1? reads TBD - the decision at the top is a proposal, and the cells become "No" when it is confirmed. - low-spec-devices.md: stated an inferred mechanism (SerialGC thrashing in a small heap) as the confirmed cause of the 1.9 GB failure. The outcome is measured; the mechanism is not, and the uncapped run that would confirm it is still unmeasured. Retitled to what was actually observed. - concurrency.md: the tap-races-its-own-save section read as current behaviour. It describes the pre-2026-08-13 design that the redesign below it replaced. - perf-roadmap.md: incomplete sentence. Not applied: CodeRabbit's finding that manual-qa.md's screenrecord --time-limit 1740 is invalid because AOSP caps at 180 s. False on our hardware - recordings of 1774 s, 2432 s, 2592 s, 2842 s and 3534 s have all completed on the A56, and the surrounding comment already documents the real 30-minute cap that 1740 sits under. Applying it would break working recordings. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FstXxJ5cwWPcvmhZ9vJgJ7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed osx, windows, freebsd from gradle-8.0.-bin.zip and gradle-8.7.bin.zip