Skip to content

Adfa 602 - #90

Merged
jimturner-adfa merged 4 commits into
stagefrom
ADFA-602
Apr 25, 2025
Merged

Adfa 602#90
jimturner-adfa merged 4 commits into
stagefrom
ADFA-602

Conversation

@yaturner

Copy link
Copy Markdown
Contributor

removed _MACOSX directory from android-sdk.zip

@jatezzz
jatezzz requested a review from a teamApril 16, 2025 19:53

@jatezzzjatezzz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change

@jimturner-adfa
jimturner-adfa merged commit 007d69e into stageApr 25, 2025
@jimturner-adfa
jimturner-adfa deleted the ADFA-602 branch April 25, 2025 21:17
jatezzz pushed a commit that referenced this pull request Jun 22, 2026
* remove osx, windows, freebsd from gradle-8.0.-bin.zip and graadle-8.7.bin.zip
* removed _MACOSX directory
* removed incorrectly placed zip files from ternmux
---------
Co-authored-by: CoGo <jim.turner@appdevforall.org>
fryanpan added a commit that referenced this pull request Jul 30, 2026
reliability-gaps: summary cut to three bullets, table promoted to the
decision content. #87 demoted - it only fires in projects with an
annotation processor, which is a minority and an area Quick Build does
not really support yet. #88 raised to the top: deterministic on every
rebaseline reinstall, so it reaches everyone. #90 kept as blocking -
a rebaseline runs long enough that backgrounding is the normal thing to
do, not an edge case. Blocks-v1 is now TBD on every row for the team to
decide; priority is the sort order and is stated once, not encoded three
ways. Detail sections keyed by task number now that the # column is gone.
Frequency cells say which rows are code-reading-only.
on-device-storage-performance: rewritten as a fileable ticket and cut
from 1476 to ~965 words. Kept what was run and what is slow; dropped the
mechanism digression and the duplicated scope prose.
perf-roadmap: provenance section cut to one line. Added a bulleted
explanation of the five warm-edit stages, from the daemon source, plus
two caveats the table was hiding - policy+walks sums a host-side span
with a daemon-side one, and the walk time is already inside the compile
RPC, so the column is not additive with total.
benchmarking: dropped the "which number to quote" framing throughout.
The team wants all the readings and the tradeoffs between them, not one
blessed figure.
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MkdFG7t9oNJtiayQzUQf89
fryanpan added a commit that referenced this pull request Aug 27, 2026
Six places where a Quick Build doc contradicted the code it describes. Each was
re-verified against the source rather than taken from the review comment.
- debugging.md: the deploy round-trip row said the 15 s bound covers "one AIDL
onPayload call". IQuickBuildTarget is a oneway interface, so that call returns
immediately; DeployChannel wraps the call plus the wait for a
generation-matched report, which is what its own KDoc already said.
- why-not-android-jar.md: listed native libs as hot-loadable. A .so under
jniLibs forces a Gradle fallback (ChangeClassifier). Loadable at runtime and
changeable via live reload are different properties.
- reliability-gaps.md: "five user-facing defects" against three fixed and four
open. Seven were surfaced; the fixed three are relink-stuck, #88 and #90. Also
states why Blocks v1? reads TBD - the decision at the top is a proposal, and
the cells become "No" when it is confirmed.
- low-spec-devices.md: stated an inferred mechanism (SerialGC thrashing in a
small heap) as the confirmed cause of the 1.9 GB failure. The outcome is
measured; the mechanism is not, and the uncapped run that would confirm it is
still unmeasured. Retitled to what was actually observed.
- concurrency.md: the tap-races-its-own-save section read as current behaviour.
It describes the pre-2026-08-13 design that the redesign below it replaced.
- perf-roadmap.md: incomplete sentence.
Not applied: CodeRabbit's finding that manual-qa.md's screenrecord
--time-limit 1740 is invalid because AOSP caps at 180 s. False on our hardware -
recordings of 1774 s, 2432 s, 2592 s, 2842 s and 3534 s have all completed on
the A56, and the surrounding comment already documents the real 30-minute cap
that 1740 sits under. Applying it would break working recordings.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FstXxJ5cwWPcvmhZ9vJgJ7
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yaturner@jatezzz@jimturner-adfa