Skip to content

emrg: use logger.exception for scrollback push render failure in terminal - #72

Merged
argszero merged 1 commit into
masterfrom
feature/logger-exception-scrollback
Jul 19, 2026
Merged

emrg: use logger.exception for scrollback push render failure in terminal#72
argszero merged 1 commit into
masterfrom
feature/logger-exception-scrollback

Conversation

@argszero

@argszeroargszero commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Replace silent return on exception in append_to_scrollback with logger.exception to capture traceback info. Consistent with the same widget.render() pattern already fixed in _get_lines by #69.

argszero
argszero commented Jul 18, 2026
View reviewed changes

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle #41

argszero
argszero commented Jul 18, 2026
View reviewed changes

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle #42

@argszeroargszero mentioned this pull request Jul 18, 2026
Merged
argszero
argszero commented Jul 19, 2026
View reviewed changes

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle #43

@argszero
argszero merged commit a5189b8 into masterJul 19, 2026
1 check passed
@argszero
argszero deleted the feature/logger-exception-scrollback branch July 28, 2026 11:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@argszero