emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24) - #864

Merged
argszero merged 4 commits into
masterfrom
feature/tool-intent
Aug 19, 2026
Merged

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24)#864
argszero merged 4 commits into
masterfrom
feature/tool-intent

Conversation

@argszero

Copy link
Copy Markdown
Owner

Tool intent parameter replaces static purpose (host rants 10:33:29 + 10:35:24)

Host-finalized: every tool call should carry the agent's per-call intent ("why am I calling this, what do I want to achieve") instead of the static purpose field. Logs/GUI show the intent — real "doing X because of Y" readability.

Changes

  1. 7 tools (bash/edit/glob/grep/read/write/submit_rant) — added required intent string param to their JSON Schemas (properties + required); removed the static purpose=... lines.
  2. ToolDefinitionpurpose field + docstring removed (tool_types.py).
  3. Execution ignores intentintent is display-only metadata; the executors keep running on their real arguments (unknown keys are naturally ignored by arguments.get(...)).
  4. Daemon logging — 3 sites now log the intent:
    • main tool loop: tool call: <name> — <intent> (was — <purpose> (<redacted JSON>))
    • memory reflection + consolidation debug logs: same switch
    • intent missing (internal/LLM-free calls) → -
  5. tool_start broadcast — carries "intent": args.get("intent"); ToolStart protocol gains an intent field.
  6. TUI/GUI display — TUI ToolCard header shows intent when present (falls back to formatted args); GUI tool row shows an italic tool-intent span.
  7. Prompt guidancesystem.j2 Tool Usage section now instructs every tool call to include intent.

Tests

  • test_tool_types.py::test_no_purpose_field — ToolDefinition has no purpose
  • test_submit_rant_tool.pytest_all_tools_have_purposetest_all_tools_require_intent (all 7 tools require intent, no purpose); consent-contract test asserts intent required
  • test_protocol.py — ToolStart carries intent (and defaults "")
  • test_ws_e2e.py::test_tool_intent_logged_and_ignored_by_execution — daemon broadcasts intent in tool_start while the executor still runs on real args
  • Agent.md test count 967 → 969 (branch base; +2 net tests)

Verification

  • py_compile all touched Python ✓ · node --check chat.js
  • Mocked run: tool call: bash — 检查回显 / missing intent → tool call: bash — -
  • All 7 tool schemas: intent in properties + required, no purpose attr ✓

EMRG Evolution added 4 commits August 19, 2026 10:46
…to 971
- test_glob_tool / test_grep_tool: intent is now a required parameter
- merge master (v0.2.52 + #863) so PR CI covers full suite
- Agent.md test count 969 -> 971 (net +2 intent tests)
The mock put the finish_reason=stop delta in the same stream as the
tool call, so the daemon's Case-1 branch treated the round as a final
text answer and dropped the tool calls (no tool_start broadcast).
Follow the established _make_fake_chat_stream pattern: round 1 emits
the tool call (finish tool_calls), round 2 the final answer (stop).

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3): head b1375e0, CI test + test-windows PASS (32211538781). Tool intent required param on all 7 tools (purpose removed), ToolStart.intent broadcast, daemon tool-call logging shows intent, TUI/GUI display intent; executors ignore the extra key. Branch merged master (v0.2.52 + #863) and Agent.md count synced to 971.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3): re-reviewed head b1375e0 fresh. All 7 tool executors read args via .get() (extra intent key tolerated, never executed); daemon logs/broadcasts intent (tool call + memory reflection + consolidation); ToolStart carries intent; TUI card header + GUI tool-row show intent; system.j2 instructs agent to always write intent; purpose field fully removed from ToolDefinition with updated tests (protocol defaults, no-purpose guard, e2e stateful two-round mock verifies broadcast + executor). CI test + test-windows PASS (32211538781).

@pm25coder

Copy link
Copy Markdown
Collaborator

Independent test report (cycle 2026-08-19, Contributor):

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3): head b1375e0 unchanged since 2/3, CI test + test-windows PASS (32211538781), MERGEABLE/CLEAN. Fresh verification of the diff (21 files, +183/−41): intent required param on all 7 tools, purpose field removed, executors use .get() (intent never executed), daemon logs/broadcasts intent, TUI/GUI display, system.j2 instructs agent, e2e stateful mock asserts broadcast + execution. Approving for merge.

@argszero
argszero merged commit c67fa3e into masterAug 19, 2026
2 checks passed
@argszero
argszero deleted the feature/tool-intent branch August 19, 2026 03:28
argszero added a commit that referenced this pull request Aug 19, 2026
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@argszero@pm25coder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24) - #864

Merged
argszero merged 4 commits into
masterfrom
feature/tool-intent
Aug 19, 2026
Merged

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24)#864
argszero merged 4 commits into
masterfrom
feature/tool-intent

Conversation

@argszero

Copy link
Copy Markdown
Owner

Tool intent parameter replaces static purpose (host rants 10:33:29 + 10:35:24)

Host-finalized: every tool call should carry the agent's per-call intent ("why am I calling this, what do I want to achieve") instead of the static purpose field. Logs/GUI show the intent — real "doing X because of Y" readability.

Changes

  1. 7 tools (bash/edit/glob/grep/read/write/submit_rant) — added required intent string param to their JSON Schemas (properties + required); removed the static purpose=... lines.
  2. ToolDefinitionpurpose field + docstring removed (tool_types.py).
  3. Execution ignores intentintent is display-only metadata; the executors keep running on their real arguments (unknown keys are naturally ignored by arguments.get(...)).
  4. Daemon logging — 3 sites now log the intent:
    • main tool loop: tool call: <name> — <intent> (was — <purpose> (<redacted JSON>))
    • memory reflection + consolidation debug logs: same switch
    • intent missing (internal/LLM-free calls) → -
  5. tool_start broadcast — carries "intent": args.get("intent"); ToolStart protocol gains an intent field.
  6. TUI/GUI display — TUI ToolCard header shows intent when present (falls back to formatted args); GUI tool row shows an italic tool-intent span.
  7. Prompt guidancesystem.j2 Tool Usage section now instructs every tool call to include intent.

Tests

  • test_tool_types.py::test_no_purpose_field — ToolDefinition has no purpose
  • test_submit_rant_tool.pytest_all_tools_have_purposetest_all_tools_require_intent (all 7 tools require intent, no purpose); consent-contract test asserts intent required
  • test_protocol.py — ToolStart carries intent (and defaults "")
  • test_ws_e2e.py::test_tool_intent_logged_and_ignored_by_execution — daemon broadcasts intent in tool_start while the executor still runs on real args
  • Agent.md test count 967 → 969 (branch base; +2 net tests)

Verification

  • py_compile all touched Python ✓ · node --check chat.js
  • Mocked run: tool call: bash — 检查回显 / missing intent → tool call: bash — -
  • All 7 tool schemas: intent in properties + required, no purpose attr ✓

EMRG Evolution added 4 commits August 19, 2026 10:46
…to 971
- test_glob_tool / test_grep_tool: intent is now a required parameter
- merge master (v0.2.52 + #863) so PR CI covers full suite
- Agent.md test count 969 -> 971 (net +2 intent tests)
The mock put the finish_reason=stop delta in the same stream as the
tool call, so the daemon's Case-1 branch treated the round as a final
text answer and dropped the tool calls (no tool_start broadcast).
Follow the established _make_fake_chat_stream pattern: round 1 emits
the tool call (finish tool_calls), round 2 the final answer (stop).

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3): head b1375e0, CI test + test-windows PASS (32211538781). Tool intent required param on all 7 tools (purpose removed), ToolStart.intent broadcast, daemon tool-call logging shows intent, TUI/GUI display intent; executors ignore the extra key. Branch merged master (v0.2.52 + #863) and Agent.md count synced to 971.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3): re-reviewed head b1375e0 fresh. All 7 tool executors read args via .get() (extra intent key tolerated, never executed); daemon logs/broadcasts intent (tool call + memory reflection + consolidation); ToolStart carries intent; TUI card header + GUI tool-row show intent; system.j2 instructs agent to always write intent; purpose field fully removed from ToolDefinition with updated tests (protocol defaults, no-purpose guard, e2e stateful two-round mock verifies broadcast + executor). CI test + test-windows PASS (32211538781).

@pm25coder

Copy link
Copy Markdown
Collaborator

Independent test report (cycle 2026-08-19, Contributor):

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3): head b1375e0 unchanged since 2/3, CI test + test-windows PASS (32211538781), MERGEABLE/CLEAN. Fresh verification of the diff (21 files, +183/−41): intent required param on all 7 tools, purpose field removed, executors use .get() (intent never executed), daemon logs/broadcasts intent, TUI/GUI display, system.j2 instructs agent, e2e stateful mock asserts broadcast + execution. Approving for merge.

@argszero
argszero merged commit c67fa3e into masterAug 19, 2026
2 checks passed
@argszero
argszero deleted the feature/tool-intent branch August 19, 2026 03:28
argszero added a commit that referenced this pull request Aug 19, 2026
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@argszero@pm25coder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24) - #864

Merged
argszero merged 4 commits into
masterfrom
feature/tool-intent
Aug 19, 2026
Merged

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24)#864
argszero merged 4 commits into
masterfrom
feature/tool-intent

Conversation

@argszero

Copy link
Copy Markdown
Owner

Tool intent parameter replaces static purpose (host rants 10:33:29 + 10:35:24)

Host-finalized: every tool call should carry the agent's per-call intent ("why am I calling this, what do I want to achieve") instead of the static purpose field. Logs/GUI show the intent — real "doing X because of Y" readability.

Changes

  1. 7 tools (bash/edit/glob/grep/read/write/submit_rant) — added required intent string param to their JSON Schemas (properties + required); removed the static purpose=... lines.
  2. ToolDefinitionpurpose field + docstring removed (tool_types.py).
  3. Execution ignores intentintent is display-only metadata; the executors keep running on their real arguments (unknown keys are naturally ignored by arguments.get(...)).
  4. Daemon logging — 3 sites now log the intent:
    • main tool loop: tool call: <name> — <intent> (was — <purpose> (<redacted JSON>))
    • memory reflection + consolidation debug logs: same switch
    • intent missing (internal/LLM-free calls) → -
  5. tool_start broadcast — carries "intent": args.get("intent"); ToolStart protocol gains an intent field.
  6. TUI/GUI display — TUI ToolCard header shows intent when present (falls back to formatted args); GUI tool row shows an italic tool-intent span.
  7. Prompt guidancesystem.j2 Tool Usage section now instructs every tool call to include intent.

Tests

  • test_tool_types.py::test_no_purpose_field — ToolDefinition has no purpose
  • test_submit_rant_tool.pytest_all_tools_have_purposetest_all_tools_require_intent (all 7 tools require intent, no purpose); consent-contract test asserts intent required
  • test_protocol.py — ToolStart carries intent (and defaults "")
  • test_ws_e2e.py::test_tool_intent_logged_and_ignored_by_execution — daemon broadcasts intent in tool_start while the executor still runs on real args
  • Agent.md test count 967 → 969 (branch base; +2 net tests)

Verification

  • py_compile all touched Python ✓ · node --check chat.js
  • Mocked run: tool call: bash — 检查回显 / missing intent → tool call: bash — -
  • All 7 tool schemas: intent in properties + required, no purpose attr ✓

EMRG Evolution added 4 commits August 19, 2026 10:46
…to 971
- test_glob_tool / test_grep_tool: intent is now a required parameter
- merge master (v0.2.52 + #863) so PR CI covers full suite
- Agent.md test count 969 -> 971 (net +2 intent tests)
The mock put the finish_reason=stop delta in the same stream as the
tool call, so the daemon's Case-1 branch treated the round as a final
text answer and dropped the tool calls (no tool_start broadcast).
Follow the established _make_fake_chat_stream pattern: round 1 emits
the tool call (finish tool_calls), round 2 the final answer (stop).

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3): head b1375e0, CI test + test-windows PASS (32211538781). Tool intent required param on all 7 tools (purpose removed), ToolStart.intent broadcast, daemon tool-call logging shows intent, TUI/GUI display intent; executors ignore the extra key. Branch merged master (v0.2.52 + #863) and Agent.md count synced to 971.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3): re-reviewed head b1375e0 fresh. All 7 tool executors read args via .get() (extra intent key tolerated, never executed); daemon logs/broadcasts intent (tool call + memory reflection + consolidation); ToolStart carries intent; TUI card header + GUI tool-row show intent; system.j2 instructs agent to always write intent; purpose field fully removed from ToolDefinition with updated tests (protocol defaults, no-purpose guard, e2e stateful two-round mock verifies broadcast + executor). CI test + test-windows PASS (32211538781).

@pm25coder

Copy link
Copy Markdown
Collaborator

Independent test report (cycle 2026-08-19, Contributor):

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3): head b1375e0 unchanged since 2/3, CI test + test-windows PASS (32211538781), MERGEABLE/CLEAN. Fresh verification of the diff (21 files, +183/−41): intent required param on all 7 tools, purpose field removed, executors use .get() (intent never executed), daemon logs/broadcasts intent, TUI/GUI display, system.j2 instructs agent, e2e stateful mock asserts broadcast + execution. Approving for merge.

@argszero
argszero merged commit c67fa3e into masterAug 19, 2026
2 checks passed
@argszero
argszero deleted the feature/tool-intent branch August 19, 2026 03:28
argszero added a commit that referenced this pull request Aug 19, 2026
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@argszero@pm25coder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24) - #864

Merged
argszero merged 4 commits into
masterfrom
feature/tool-intent
Aug 19, 2026
Merged

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24)#864
argszero merged 4 commits into
masterfrom
feature/tool-intent

Conversation

@argszero

Copy link
Copy Markdown
Owner

Tool intent parameter replaces static purpose (host rants 10:33:29 + 10:35:24)

Host-finalized: every tool call should carry the agent's per-call intent ("why am I calling this, what do I want to achieve") instead of the static purpose field. Logs/GUI show the intent — real "doing X because of Y" readability.

Changes

  1. 7 tools (bash/edit/glob/grep/read/write/submit_rant) — added required intent string param to their JSON Schemas (properties + required); removed the static purpose=... lines.
  2. ToolDefinitionpurpose field + docstring removed (tool_types.py).
  3. Execution ignores intentintent is display-only metadata; the executors keep running on their real arguments (unknown keys are naturally ignored by arguments.get(...)).
  4. Daemon logging — 3 sites now log the intent:
    • main tool loop: tool call: <name> — <intent> (was — <purpose> (<redacted JSON>))
    • memory reflection + consolidation debug logs: same switch
    • intent missing (internal/LLM-free calls) → -
  5. tool_start broadcast — carries "intent": args.get("intent"); ToolStart protocol gains an intent field.
  6. TUI/GUI display — TUI ToolCard header shows intent when present (falls back to formatted args); GUI tool row shows an italic tool-intent span.
  7. Prompt guidancesystem.j2 Tool Usage section now instructs every tool call to include intent.

Tests

  • test_tool_types.py::test_no_purpose_field — ToolDefinition has no purpose
  • test_submit_rant_tool.pytest_all_tools_have_purposetest_all_tools_require_intent (all 7 tools require intent, no purpose); consent-contract test asserts intent required
  • test_protocol.py — ToolStart carries intent (and defaults "")
  • test_ws_e2e.py::test_tool_intent_logged_and_ignored_by_execution — daemon broadcasts intent in tool_start while the executor still runs on real args
  • Agent.md test count 967 → 969 (branch base; +2 net tests)

Verification

  • py_compile all touched Python ✓ · node --check chat.js
  • Mocked run: tool call: bash — 检查回显 / missing intent → tool call: bash — -
  • All 7 tool schemas: intent in properties + required, no purpose attr ✓

EMRG Evolution added 4 commits August 19, 2026 10:46
…to 971
- test_glob_tool / test_grep_tool: intent is now a required parameter
- merge master (v0.2.52 + #863) so PR CI covers full suite
- Agent.md test count 969 -> 971 (net +2 intent tests)
The mock put the finish_reason=stop delta in the same stream as the
tool call, so the daemon's Case-1 branch treated the round as a final
text answer and dropped the tool calls (no tool_start broadcast).
Follow the established _make_fake_chat_stream pattern: round 1 emits
the tool call (finish tool_calls), round 2 the final answer (stop).

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3): head b1375e0, CI test + test-windows PASS (32211538781). Tool intent required param on all 7 tools (purpose removed), ToolStart.intent broadcast, daemon tool-call logging shows intent, TUI/GUI display intent; executors ignore the extra key. Branch merged master (v0.2.52 + #863) and Agent.md count synced to 971.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3): re-reviewed head b1375e0 fresh. All 7 tool executors read args via .get() (extra intent key tolerated, never executed); daemon logs/broadcasts intent (tool call + memory reflection + consolidation); ToolStart carries intent; TUI card header + GUI tool-row show intent; system.j2 instructs agent to always write intent; purpose field fully removed from ToolDefinition with updated tests (protocol defaults, no-purpose guard, e2e stateful two-round mock verifies broadcast + executor). CI test + test-windows PASS (32211538781).

@pm25coder

Copy link
Copy Markdown
Collaborator

Independent test report (cycle 2026-08-19, Contributor):

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3): head b1375e0 unchanged since 2/3, CI test + test-windows PASS (32211538781), MERGEABLE/CLEAN. Fresh verification of the diff (21 files, +183/−41): intent required param on all 7 tools, purpose field removed, executors use .get() (intent never executed), daemon logs/broadcasts intent, TUI/GUI display, system.j2 instructs agent, e2e stateful mock asserts broadcast + execution. Approving for merge.

@argszero
argszero merged commit c67fa3e into masterAug 19, 2026
2 checks passed
@argszero
argszero deleted the feature/tool-intent branch August 19, 2026 03:28
argszero added a commit that referenced this pull request Aug 19, 2026
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@argszero@pm25coder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24) - #864

Merged
argszero merged 4 commits into
masterfrom
feature/tool-intent
Aug 19, 2026
Merged

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24)#864
argszero merged 4 commits into
masterfrom
feature/tool-intent

Conversation

@argszero

Copy link
Copy Markdown
Owner

Tool intent parameter replaces static purpose (host rants 10:33:29 + 10:35:24)

Host-finalized: every tool call should carry the agent's per-call intent ("why am I calling this, what do I want to achieve") instead of the static purpose field. Logs/GUI show the intent — real "doing X because of Y" readability.

Changes

  1. 7 tools (bash/edit/glob/grep/read/write/submit_rant) — added required intent string param to their JSON Schemas (properties + required); removed the static purpose=... lines.
  2. ToolDefinitionpurpose field + docstring removed (tool_types.py).
  3. Execution ignores intentintent is display-only metadata; the executors keep running on their real arguments (unknown keys are naturally ignored by arguments.get(...)).
  4. Daemon logging — 3 sites now log the intent:
    • main tool loop: tool call: <name> — <intent> (was — <purpose> (<redacted JSON>))
    • memory reflection + consolidation debug logs: same switch
    • intent missing (internal/LLM-free calls) → -
  5. tool_start broadcast — carries "intent": args.get("intent"); ToolStart protocol gains an intent field.
  6. TUI/GUI display — TUI ToolCard header shows intent when present (falls back to formatted args); GUI tool row shows an italic tool-intent span.
  7. Prompt guidancesystem.j2 Tool Usage section now instructs every tool call to include intent.

Tests

  • test_tool_types.py::test_no_purpose_field — ToolDefinition has no purpose
  • test_submit_rant_tool.pytest_all_tools_have_purposetest_all_tools_require_intent (all 7 tools require intent, no purpose); consent-contract test asserts intent required
  • test_protocol.py — ToolStart carries intent (and defaults "")
  • test_ws_e2e.py::test_tool_intent_logged_and_ignored_by_execution — daemon broadcasts intent in tool_start while the executor still runs on real args
  • Agent.md test count 967 → 969 (branch base; +2 net tests)

Verification

  • py_compile all touched Python ✓ · node --check chat.js
  • Mocked run: tool call: bash — 检查回显 / missing intent → tool call: bash — -
  • All 7 tool schemas: intent in properties + required, no purpose attr ✓

EMRG Evolution added 4 commits August 19, 2026 10:46
…to 971
- test_glob_tool / test_grep_tool: intent is now a required parameter
- merge master (v0.2.52 + #863) so PR CI covers full suite
- Agent.md test count 969 -> 971 (net +2 intent tests)
The mock put the finish_reason=stop delta in the same stream as the
tool call, so the daemon's Case-1 branch treated the round as a final
text answer and dropped the tool calls (no tool_start broadcast).
Follow the established _make_fake_chat_stream pattern: round 1 emits
the tool call (finish tool_calls), round 2 the final answer (stop).

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3): head b1375e0, CI test + test-windows PASS (32211538781). Tool intent required param on all 7 tools (purpose removed), ToolStart.intent broadcast, daemon tool-call logging shows intent, TUI/GUI display intent; executors ignore the extra key. Branch merged master (v0.2.52 + #863) and Agent.md count synced to 971.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3): re-reviewed head b1375e0 fresh. All 7 tool executors read args via .get() (extra intent key tolerated, never executed); daemon logs/broadcasts intent (tool call + memory reflection + consolidation); ToolStart carries intent; TUI card header + GUI tool-row show intent; system.j2 instructs agent to always write intent; purpose field fully removed from ToolDefinition with updated tests (protocol defaults, no-purpose guard, e2e stateful two-round mock verifies broadcast + executor). CI test + test-windows PASS (32211538781).

@pm25coder

Copy link
Copy Markdown
Collaborator

Independent test report (cycle 2026-08-19, Contributor):

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3): head b1375e0 unchanged since 2/3, CI test + test-windows PASS (32211538781), MERGEABLE/CLEAN. Fresh verification of the diff (21 files, +183/−41): intent required param on all 7 tools, purpose field removed, executors use .get() (intent never executed), daemon logs/broadcasts intent, TUI/GUI display, system.j2 instructs agent, e2e stateful mock asserts broadcast + execution. Approving for merge.

@argszero
argszero merged commit c67fa3e into masterAug 19, 2026
2 checks passed
@argszero
argszero deleted the feature/tool-intent branch August 19, 2026 03:28
argszero added a commit that referenced this pull request Aug 19, 2026
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@argszero@pm25coder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24) - #864

Merged
argszero merged 4 commits into
masterfrom
feature/tool-intent
Aug 19, 2026
Merged

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24)#864
argszero merged 4 commits into
masterfrom
feature/tool-intent

Conversation

@argszero

Copy link
Copy Markdown
Owner

Tool intent parameter replaces static purpose (host rants 10:33:29 + 10:35:24)

Host-finalized: every tool call should carry the agent's per-call intent ("why am I calling this, what do I want to achieve") instead of the static purpose field. Logs/GUI show the intent — real "doing X because of Y" readability.

Changes

  1. 7 tools (bash/edit/glob/grep/read/write/submit_rant) — added required intent string param to their JSON Schemas (properties + required); removed the static purpose=... lines.
  2. ToolDefinitionpurpose field + docstring removed (tool_types.py).
  3. Execution ignores intentintent is display-only metadata; the executors keep running on their real arguments (unknown keys are naturally ignored by arguments.get(...)).
  4. Daemon logging — 3 sites now log the intent:
    • main tool loop: tool call: <name> — <intent> (was — <purpose> (<redacted JSON>))
    • memory reflection + consolidation debug logs: same switch
    • intent missing (internal/LLM-free calls) → -
  5. tool_start broadcast — carries "intent": args.get("intent"); ToolStart protocol gains an intent field.
  6. TUI/GUI display — TUI ToolCard header shows intent when present (falls back to formatted args); GUI tool row shows an italic tool-intent span.
  7. Prompt guidancesystem.j2 Tool Usage section now instructs every tool call to include intent.

Tests

  • test_tool_types.py::test_no_purpose_field — ToolDefinition has no purpose
  • test_submit_rant_tool.pytest_all_tools_have_purposetest_all_tools_require_intent (all 7 tools require intent, no purpose); consent-contract test asserts intent required
  • test_protocol.py — ToolStart carries intent (and defaults "")
  • test_ws_e2e.py::test_tool_intent_logged_and_ignored_by_execution — daemon broadcasts intent in tool_start while the executor still runs on real args
  • Agent.md test count 967 → 969 (branch base; +2 net tests)

Verification

  • py_compile all touched Python ✓ · node --check chat.js
  • Mocked run: tool call: bash — 检查回显 / missing intent → tool call: bash — -
  • All 7 tool schemas: intent in properties + required, no purpose attr ✓

EMRG Evolution added 4 commits August 19, 2026 10:46
…to 971
- test_glob_tool / test_grep_tool: intent is now a required parameter
- merge master (v0.2.52 + #863) so PR CI covers full suite
- Agent.md test count 969 -> 971 (net +2 intent tests)
The mock put the finish_reason=stop delta in the same stream as the
tool call, so the daemon's Case-1 branch treated the round as a final
text answer and dropped the tool calls (no tool_start broadcast).
Follow the established _make_fake_chat_stream pattern: round 1 emits
the tool call (finish tool_calls), round 2 the final answer (stop).

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3): head b1375e0, CI test + test-windows PASS (32211538781). Tool intent required param on all 7 tools (purpose removed), ToolStart.intent broadcast, daemon tool-call logging shows intent, TUI/GUI display intent; executors ignore the extra key. Branch merged master (v0.2.52 + #863) and Agent.md count synced to 971.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3): re-reviewed head b1375e0 fresh. All 7 tool executors read args via .get() (extra intent key tolerated, never executed); daemon logs/broadcasts intent (tool call + memory reflection + consolidation); ToolStart carries intent; TUI card header + GUI tool-row show intent; system.j2 instructs agent to always write intent; purpose field fully removed from ToolDefinition with updated tests (protocol defaults, no-purpose guard, e2e stateful two-round mock verifies broadcast + executor). CI test + test-windows PASS (32211538781).

@pm25coder

Copy link
Copy Markdown
Collaborator

Independent test report (cycle 2026-08-19, Contributor):

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3): head b1375e0 unchanged since 2/3, CI test + test-windows PASS (32211538781), MERGEABLE/CLEAN. Fresh verification of the diff (21 files, +183/−41): intent required param on all 7 tools, purpose field removed, executors use .get() (intent never executed), daemon logs/broadcasts intent, TUI/GUI display, system.j2 instructs agent, e2e stateful mock asserts broadcast + execution. Approving for merge.

@argszero
argszero merged commit c67fa3e into masterAug 19, 2026
2 checks passed
@argszero
argszero deleted the feature/tool-intent branch August 19, 2026 03:28
argszero added a commit that referenced this pull request Aug 19, 2026
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@argszero@pm25coder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24) - #864

Merged
argszero merged 4 commits into
masterfrom
feature/tool-intent
Aug 19, 2026
Merged

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24)#864
argszero merged 4 commits into
masterfrom
feature/tool-intent

Conversation

@argszero

Copy link
Copy Markdown
Owner

Tool intent parameter replaces static purpose (host rants 10:33:29 + 10:35:24)

Host-finalized: every tool call should carry the agent's per-call intent ("why am I calling this, what do I want to achieve") instead of the static purpose field. Logs/GUI show the intent — real "doing X because of Y" readability.

Changes

  1. 7 tools (bash/edit/glob/grep/read/write/submit_rant) — added required intent string param to their JSON Schemas (properties + required); removed the static purpose=... lines.
  2. ToolDefinitionpurpose field + docstring removed (tool_types.py).
  3. Execution ignores intentintent is display-only metadata; the executors keep running on their real arguments (unknown keys are naturally ignored by arguments.get(...)).
  4. Daemon logging — 3 sites now log the intent:
    • main tool loop: tool call: <name> — <intent> (was — <purpose> (<redacted JSON>))
    • memory reflection + consolidation debug logs: same switch
    • intent missing (internal/LLM-free calls) → -
  5. tool_start broadcast — carries "intent": args.get("intent"); ToolStart protocol gains an intent field.
  6. TUI/GUI display — TUI ToolCard header shows intent when present (falls back to formatted args); GUI tool row shows an italic tool-intent span.
  7. Prompt guidancesystem.j2 Tool Usage section now instructs every tool call to include intent.

Tests

  • test_tool_types.py::test_no_purpose_field — ToolDefinition has no purpose
  • test_submit_rant_tool.pytest_all_tools_have_purposetest_all_tools_require_intent (all 7 tools require intent, no purpose); consent-contract test asserts intent required
  • test_protocol.py — ToolStart carries intent (and defaults "")
  • test_ws_e2e.py::test_tool_intent_logged_and_ignored_by_execution — daemon broadcasts intent in tool_start while the executor still runs on real args
  • Agent.md test count 967 → 969 (branch base; +2 net tests)

Verification

  • py_compile all touched Python ✓ · node --check chat.js
  • Mocked run: tool call: bash — 检查回显 / missing intent → tool call: bash — -
  • All 7 tool schemas: intent in properties + required, no purpose attr ✓

EMRG Evolution added 4 commits August 19, 2026 10:46
…to 971
- test_glob_tool / test_grep_tool: intent is now a required parameter
- merge master (v0.2.52 + #863) so PR CI covers full suite
- Agent.md test count 969 -> 971 (net +2 intent tests)
The mock put the finish_reason=stop delta in the same stream as the
tool call, so the daemon's Case-1 branch treated the round as a final
text answer and dropped the tool calls (no tool_start broadcast).
Follow the established _make_fake_chat_stream pattern: round 1 emits
the tool call (finish tool_calls), round 2 the final answer (stop).

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3): head b1375e0, CI test + test-windows PASS (32211538781). Tool intent required param on all 7 tools (purpose removed), ToolStart.intent broadcast, daemon tool-call logging shows intent, TUI/GUI display intent; executors ignore the extra key. Branch merged master (v0.2.52 + #863) and Agent.md count synced to 971.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3): re-reviewed head b1375e0 fresh. All 7 tool executors read args via .get() (extra intent key tolerated, never executed); daemon logs/broadcasts intent (tool call + memory reflection + consolidation); ToolStart carries intent; TUI card header + GUI tool-row show intent; system.j2 instructs agent to always write intent; purpose field fully removed from ToolDefinition with updated tests (protocol defaults, no-purpose guard, e2e stateful two-round mock verifies broadcast + executor). CI test + test-windows PASS (32211538781).

@pm25coder

Copy link
Copy Markdown
Collaborator

Independent test report (cycle 2026-08-19, Contributor):

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3): head b1375e0 unchanged since 2/3, CI test + test-windows PASS (32211538781), MERGEABLE/CLEAN. Fresh verification of the diff (21 files, +183/−41): intent required param on all 7 tools, purpose field removed, executors use .get() (intent never executed), daemon logs/broadcasts intent, TUI/GUI display, system.j2 instructs agent, e2e stateful mock asserts broadcast + execution. Approving for merge.

@argszero
argszero merged commit c67fa3e into masterAug 19, 2026
2 checks passed
@argszero
argszero deleted the feature/tool-intent branch August 19, 2026 03:28
argszero added a commit that referenced this pull request Aug 19, 2026
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@argszero@pm25coder
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24) - #864

Merged
argszero merged 4 commits into
masterfrom
feature/tool-intent
Aug 19, 2026
Merged

emrg: tool intent parameter replaces static purpose (rants 10:33:29 + 10:35:24)#864
argszero merged 4 commits into
masterfrom
feature/tool-intent

Conversation

@argszero

Copy link
Copy Markdown
Owner

Tool intent parameter replaces static purpose (host rants 10:33:29 + 10:35:24)

Host-finalized: every tool call should carry the agent's per-call intent ("why am I calling this, what do I want to achieve") instead of the static purpose field. Logs/GUI show the intent — real "doing X because of Y" readability.

Changes

  1. 7 tools (bash/edit/glob/grep/read/write/submit_rant) — added required intent string param to their JSON Schemas (properties + required); removed the static purpose=... lines.
  2. ToolDefinitionpurpose field + docstring removed (tool_types.py).
  3. Execution ignores intentintent is display-only metadata; the executors keep running on their real arguments (unknown keys are naturally ignored by arguments.get(...)).
  4. Daemon logging — 3 sites now log the intent:
    • main tool loop: tool call: <name> — <intent> (was — <purpose> (<redacted JSON>))
    • memory reflection + consolidation debug logs: same switch
    • intent missing (internal/LLM-free calls) → -
  5. tool_start broadcast — carries "intent": args.get("intent"); ToolStart protocol gains an intent field.
  6. TUI/GUI display — TUI ToolCard header shows intent when present (falls back to formatted args); GUI tool row shows an italic tool-intent span.
  7. Prompt guidancesystem.j2 Tool Usage section now instructs every tool call to include intent.

Tests

  • test_tool_types.py::test_no_purpose_field — ToolDefinition has no purpose
  • test_submit_rant_tool.pytest_all_tools_have_purposetest_all_tools_require_intent (all 7 tools require intent, no purpose); consent-contract test asserts intent required
  • test_protocol.py — ToolStart carries intent (and defaults "")
  • test_ws_e2e.py::test_tool_intent_logged_and_ignored_by_execution — daemon broadcasts intent in tool_start while the executor still runs on real args
  • Agent.md test count 967 → 969 (branch base; +2 net tests)

Verification

  • py_compile all touched Python ✓ · node --check chat.js
  • Mocked run: tool call: bash — 检查回显 / missing intent → tool call: bash — -
  • All 7 tool schemas: intent in properties + required, no purpose attr ✓

EMRG Evolution added 4 commits August 19, 2026 10:46
…to 971
- test_glob_tool / test_grep_tool: intent is now a required parameter
- merge master (v0.2.52 + #863) so PR CI covers full suite
- Agent.md test count 969 -> 971 (net +2 intent tests)
The mock put the finish_reason=stop delta in the same stream as the
tool call, so the daemon's Case-1 branch treated the round as a final
text answer and dropped the tool calls (no tool_start broadcast).
Follow the established _make_fake_chat_stream pattern: round 1 emits
the tool call (finish tool_calls), round 2 the final answer (stop).

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (1/3): head b1375e0, CI test + test-windows PASS (32211538781). Tool intent required param on all 7 tools (purpose removed), ToolStart.intent broadcast, daemon tool-call logging shows intent, TUI/GUI display intent; executors ignore the extra key. Branch merged master (v0.2.52 + #863) and Agent.md count synced to 971.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3): re-reviewed head b1375e0 fresh. All 7 tool executors read args via .get() (extra intent key tolerated, never executed); daemon logs/broadcasts intent (tool call + memory reflection + consolidation); ToolStart carries intent; TUI card header + GUI tool-row show intent; system.j2 instructs agent to always write intent; purpose field fully removed from ToolDefinition with updated tests (protocol defaults, no-purpose guard, e2e stateful two-round mock verifies broadcast + executor). CI test + test-windows PASS (32211538781).

@pm25coder

Copy link
Copy Markdown
Collaborator

Independent test report (cycle 2026-08-19, Contributor):

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3): head b1375e0 unchanged since 2/3, CI test + test-windows PASS (32211538781), MERGEABLE/CLEAN. Fresh verification of the diff (21 files, +183/−41): intent required param on all 7 tools, purpose field removed, executors use .get() (intent never executed), daemon logs/broadcasts intent, TUI/GUI display, system.j2 instructs agent, e2e stateful mock asserts broadcast + execution. Approving for merge.

@argszero
argszero merged commit c67fa3e into masterAug 19, 2026
2 checks passed
@argszero
argszero deleted the feature/tool-intent branch August 19, 2026 03:28
argszero added a commit that referenced this pull request Aug 19, 2026
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@argszero@pm25coder