emrg: remove scheduler workspace self-heal + origin probe + evolution-log archival (rants 14:16/14:18/14:20) - #869
Merged
Conversation
…-log archival (rants 14:16/14:18/14:20)
argszero
commented
Aug 19, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle. CI test + test-windows PASS (run 32223576427); deletions complete with no residual refs (subprocess/win32_no_window_kwargs/git_origin_url/https_to_ssh/is_git_connection_error/INSTALL_INFO all removed); _ensure_self_evolution_task + EVOLUTION_CWD correctly kept; suite 963 collected (962 passed + 1 skipped).
argszero
commented
Aug 19, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle. CI test + test-windows PASS (rerun 32225463117 after a transient Windows-runner hang); head unchanged; deletions complete with no residual refs.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 19, 2026
argszero added a commit
that referenced
this pull request
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three host-mandated deletions (rants 2026-08-19T14:16:15 / 14:18:40 / 14:20:52) — remove scheduler-side git workspace machinery and disk archival that the agent no longer needs.
1.
_ensure_origin_reachabledeleted (rant 14:16:15)The https→SSH origin probe is useless in a fully network-blocked environment and its unbounded
git ls-remotetimeout (15s,TimeoutExpireduncaught) crashed cycles._clone_workspacealready had its own https→SSH retry (#858), making the origin switch redundant._origin_probedstate +git_origin_urlimport.2.
_write_evolution_logdeleted (rant 14:18:40)Disk archival of
evolution-<ts>.json(with 27-file rotation) was never consumed: GUI recent-runs andevolution_countboth read the in-memoryself.evolutionslist. The cycle now only appends to the in-memory list._write_final_summary(summary.json) kept per host evaluation.3. Workspace self-heal family deleted (rant 14:20:52)
Git workspace management (clone / tag-align / git identity / projects.yml self-heal) belongs to the agent via its tools, not the scheduler — it was also a crash source when git timed out on a blocked network.
_ensure_evolution_workspace,_clone_workspace,_align_to_installed_version,_ensure_git_identity,_is_usable_git_repo,_repo_url_from_install_info,_ensure_project_entry, plus the_run_evolution_cycleworkspace check (cycle now goes straight to prompt build / daemon connect)._ensure_self_evolution_task(ensures the emrg task exists — not git management),EVOLUTION_CWD(used by it + prompt context),_source_dir,_detect_git_remote/owner-repo resolution (task config + prompt{repo}context).subprocess,win32_no_window_kwargs,INSTALL_INFO,git_origin_url,https_to_ssh_url,is_git_connection_error,no_prompt_envall removed from scheduler.py.Tests
FakeGitRunhelper.test_task_handler_no_repo_skips_self_heal(asserts default source_dir now),test_saturation_heartbeat_makes_no_network_calls(asserts scheduler no longer imports subprocess at all)._make_cycle_handlercaptures the cycle log via a lazy proxy tohandler.evolutions(in-memory list) — all 12 cycle tests unchanged in behavior.