Inf fix - #218
Conversation
arokem
commented
Sep 18, 2015
Could you please try rebasing this on top of master, to see whether tests work with the addition of #219 ? |
arokem
commented
Sep 21, 2015
Sorry for the delay in looking at all this. It looks generally good to me. A few concerns:
|
Only compiled for mexa64. Also, miscelaneous PEP8 and doc updates and logging now includes _Session output.
brunobeltran
commented
Sep 21, 2015
No worries on the delay. I'll get to work on writing some tests, but the updates on master seem to have broken my build; I'm getting I'll have to look into this. |
arokem
commented
Sep 21, 2015
Did you rebuild the messenger after updating? On Mon, Sep 21, 2015 at 2:42 PM, Bruno Beltran notifications@github.com
|
brunobeltran
commented
Sep 21, 2015
oh wait, so I realize what happened. I replaced $matlabpath/sys/os/glnxa64/libstdc++.so that MATLAB ships with with a modern, working version of libc as a workaround for unrelated issues ages ago. So the fact that it is currently failing to build on my computer probably has to do with the fact that I reinstaled matlab, not with me rebasing on master. On the other hand, how did you get this working on Linux previously? In its current state, a new libzmq should always complain when it tries to start in an environment with LD_LIBRARY_PATH set to point to matlab's old, broken glibc++. On the other hand, starting matlab without all the libraries it normally ships with in its modified LD_LIBRARY_PATH breaks matlab on my system for every version from 2013a to 2015b. Thoughts? |
brunobeltran
commented
Sep 21, 2015
should I have rebuilt? I thought the whole point of the update was for the mex file to work on Ubuntu? |
arokem
commented
Sep 21, 2015
Not sure. I am still trying to digest your previous message. On Mon, Sep 21, 2015 at 2:51 PM, Bruno Beltran notifications@github.com
|
brunobeltran
commented
Sep 21, 2015
I probably wasn't very clear. Specifically, the problem I have with the current setup is that, even before any of my changes, if I build the messenger myself and put everything in the "right" place, then I get the following error: This error is due to MATLAB shipping with an ancient version of libc, and is simply resolved by symlinking the file However, this is strangely not necessary if I use one of your old messenger.mex files. I am guessing this was worked around before by building the messenger statically? |
brunobeltran
commented
Sep 21, 2015
Sorry for the quadruple-comment, been running around a lot today. So I guess after getting back to my laptop it seems like the update works after rebasing, then again, that's mostly because my version of the messenger has overwritten yours after rebasing, so Travis is still failing. Any pointers on how to build the messenger so that Travis doesn't get so upset? |
Fixes#210, based on branch with changes for separating Matlab from session.