Skip to content

Fix checkstyle - #3

Merged
aromanenko-dev merged 1 commit into
aromanenko-dev:BEAM-2852-nexmark-kafka-source-sinkfrom
echauchot:fix_pr_5019
Apr 5, 2018
Merged

Fix checkstyle#3
aromanenko-dev merged 1 commit into
aromanenko-dev:BEAM-2852-nexmark-kafka-source-sinkfrom
echauchot:fix_pr_5019

Conversation

@echauchot

Copy link
Copy Markdown

DESCRIPTION HERE


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@echauchot

Copy link
Copy Markdown
Author

R: @aromanenko-dev

@aromanenko-dev
aromanenko-dev merged commit 2e744e5 into aromanenko-dev:BEAM-2852-nexmark-kafka-source-sinkApr 5, 2018
@aromanenko-dev

Copy link
Copy Markdown
Owner

@echauchot thanks!

@echauchot
echauchot deleted the fix_pr_5019 branch May 14, 2018 09:09
aromanenko-dev pushed a commit that referenced this pull request Jul 10, 2018
* Update Schema.java
The type sets are final mutable types, but with immutable implementations. This doesn't communicate the desired semantic guarantees of the immutable implementation.
* Remove unneeded collection import.
aromanenko-dev pushed a commit that referenced this pull request Oct 22, 2018
aromanenko-dev pushed a commit that referenced this pull request Mar 2, 2020
update fork 3rd Dec 2019, 14:55PM
aromanenko-dev pushed a commit that referenced this pull request Mar 19, 2021
Debeziumio PoC (apache#7)
* New DebeziumIO class.
* Merge connector code
* DebeziumIO and MySqlConnector integrated.
* Added FormatFuntion param to Read builder on DebeziumIO.
* Added arguments checker to DebeziumIO.
* Add simple JSON mapper object (#1)
* Add simple JSON mapper object
* Fixed Mapper.
* Add SqlServer connector test
* Added PostgreSql Connector Test
PostgreSql now works with Json mapper
* Added PostgreSql Connector Test
PostgreSql now works with Json mapper
* Fixing MySQL schema DataException
Using file instead of schema should fix it
* MySQL Connector updated from 1.3.0 to 1.3.1
Co-authored-by: osvaldo-salinas <osvaldo.salinas@wizeline.com>
Co-authored-by: Carlos Dominguez <carlos.dominguez@carlos.dominguez>
Co-authored-by: Carlos Domínguez <carlos.dominguez@wizeline.com>
* Add debeziumio tests
* Debeziumio testing json mapper (#3)
* Some code refactors. Use a default DBHistory if not provided
* Add basic tests for Json mapper
* Debeziumio time restriction (#5)
* Add simple JSON mapper object
* Fixed Mapper.
* Add SqlServer connector test
* Added PostgreSql Connector Test
PostgreSql now works with Json mapper
* Added PostgreSql Connector Test
PostgreSql now works with Json mapper
* Fixing MySQL schema DataException
Using file instead of schema should fix it
* MySQL Connector updated from 1.3.0 to 1.3.1
* Some code refactors. Use a default DBHistory if not provided
* Adding based-time restriction
Stop polling after specified amount of time
* Add basic tests for Json mapper
* Adding new restriction
Uses a time-based restriction
* Adding optional restrcition
Uses an optional time-based restriction
Co-authored-by: juanitodread <juanitodread@gmail.com>
Co-authored-by: osvaldo-salinas <osvaldo.salinas@wizeline.com>
* Upgrade DebeziumIO connector (#4)
* Address comments (Change dependencies to testCompile, Set JsonMapper/Coder as default, refactors) (apache#8)
* Revert file
* Change dependencies to testCompile
* Move Counter sample to unit test
* Set JsonMapper as default mapper function
* Set String Coder as default coder when using JsonMapper
* Change logs from info to debug
* Debeziumio javadoc (apache#9)
* Adding javadoc
* Added some titles and examples
* Added SourceRecordJson doc
* Added Basic Connector doc
* Added KafkaSourceConsumer doc
* Javadoc cleanup
* Removing BasicConnector
No usages of this class were found overall
* Editing documentation
* Debeziumio fetched records restriction (apache#10)
* Adding javadoc
* Adding restriction by number of fetched records
Also adding a quick-fix for null value within SourceRecords
Minor fix on both MySQL and PostgreSQL Connectors Tests
* Run either by time or by number of records
* Added DebeziumOffsetTrackerTest
Tests both restrictions: By amount of time and by Number of records
* Removing comment
* DebeziumIO test for DB2. (apache#11)
* DebeziumIO test for DB2.
* DebeziumIO javadoc.
* Clean code:removed commented code lines on DebeziumIOConnectorTest.java
* Clean code:removing unused imports and using readAsJson().
Co-authored-by: Carlos Domínguez <74681048+carlosdominguezwl@users.noreply.github.com>
* Debezium limit records (now configurable) (apache#12)
* Adding javadoc
* Records Limit is now configurable
(It was fixed before)
* Debeziumio dockerize (apache#13)
* Add mysql docker container to tests
* Move debezium mysql integration test to its own file
* Add assertion to verify that the results contains a record.
* Debeziumio readme (apache#15)
* Adding javadoc
* Adding README file
* Add number of records configuration to the DebeziumIO component (apache#16)
* Code refactors (apache#17)
* Remove/ignore null warnings
* Remove DB2 code
* Remove docker dependency in DebeziumIO unit test and max number of recods to MySql integration test
* Change access modifiers accordingly
* Remove incomplete integration tests (Postgres and SqlServer)
* Add experimenal tag
* Debezium testing stoppable consumer (apache#18)
* Add try-catch-finally, stop SourceTask at finally.
* Fix warnings
* stopConsumer and processedRecords local variables removed. UT for task stop use case added
* Fix minor code style issue
Co-authored-by: juanitodread <juanitodread@gmail.com>
* Fix style issues (check, spotlessApply) (apache#19)
Co-authored-by: Osvaldo Salinas <osvaldo.salinas@osvaldo.salinas>
Co-authored-by: alejandro.maguey <alejandro.maguey@wizeline.com>
Co-authored-by: osvaldo-salinas <osvaldo.salinas@wizeline.com>
Co-authored-by: Carlos Dominguez <carlos.dominguez@carlos.dominguez>
Co-authored-by: Carlos Domínguez <carlos.dominguez@wizeline.com>
Co-authored-by: Carlos Domínguez <74681048+carlosdominguezwl@users.noreply.github.com>
Co-authored-by: Alejandro Maguey <alexmaguey1@gmail.com>
Co-authored-by: Hassan Reyes <hassanreyes@users.noreply.github.com>
Add missing apache license to README.md
Enabling integration test for DebeziumIO (apache#20)
Rename connector package cdc=>debezium. Update doc references (apache#21)
Fix code style on DebeziumIOMySqlConnectorIT
aromanenko-dev pushed a commit that referenced this pull request Jun 3, 2021
…at streams data from twitter
* # This is a combination of 2 commits.
# This is the 1st commit message:
Java PreCommit failure fix
spotless failure fix
Java PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit refix
Java_Examples_Dataflow PreCommit fix
build failure corrected
Spotless check
Spotless check
reorganizing pipeline
delete the unused folder
Revert "Delete build.gradle"
This reverts commit c39a4e44
Delete build.gradle
don't need this file
adding comments and java docs, and removing unneeded dependencies.
Linting the project and making some stuff private
Reorganized and redefined to logic as per standard beam IO structure.
Lint the files.
Added changes for making the implementation more streamlined and understandable
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
# This is a combination of 15 commits.
# This is the 1st commit message:
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
Added changes for making the implementation more streamlined and understandable
# This is the commit message #3:
Lint the files.
# This is the commit message #4:
Reorganized and redefined to logic as per standard beam IO structure.
# This is the commit message #5:
Linting the project and making some stuff private
# This is the commit message apache#6:
adding comments and java docs, and removing unneeded dependencies.
# This is the commit message apache#7:
delete the unused folder
# This is the commit message apache#8:
reorganizing pipeline
# This is the commit message apache#9:
Spotless check
# This is the commit message apache#10:
Spotless check
# This is the commit message apache#11:
build failure corrected
# This is the commit message apache#12:
Java_Examples_Dataflow PreCommit fix
# This is the commit message apache#13:
Java_Examples_Dataflow PreCommit refix
# This is the commit message apache#14:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#15:
Java_Examples_Dataflow PreCommit assign nullable correctly
* # This is a combination of 2 commits.
# This is the 1st commit message:
# This is a combination of 2 commits.
# This is the 1st commit message:
Java PreCommit failure fix
spotless failure fix
Java PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit refix
Java_Examples_Dataflow PreCommit fix
build failure corrected
Spotless check
Spotless check
reorganizing pipeline
delete the unused folder
Revert "Delete build.gradle"
This reverts commit c39a4e44
Delete build.gradle
don't need this file
adding comments and java docs, and removing unneeded dependencies.
Linting the project and making some stuff private
Reorganized and redefined to logic as per standard beam IO structure.
Lint the files.
Added changes for making the implementation more streamlined and understandable
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
# This is a combination of 15 commits.
# This is the 1st commit message:
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
Added changes for making the implementation more streamlined and understandable
# This is the commit message #3:
Lint the files.
# This is the commit message #4:
Reorganized and redefined to logic as per standard beam IO structure.
# This is the commit message #5:
Linting the project and making some stuff private
# This is the commit message apache#6:
adding comments and java docs, and removing unneeded dependencies.
# This is the commit message apache#7:
delete the unused folder
# This is the commit message apache#8:
reorganizing pipeline
# This is the commit message apache#9:
Spotless check
# This is the commit message apache#10:
Spotless check
# This is the commit message apache#11:
build failure corrected
# This is the commit message apache#12:
Java_Examples_Dataflow PreCommit fix
# This is the commit message apache#13:
Java_Examples_Dataflow PreCommit refix
# This is the commit message apache#14:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#15:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message #2:
# This is a combination of 3 commits.
# This is the 1st commit message:
Java PreCommit failure fix
spotless failure fix
Java PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit refix
Java_Examples_Dataflow PreCommit fix
build failure corrected
Spotless check
Spotless check
reorganizing pipeline
delete the unused folder
Revert "Delete build.gradle"
This reverts commit c39a4e44
Delete build.gradle
don't need this file
adding comments and java docs, and removing unneeded dependencies.
Linting the project and making some stuff private
Reorganized and redefined to logic as per standard beam IO structure.
Lint the files.
Added changes for making the implementation more streamlined and understandable
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
# This is a combination of 15 commits.
# This is the 1st commit message:
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
Added changes for making the implementation more streamlined and understandable
# This is the commit message #3:
Lint the files.
# This is the commit message #4:
Reorganized and redefined to logic as per standard beam IO structure.
# This is the commit message #5:
Linting the project and making some stuff private
# This is the commit message apache#6:
adding comments and java docs, and removing unneeded dependencies.
# This is the commit message apache#7:
delete the unused folder
# This is the commit message apache#8:
reorganizing pipeline
# This is the commit message apache#9:
Spotless check
# This is the commit message apache#10:
Spotless check
# This is the commit message apache#11:
build failure corrected
# This is the commit message apache#12:
Java_Examples_Dataflow PreCommit fix
# This is the commit message apache#13:
Java_Examples_Dataflow PreCommit refix
# This is the commit message apache#14:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#15:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message #3:
# This is a combination of 16 commits.
# This is the 1st commit message:
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
Added changes for making the implementation more streamlined and understandable
# This is the commit message #3:
Lint the files.
# This is the commit message #4:
Reorganized and redefined to logic as per standard beam IO structure.
# This is the commit message #5:
Linting the project and making some stuff private
# This is the commit message apache#6:
adding comments and java docs, and removing unneeded dependencies.
# This is the commit message apache#7:
delete the unused folder
# This is the commit message apache#8:
reorganizing pipeline
# This is the commit message apache#9:
Spotless check
# This is the commit message apache#10:
Spotless check
# This is the commit message apache#11:
build failure corrected
# This is the commit message apache#12:
Java_Examples_Dataflow PreCommit fix
# This is the commit message apache#13:
Java_Examples_Dataflow PreCommit refix
# This is the commit message apache#14:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#15:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#16:
Java PreCommit assign nullable correctly
Java PreCommit assign nullable correctly
spotless failure fix
Java PreCommit failure fix
correcting the if checks
cleaning up and adding readme
spotless fixed
readme fixed and compileJava
fix
compileJava fix
compileJava fix now
spotless fix now
Java PreCommi fix
Java PreCommit fix
# This is a combination of 16 commits.
# This is the 1st commit message:
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
Added changes for making the implementation more streamlined and understandable
# This is the commit message #3:
Lint the files.
# This is the commit message #4:
Reorganized and redefined to logic as per standard beam IO structure.
# This is the commit message #5:
Linting the project and making some stuff private
# This is the commit message apache#6:
adding comments and java docs, and removing unneeded dependencies.
# This is the commit message apache#7:
delete the unused folder
# This is the commit message apache#8:
reorganizing pipeline
# This is the commit message apache#9:
Spotless check
# This is the commit message apache#10:
Spotless check
# This is the commit message apache#11:
build failure corrected
# This is the commit message apache#12:
Java_Examples_Dataflow PreCommit fix
# This is the commit message apache#13:
Java_Examples_Dataflow PreCommit refix
# This is the commit message apache#14:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#15:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#16:
Java PreCommit assign nullable correctly
Java PreCommit assign nullable correctly
spotless failure fix
Java PreCommit failure fix
correcting the if checks
cleaning up and adding readme
spotless fixed
readme fixed and compileJava
fix
compileJava fix
compileJava fix now
spotless fix now
Java PreCommi fix
Java PreCommit fix
# This is a combination of 3 commits.
# This is the 1st commit message:
Java PreCommit failure fix
spotless failure fix
Java PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit assign nullable correctly
Java_Examples_Dataflow PreCommit refix
Java_Examples_Dataflow PreCommit fix
build failure corrected
Spotless check
Spotless check
reorganizing pipeline
delete the unused folder
Revert "Delete build.gradle"
This reverts commit c39a4e44
Delete build.gradle
don't need this file
adding comments and java docs, and removing unneeded dependencies.
Linting the project and making some stuff private
Reorganized and redefined to logic as per standard beam IO structure.
Lint the files.
Added changes for making the implementation more streamlined and understandable
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
# This is a combination of 15 commits.
# This is the 1st commit message:
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
Added changes for making the implementation more streamlined and understandable
# This is the commit message #3:
Lint the files.
# This is the commit message #4:
Reorganized and redefined to logic as per standard beam IO structure.
# This is the commit message #5:
Linting the project and making some stuff private
# This is the commit message apache#6:
adding comments and java docs, and removing unneeded dependencies.
# This is the commit message apache#7:
delete the unused folder
# This is the commit message apache#8:
reorganizing pipeline
# This is the commit message apache#9:
Spotless check
# This is the commit message apache#10:
Spotless check
# This is the commit message apache#11:
build failure corrected
# This is the commit message apache#12:
Java_Examples_Dataflow PreCommit fix
# This is the commit message apache#13:
Java_Examples_Dataflow PreCommit refix
# This is the commit message apache#14:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#15:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message #3:
# This is a combination of 16 commits.
# This is the 1st commit message:
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
Added changes for making the implementation more streamlined and understandable
# This is the commit message #3:
Lint the files.
# This is the commit message #4:
Reorganized and redefined to logic as per standard beam IO structure.
# This is the commit message #5:
Linting the project and making some stuff private
# This is the commit message apache#6:
adding comments and java docs, and removing unneeded dependencies.
# This is the commit message apache#7:
delete the unused folder
# This is the commit message apache#8:
reorganizing pipeline
# This is the commit message apache#9:
Spotless check
# This is the commit message apache#10:
Spotless check
# This is the commit message apache#11:
build failure corrected
# This is the commit message apache#12:
Java_Examples_Dataflow PreCommit fix
# This is the commit message apache#13:
Java_Examples_Dataflow PreCommit refix
# This is the commit message apache#14:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#15:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#16:
Java PreCommit assign nullable correctly
Java PreCommit assign nullable correctly
spotless failure fix
Java PreCommit failure fix
correcting the if checks
cleaning up and adding readme
spotless fixed
readme fixed and compileJava
fix
compileJava fix
compileJava fix now
spotless fix now
Java PreCommi fix
Java PreCommit fix
# This is a combination of 16 commits.
# This is the 1st commit message:
Added a connector that streams data from twitter using a Standard Twitter app.
# This is the commit message #2:
Added changes for making the implementation more streamlined and understandable
# This is the commit message #3:
Lint the files.
# This is the commit message #4:
Reorganized and redefined to logic as per standard beam IO structure.
# This is the commit message #5:
Linting the project and making some stuff private
# This is the commit message apache#6:
adding comments and java docs, and removing unneeded dependencies.
# This is the commit message apache#7:
delete the unused folder
# This is the commit message apache#8:
reorganizing pipeline
# This is the commit message apache#9:
Spotless check
# This is the commit message apache#10:
Spotless check
# This is the commit message apache#11:
build failure corrected
# This is the commit message apache#12:
Java_Examples_Dataflow PreCommit fix
# This is the commit message apache#13:
Java_Examples_Dataflow PreCommit refix
# This is the commit message apache#14:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#15:
Java_Examples_Dataflow PreCommit assign nullable correctly
# This is the commit message apache#16:
Java PreCommit assign nullable correctly
Java PreCommit assign nullable correctly
spotless failure fix
Java PreCommit failure fix
correcting the if checks
cleaning up and adding readme
spotless fixed
readme fixed and compileJava
fix
compileJava fix
compileJava fix now
spotless fix now
Java PreCommi fix
Java PreCommit fix
Final Commit with all changes
Added unit test
adding examples for usage
usage for TwitterIO added and Java PreCommit failure fix
Spotless PreCommit failure fix
* Unit test for multiple config added, and beautification
* Spotless apply fixed
* Removing redundant comments
* Removing newly added test
* adding newly added test back
aromanenko-dev pushed a commit that referenced this pull request Jan 27, 2022
Adds ReadChangeStreamPartitionDoFn, which is an SDF to read partitions
from change streams and process them accordingly. This component
receives a change stream name, a partition, a start time and an end time
to query. It then initiates a change stream query with the received
parameters.
Within a change stream, 3 types of records can be received:
1. A Data record
2. A Heartbeat record
3. A Child partitions record
Upon receiving #1, the function updates the watermark with the record's
commit timestamp and emits the record into the output PCollection.
Upon receiving #2, the function updates the watermark with the record's
timestamp, but it does not emit any record into the PCollection.
Upon receiving #3, the function updates the watermark with the record's
timestamp and writes the new child partitions into the metadata table.
These partitions will be later scheduled by the DetectNewPartitions
component.
Once the change stream query for the element partition finishes, it
marks the partition as finished in the metadata table and terminates.
aromanenko-dev pushed a commit that referenced this pull request May 16, 2022
add build and clean script to compile ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@echauchot@aromanenko-dev