This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add prebuild Electron for arm64 - #319
Merged
Merged
Conversation
Contributor
|
@dennisameling thanks for submitting this. The changes looks straight-forward, and it's neat that this support is already there in I'm going to look at addressing this as well as #317 in the next update, hopefully this week. I'll let you know if I have any questions or feedback about it. |
3 tasks
4 tasks
shiftkey
approved these changes
Nov 8, 2020
shiftkey
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution @dennisameling!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
Currently, including keytar as a dependency results in the following error on Windows arm64:
Related issue: #297
Description of the Change
This PR adds prebuilds for Electron on arm64, which solved the issue for me when trying locally and adding Keytar through
yarn link keytar(while trying to add support for arm64 to GitHub Desktop desktop/desktop#9691)Alternate Designs
Possible Drawbacks
Verification Process
Release Notes