This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Update binding.gyp to fix "napi.h not found" error - #325
Merged
Conversation
shiftkey
approved these changes
Nov 15, 2020
shiftkey
left a comment
Contributor
There was a problem hiding this comment.
Great find! Thanks for the contribution @dennisameling!
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #297
For some reason, the @ in
<!@(node -p \"require('node-addon-api').include\")causesnode-gyp rebuildto fail with:This PR fixes this problem by changing
include_dirsto the value that is indicated innode-addon-api's official docs: https://github.com/nodejs/node-addon-api/blob/master/doc/setup.md#installation-and-usageWhile #319 fixed arm64 builds on Windows by adding prebuilds for Electron (which works around the issue), it doesn't actually fix the scenario for native (re)compilation. This PR does. 🚀