Replace the ducktape dependency with zero deps - #1
Closed
austince wants to merge 1 commit into
Closed
Conversation
austinceforce-pushed
the
replace-ducttape-no-deps-2
branch
from
May 19, 2026 21:23
d2bca21 to
918c3c9CompareRemoves the dependency on org.rnorth.duct-tape:duct-tape:1.0.8 by re-implementing the small subset of duct-tape used by Testcontainers inside org.testcontainers.utility. No new runtime dependencies are introduced. Internal package additions (org.testcontainers.utility): - RateLimiter (abstract class) + RateLimiterBuilder: sleep-based pacing with constant-throughput strategy. Method names doWhenReady/getWhenReady match the historical duct-tape API so existing TC source-compat is preserved. - Timeouts.getWithTimeout / doWithTimeout: per-call ExecutorService with daemon worker thread, shutdownNow() in finally — fixes the duct-tape zombie-thread bug (testcontainers#9227). - Unreliables.retryUntilSuccess / retryUntilTrue: retry loop wrapped in Timeouts.getWithTimeout. Interrupt-induced exceptions are not allowed to overwrite the genuine last failure so callers diagnose the real cause (e.g. SSLHandshakeException) instead of the cancellation. - TimeoutException, RetryCountExceededException: unchecked, matching duct-tape's semantics so existing callers compile unchanged. Message "Retry limit hit with exception" is preserved verbatim for GenericContainerTest's existing assertion. Public API impact: - AbstractWaitStrategy.getRateLimiter() and withRateLimiter() now take org.testcontainers.utility.RateLimiter instead of org.rnorth.ducttape.ratelimits.RateLimiter. Source-compat is preserved for callers that go through AbstractWaitStrategy; only callers that explicitly imported the duct-tape types break. - Both methods are added to japicmp's methodExcludes with a comment explaining the binary-breaking change. Callers updated to use the new types: GenericContainer, HttpWaitStrategy, ShellStrategy, DockerHealthcheckWaitStrategy, WaitAllStrategy, StartupCheckStrategy, DockerClientProviderStrategy, RyukResourceReaper, CassandraQueryWaitStrategy (both packages), YugabyteDBY{CQL,SQL}WaitStrategy, and the corresponding tests. Refs: testcontainers#9241
austinceforce-pushed
the
replace-ducttape-no-deps-2
branch
from
May 19, 2026 21:44
918c3c9 to
bdde324Compareaustince
commented
May 19, 2026
OwnerAuthor
opening upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.