Uh oh!
There was an error while loading. Please reload this page.
improv: include example tests in make tests - #63
Conversation
Codecov Report
@@ Coverage Diff @@## develop #63 +/- ##
============================================
+ Coverage 99.39% 100.00% +0.60%
============================================
Files 15 15 Lines 496 496 Branches 45 45 ============================================
+ Hits 493 496 +3 + Misses 3 0 -3
Continue to review full report at Codecov.
|
heitorlessa
commented
Jun 7, 2020
Two quick questions as everything else look great.
I've run through all steps after checking out this PR and am hitting the namespace issue ( sam local invoke HelloWorldFunction --event events/event.json2020-06-0714:19:16,866aws_lambda_powertools.metrics.base [DEBUG] Serializing...
2020-06-0714:19:16,866aws_lambda_powertools.metrics.base [DEBUG] ValidatingserializedmetricsagainstCloudWatchEMFschema
[ERROR] SchemaValidationError: Invalidformat. Error: data._aws.CloudWatchMetrics[0].Namespacemustbestring, Invaliditem: data._aws.CloudWatchMetrics[0].NamespaceTraceback (mostrecentcalllast):
File"/var/task/aws_lambda_powertools/metrics/metrics.py", line110, indecoratemetrics=self.serialize_metric_set()
File"/var/task/aws_lambda_powertools/metrics/base.py", line186, inserialize_metric_setraiseSchemaValidationError(message) |
heitorlessa
left a comment
There was a problem hiding this comment.
Need to re-add POWERTOOLS_METRICS_NAMESPACE back to SAM template as it fails when it runs locally
to-mc
commented
Jun 7, 2020
I added this env var back in PR #62. I just merged develop into this branch so you should see it now. |
to-mc
commented
Jun 7, 2020
README is updated already - please let me know if the steps don't work for you. |
heitorlessa
commented
Jun 7, 2020
Just pulled, and it's all working now ;) Merging! |
make testsmake tests* develop: (31 commits) docs: fix contrast on highlighted code text (#73) feat: improve error handling for log_metrics decorator (#71) chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs feat: add high level imports (#70) fix: correct env var name for publish to pypi test (#69) chore: version bump (#68) feat: add capture_cold_start_metric for log_metrics (#67) chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66) feat: automate publishing to pypi (#58) feat: add pre-commit hooks (#64) improv: include example tests in `make tests` (#63) chore: rename Makefile target docs-dev to docs-local (#65) improv: better namespace/dimension handling for Metrics (#62) docs: build on master only chore: correct docstring for log_metrics chore: fix typo in metrics doc chore: Correct test comment chore: remove unused import chore: formatting feat: update Metrics interface to resemble tracer & logger: use "service" as its namespace. ...
* chore: add example/tests to test paths * chore: update example tests to remove requirement to manually specify env vars * chore: try to fix build for python3.6 (install dataclasses backport) * chore: fix build for python 3.6 * chore: dont run example test on python3.6 since it requires asyncio
Issue #, if available:
Description of changes:
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.