Uh oh!
There was an error while loading. Please reload this page.
fix: correct env var name for publish to pypi test - #69
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## develop #69 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 15 15 Lines 508 508 Branches 48 48 =========================================
Hits 508 508 Continue to review full report at Codecov.
|
heitorlessa
commented
Jun 8, 2020
via email
Contributor
🤦 LGTM …On Mon, 8 Jun 2020 at 12:23, Tom McCarthy ***@***.***> wrote:
*Issue #, if available:*
Description of changes:
Fix github workflow to push to pypi
- Meet tenets criteria
<https://awslabs.github.io/aws-lambda-powertools-python/#tenets>
- Update tests
- Update docs
- PR title follows conventional commit semantics
<https://github.com/awslabs/aws-lambda-powertools-python/blob/376ec0a2ac0d2a40e0af5717bef42ff84ca0d1b9/.github/semantic.yml#L2>
Breaking change checklist
Ignore if it's not a breaking change
*RFC issue #*:
- Migration process documented
- Implement warnings (if it can live side by side)
By submitting this pull request, I confirm that you can use, modify, copy,
and redistribute this contribution, under the terms of your choice.
------------------------------
You can view, comment on, or merge this pull request online at:
#69
Commit Summary
- fix: correct env var name for publish to pypi test
File Changes
- *M* .github/workflows/publish.yml
<https://github.com/awslabs/aws-lambda-powertools-python/pull/69/files#diff-963196a76268651f2135d3bbebba60fa>
(8)
Patch Links:
- https://github.com/awslabs/aws-lambda-powertools-python/pull/69.patch
- https://github.com/awslabs/aws-lambda-powertools-python/pull/69.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#69>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBB2DJNDG6DSRYBBCB3RVTC37ANCNFSM4NYKADKA>
.
|
heitorlessa added a commit
that referenced
this pull request
Jun 10, 2020
* develop: (31 commits) docs: fix contrast on highlighted code text (#73) feat: improve error handling for log_metrics decorator (#71) chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs feat: add high level imports (#70) fix: correct env var name for publish to pypi test (#69) chore: version bump (#68) feat: add capture_cold_start_metric for log_metrics (#67) chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66) feat: automate publishing to pypi (#58) feat: add pre-commit hooks (#64) improv: include example tests in `make tests` (#63) chore: rename Makefile target docs-dev to docs-local (#65) improv: better namespace/dimension handling for Metrics (#62) docs: build on master only chore: correct docstring for log_metrics chore: fix typo in metrics doc chore: Correct test comment chore: remove unused import chore: formatting feat: update Metrics interface to resemble tracer & logger: use "service" as its namespace. ...
heitorlessa referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Jun 17, 2020
heitorlessa referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Jun 17, 2020
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (104 commits) feat: add metrics metadata (#81) chore: cleanup tests (#79) chore: remove deprecated code before GA (#78) docs: customize contributing guide (#77) chore: move blockquotes as hidden comments chore: update CHANGELOG chore: bump version to 0.11.0 (#76) chore: version bump 0.10.1 fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74) fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74) docs: fix contrast on highlighted code text (#73) feat: improve error handling for log_metrics decorator (#71) chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs feat: add high level imports (#70) fix: correct env var name for publish to pypi test (#69) chore: version bump (#68) feat: add capture_cold_start_metric for log_metrics (#67) chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66) feat: automate publishing to pypi (#58) feat: add pre-commit hooks (#64) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.