feat(dev): add container dev runner by tejaskash · Pull Request #1962 · aws/agentcore-cli

tejaskash · 2026-08-10T18:18:01Z

Summary

add a streamed ContainerDevRunner for Docker, Podman, and Finch builds
validate build inputs, protect widened contexts with .dockerignore, and map protocol-specific loopback ports
keep environment and build-argument values out of argv while explicitly cleaning up project-scoped containers
cover runtime selection, command construction, validation, cancellation, cleanup, and failure sequencing with fake process tests

Stack

depends on feat(dev): CodeZip dev runner and process lifecycle core #1883
intentionally targets feat/dev-server-core; retarget to refactor after feat(dev): CodeZip dev runner and process lifecycle core #1883 merges
handler wiring and AWS credential materialization remain out of scope

Verification

bun test (1013 tests)
bun test src/core/dev/ (30 tests)
bun run typecheck
bun run lint:check
bun run format:check
bun run build

codecov-commenter · 2026-08-10T18:44:04Z

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (531d068) to head (113dcde).

Files with missing lines	Patch %	Lines
src/io/exec.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## refactor #1962 +/- ##
============================================
+ Coverage 96.78% 96.81% +0.03% 
============================================
Files 326 327 +1 Lines 18061 18231 +170 ============================================
+ Hits 17480 17650 +170 
Misses 581 581

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aidandaly24

One small nit that could be fixed another time otherwise this lgtm:

tejaskash · 2026-08-10T18:18:01Z

Summary

add a streamed ContainerDevRunner for Docker, Podman, and Finch builds
validate build inputs, protect widened contexts with .dockerignore, and map protocol-specific loopback ports
keep environment and build-argument values out of argv while explicitly cleaning up project-scoped containers
cover runtime selection, command construction, validation, cancellation, cleanup, and failure sequencing with fake process tests

Stack

depends on feat(dev): CodeZip dev runner and process lifecycle core #1883
intentionally targets feat/dev-server-core; retarget to refactor after feat(dev): CodeZip dev runner and process lifecycle core #1883 merges
handler wiring and AWS credential materialization remain out of scope

Verification

bun test (1013 tests)
bun test src/core/dev/ (30 tests)
bun run typecheck
bun run lint:check
bun run format:check
bun run build

codecov-commenter · 2026-08-10T18:44:04Z

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (531d068) to head (113dcde).

Files with missing lines	Patch %	Lines
src/io/exec.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## refactor #1962 +/- ##
============================================
+ Coverage 96.78% 96.81% +0.03% 
============================================
Files 326 327 +1 Lines 18061 18231 +170 ============================================
+ Hits 17480 17650 +170 
Misses 581 581

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aidandaly24

One small nit that could be fixed another time otherwise this lgtm:

tejaskash · 2026-08-10T18:18:01Z

Summary

add a streamed ContainerDevRunner for Docker, Podman, and Finch builds
validate build inputs, protect widened contexts with .dockerignore, and map protocol-specific loopback ports
keep environment and build-argument values out of argv while explicitly cleaning up project-scoped containers
cover runtime selection, command construction, validation, cancellation, cleanup, and failure sequencing with fake process tests

Stack

depends on feat(dev): CodeZip dev runner and process lifecycle core #1883
intentionally targets feat/dev-server-core; retarget to refactor after feat(dev): CodeZip dev runner and process lifecycle core #1883 merges
handler wiring and AWS credential materialization remain out of scope

Verification

bun test (1013 tests)
bun test src/core/dev/ (30 tests)
bun run typecheck
bun run lint:check
bun run format:check
bun run build

codecov-commenter · 2026-08-10T18:44:04Z

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (531d068) to head (113dcde).

Files with missing lines	Patch %	Lines
src/io/exec.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## refactor #1962 +/- ##
============================================
+ Coverage 96.78% 96.81% +0.03% 
============================================
Files 326 327 +1 Lines 18061 18231 +170 ============================================
+ Hits 17480 17650 +170 
Misses 581 581

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aidandaly24

One small nit that could be fixed another time otherwise this lgtm:

tejaskash · 2026-08-10T18:18:01Z

Summary

add a streamed ContainerDevRunner for Docker, Podman, and Finch builds
validate build inputs, protect widened contexts with .dockerignore, and map protocol-specific loopback ports
keep environment and build-argument values out of argv while explicitly cleaning up project-scoped containers
cover runtime selection, command construction, validation, cancellation, cleanup, and failure sequencing with fake process tests

Stack

depends on feat(dev): CodeZip dev runner and process lifecycle core #1883
intentionally targets feat/dev-server-core; retarget to refactor after feat(dev): CodeZip dev runner and process lifecycle core #1883 merges
handler wiring and AWS credential materialization remain out of scope

Verification

bun test (1013 tests)
bun test src/core/dev/ (30 tests)
bun run typecheck
bun run lint:check
bun run format:check
bun run build

codecov-commenter · 2026-08-10T18:44:04Z

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (531d068) to head (113dcde).

Files with missing lines	Patch %	Lines
src/io/exec.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## refactor #1962 +/- ##
============================================
+ Coverage 96.78% 96.81% +0.03% 
============================================
Files 326 327 +1 Lines 18061 18231 +170 ============================================
+ Hits 17480 17650 +170 
Misses 581 581

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aidandaly24

One small nit that could be fixed another time otherwise this lgtm:

tejaskash · 2026-08-10T18:18:01Z

Summary

add a streamed ContainerDevRunner for Docker, Podman, and Finch builds
validate build inputs, protect widened contexts with .dockerignore, and map protocol-specific loopback ports
keep environment and build-argument values out of argv while explicitly cleaning up project-scoped containers
cover runtime selection, command construction, validation, cancellation, cleanup, and failure sequencing with fake process tests

Stack

depends on feat(dev): CodeZip dev runner and process lifecycle core #1883
intentionally targets feat/dev-server-core; retarget to refactor after feat(dev): CodeZip dev runner and process lifecycle core #1883 merges
handler wiring and AWS credential materialization remain out of scope

Verification

bun test (1013 tests)
bun test src/core/dev/ (30 tests)
bun run typecheck
bun run lint:check
bun run format:check
bun run build

codecov-commenter · 2026-08-10T18:44:04Z

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (531d068) to head (113dcde).

Files with missing lines	Patch %	Lines
src/io/exec.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## refactor #1962 +/- ##
============================================
+ Coverage 96.78% 96.81% +0.03% 
============================================
Files 326 327 +1 Lines 18061 18231 +170 ============================================
+ Hits 17480 17650 +170 
Misses 581 581

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aidandaly24

One small nit that could be fixed another time otherwise this lgtm:

tejaskash · 2026-08-10T18:18:01Z

Summary

add a streamed ContainerDevRunner for Docker, Podman, and Finch builds
validate build inputs, protect widened contexts with .dockerignore, and map protocol-specific loopback ports
keep environment and build-argument values out of argv while explicitly cleaning up project-scoped containers
cover runtime selection, command construction, validation, cancellation, cleanup, and failure sequencing with fake process tests

Stack

depends on feat(dev): CodeZip dev runner and process lifecycle core #1883
intentionally targets feat/dev-server-core; retarget to refactor after feat(dev): CodeZip dev runner and process lifecycle core #1883 merges
handler wiring and AWS credential materialization remain out of scope

Verification

bun test (1013 tests)
bun test src/core/dev/ (30 tests)
bun run typecheck
bun run lint:check
bun run format:check
bun run build

codecov-commenter · 2026-08-10T18:44:04Z

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (531d068) to head (113dcde).

Files with missing lines	Patch %	Lines
src/io/exec.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## refactor #1962 +/- ##
============================================
+ Coverage 96.78% 96.81% +0.03% 
============================================
Files 326 327 +1 Lines 18061 18231 +170 ============================================
+ Hits 17480 17650 +170 
Misses 581 581

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aidandaly24

One small nit that could be fixed another time otherwise this lgtm:

tejaskash · 2026-08-10T18:18:01Z

Summary

add a streamed ContainerDevRunner for Docker, Podman, and Finch builds
validate build inputs, protect widened contexts with .dockerignore, and map protocol-specific loopback ports
keep environment and build-argument values out of argv while explicitly cleaning up project-scoped containers
cover runtime selection, command construction, validation, cancellation, cleanup, and failure sequencing with fake process tests

Stack

depends on feat(dev): CodeZip dev runner and process lifecycle core #1883
intentionally targets feat/dev-server-core; retarget to refactor after feat(dev): CodeZip dev runner and process lifecycle core #1883 merges
handler wiring and AWS credential materialization remain out of scope

Verification

bun test (1013 tests)
bun test src/core/dev/ (30 tests)
bun run typecheck
bun run lint:check
bun run format:check
bun run build

codecov-commenter · 2026-08-10T18:44:04Z

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (531d068) to head (113dcde).

Files with missing lines	Patch %	Lines
src/io/exec.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## refactor #1962 +/- ##
============================================
+ Coverage 96.78% 96.81% +0.03% 
============================================
Files 326 327 +1 Lines 18061 18231 +170 ============================================
+ Hits 17480 17650 +170 
Misses 581 581

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aidandaly24

One small nit that could be fixed another time otherwise this lgtm:

tejaskash · 2026-08-10T18:18:01Z

Summary

add a streamed ContainerDevRunner for Docker, Podman, and Finch builds
validate build inputs, protect widened contexts with .dockerignore, and map protocol-specific loopback ports
keep environment and build-argument values out of argv while explicitly cleaning up project-scoped containers
cover runtime selection, command construction, validation, cancellation, cleanup, and failure sequencing with fake process tests

Stack

depends on feat(dev): CodeZip dev runner and process lifecycle core #1883
intentionally targets feat/dev-server-core; retarget to refactor after feat(dev): CodeZip dev runner and process lifecycle core #1883 merges
handler wiring and AWS credential materialization remain out of scope

Verification

bun test (1013 tests)
bun test src/core/dev/ (30 tests)
bun run typecheck
bun run lint:check
bun run format:check
bun run build

codecov-commenter · 2026-08-10T18:44:04Z

Codecov Report

❌ Patch coverage is 99.42529% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (531d068) to head (113dcde).

Files with missing lines	Patch %	Lines
src/io/exec.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## refactor #1962 +/- ##
============================================
+ Coverage 96.78% 96.81% +0.03% 
============================================
Files 326 327 +1 Lines 18061 18231 +170 ============================================
+ Hits 17480 17650 +170 
Misses 581 581

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aidandaly24

One small nit that could be fixed another time otherwise this lgtm:

github-actionsBot added the size/l PR size: L label Aug 10, 2026

tejaskash had a problem deploying to e2e-testing August 10, 2026 18:18 — with GitHub Actions Failure

github-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026

tejaskash force-pushed the feat/container-dev-runner branch from 961beaf to e42dbf8Compare August 10, 2026 18:41

tejaskash force-pushed the feat/container-dev-runner branch from e42dbf8 to 853e311Compare August 10, 2026 20:12

tejaskash force-pushed the feat/container-dev-runner branch 2 times, most recently from 3f4e482 to 5caac75Compare August 10, 2026 20:25

tejaskash mentioned this pull request Aug 10, 2026
feat(project): wire dev handler #1966
Merged

tejaskash force-pushed the feat/container-dev-runner branch from 5caac75 to 10cea59Compare August 10, 2026 20:57

Base automatically changed from feat/dev-server-core to refactorAugust 10, 2026 22:55

jariy17 force-pushed the feat/container-dev-runner branch from 10cea59 to c6dd19bCompare August 10, 2026 22:55

tejaskash force-pushed the feat/container-dev-runner branch 2 times, most recently from cb1915e to 69d7548Compare August 11, 2026 16:24

Hweinstock reviewed Aug 11, 2026
View reviewed changes

Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.test.ts

notgitika requested changes Aug 11, 2026
View reviewed changes

Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts

tejaskash added 3 commits August 12, 2026 09:40

feat(dev): add container dev runner
987a509

fix(dev): address container runner review
6743887

fix(dev): address container runtime feedback
113dcde

tejaskash force-pushed the feat/container-dev-runner branch from 838f84f to 113dcdeCompare August 12, 2026 13:41

aidandaly24 approved these changes Aug 12, 2026
View reviewed changes

Comment threadsrc/core/dev/container.ts

aidandaly24 reviewed Aug 12, 2026
View reviewed changes

Comment threadsrc/io/exec.ts

tejaskash requested review from notgitika and removed request for notgitika August 13, 2026 13:41

notgitika approved these changes Aug 13, 2026
View reviewed changes

tejaskash merged commit 2d6e44e into refactorAug 13, 2026
16 checks passed

tejaskash deleted the feat/container-dev-runner branch August 13, 2026 17:37

tejaskash mentioned this pull request Aug 13, 2026
fix(dev): update container test schema import #1997
Merged