feat(project): wire dev handler - #1966

Merged
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler
Aug 17, 2026
Merged

feat(project): wire dev handler#1966
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • implement agentcore project dev runtime selection, port resolution, runner dispatch, structured output, and signal handling
  • reuse withProject for project discovery and actionable missing-project guidance
  • load runtime and .env.local values directly; containers forward host AWS variables, mount ~/.aws read-only, and fail early when neither credential source exists
  • reuse shared JSON rendering for NDJSON events and generalize command interruption handling

Stacks on #1962.

Verification

  • bun test (1107 pass)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • executable smoke: scaffolded a real Python project, ran project dev, received healthy /ping, interrupted with exit 130, and verified child cleanup and port release
  • executable no-project probe verified the actionable project create guidance

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 10, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 736c095 to 3d6dd24CompareAugust 10, 2026 20:57
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.00990% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.06%. Comparing base (2dba459) to head (f0b65c9).

Files with missing linesPatch %Lines
src/core/dev/path.ts92.59%2 Missing ⚠️
src/handlers/project/dev/environment.ts97.14%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #1966 +/- ##
============================================
+ Coverage 97.04% 97.06% +0.02% 
============================================
Files 370 374 +4 Lines 22287 22542 +255 ============================================
+ Hits 21628 21880 +252 - Misses 659 662 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3d6dd24 to d003ce7CompareAugust 10, 2026 21:25
@jariy17
jariy17force-pushed the feat/project-dev-handler branch from d003ce7 to 3b72b9cCompareAugust 10, 2026 22:55
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3b72b9c to 03f5223CompareAugust 11, 2026 01:12
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 03f5223 to b7c2b24CompareAugust 11, 2026 14:05
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 3 times, most recently from ac10a56 to 17d2047CompareAugust 12, 2026 13:10
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 126d77b to c55046eCompareAugust 12, 2026 13:42
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from c55046e to 37312c9CompareAugust 13, 2026 14:02
Base automatically changed from feat/container-dev-runner to refactorAugust 13, 2026 17:37
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 37312c9 to 73ab887CompareAugust 13, 2026 17:41

@HweinstockHweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only blocking comment is the direct process kill.

Comment threadsrc/core/dev/container.test.ts
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/port.ts Outdated
Comment threadsrc/errors/errors.tsx
Comment threadsrc/handlers/project/dev/index.ts Outdated
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/index.ts Outdated
Comment threadpackage.json
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 73ab887 to 32e0283CompareAugust 14, 2026 15:06
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 74c4f1d to e6c8aa1CompareAugust 14, 2026 15:19
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/dev/environment.ts
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from e6c8aa1 to 85d6498CompareAugust 14, 2026 16:01
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.ts
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 90abf1f to 6118781CompareAugust 17, 2026 17:46
Hweinstock
Hweinstock previously approved these changes Aug 17, 2026
Comment threadsrc/handlers/runtime/invoke/index.tsx Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/handlers/project/index.ts

@aidandaly24aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I will replace the user cancellation error with mine in #1986

@aidandaly24
aidandaly24 merged commit a317a83 into refactorAug 17, 2026
15 checks passed
@aidandaly24
aidandaly24 deleted the feat/project-dev-handler branch August 17, 2026 20:46
@aidandaly24

Copy link
Copy Markdown
Contributor

Saw that Harrison had also approved earlier so merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@aidandaly24@Hweinstock@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(project): wire dev handler - #1966

Merged
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler
Aug 17, 2026
Merged

feat(project): wire dev handler#1966
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • implement agentcore project dev runtime selection, port resolution, runner dispatch, structured output, and signal handling
  • reuse withProject for project discovery and actionable missing-project guidance
  • load runtime and .env.local values directly; containers forward host AWS variables, mount ~/.aws read-only, and fail early when neither credential source exists
  • reuse shared JSON rendering for NDJSON events and generalize command interruption handling

Stacks on #1962.

Verification

  • bun test (1107 pass)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • executable smoke: scaffolded a real Python project, ran project dev, received healthy /ping, interrupted with exit 130, and verified child cleanup and port release
  • executable no-project probe verified the actionable project create guidance

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 10, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 736c095 to 3d6dd24CompareAugust 10, 2026 20:57
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.00990% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.06%. Comparing base (2dba459) to head (f0b65c9).

Files with missing linesPatch %Lines
src/core/dev/path.ts92.59%2 Missing ⚠️
src/handlers/project/dev/environment.ts97.14%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #1966 +/- ##
============================================
+ Coverage 97.04% 97.06% +0.02% 
============================================
Files 370 374 +4 Lines 22287 22542 +255 ============================================
+ Hits 21628 21880 +252 - Misses 659 662 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3d6dd24 to d003ce7CompareAugust 10, 2026 21:25
@jariy17
jariy17force-pushed the feat/project-dev-handler branch from d003ce7 to 3b72b9cCompareAugust 10, 2026 22:55
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3b72b9c to 03f5223CompareAugust 11, 2026 01:12
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 03f5223 to b7c2b24CompareAugust 11, 2026 14:05
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 3 times, most recently from ac10a56 to 17d2047CompareAugust 12, 2026 13:10
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 126d77b to c55046eCompareAugust 12, 2026 13:42
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from c55046e to 37312c9CompareAugust 13, 2026 14:02
Base automatically changed from feat/container-dev-runner to refactorAugust 13, 2026 17:37
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 37312c9 to 73ab887CompareAugust 13, 2026 17:41

@HweinstockHweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only blocking comment is the direct process kill.

Comment threadsrc/core/dev/container.test.ts
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/port.ts Outdated
Comment threadsrc/errors/errors.tsx
Comment threadsrc/handlers/project/dev/index.ts Outdated
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/index.ts Outdated
Comment threadpackage.json
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 73ab887 to 32e0283CompareAugust 14, 2026 15:06
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 74c4f1d to e6c8aa1CompareAugust 14, 2026 15:19
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/dev/environment.ts
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from e6c8aa1 to 85d6498CompareAugust 14, 2026 16:01
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.ts
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 90abf1f to 6118781CompareAugust 17, 2026 17:46
Hweinstock
Hweinstock previously approved these changes Aug 17, 2026
Comment threadsrc/handlers/runtime/invoke/index.tsx Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/handlers/project/index.ts

@aidandaly24aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I will replace the user cancellation error with mine in #1986

@aidandaly24
aidandaly24 merged commit a317a83 into refactorAug 17, 2026
15 checks passed
@aidandaly24
aidandaly24 deleted the feat/project-dev-handler branch August 17, 2026 20:46
@aidandaly24

Copy link
Copy Markdown
Contributor

Saw that Harrison had also approved earlier so merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@aidandaly24@Hweinstock@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(project): wire dev handler - #1966

Merged
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler
Aug 17, 2026
Merged

feat(project): wire dev handler#1966
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • implement agentcore project dev runtime selection, port resolution, runner dispatch, structured output, and signal handling
  • reuse withProject for project discovery and actionable missing-project guidance
  • load runtime and .env.local values directly; containers forward host AWS variables, mount ~/.aws read-only, and fail early when neither credential source exists
  • reuse shared JSON rendering for NDJSON events and generalize command interruption handling

Stacks on #1962.

Verification

  • bun test (1107 pass)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • executable smoke: scaffolded a real Python project, ran project dev, received healthy /ping, interrupted with exit 130, and verified child cleanup and port release
  • executable no-project probe verified the actionable project create guidance

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 10, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 736c095 to 3d6dd24CompareAugust 10, 2026 20:57
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.00990% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.06%. Comparing base (2dba459) to head (f0b65c9).

Files with missing linesPatch %Lines
src/core/dev/path.ts92.59%2 Missing ⚠️
src/handlers/project/dev/environment.ts97.14%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #1966 +/- ##
============================================
+ Coverage 97.04% 97.06% +0.02% 
============================================
Files 370 374 +4 Lines 22287 22542 +255 ============================================
+ Hits 21628 21880 +252 - Misses 659 662 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3d6dd24 to d003ce7CompareAugust 10, 2026 21:25
@jariy17
jariy17force-pushed the feat/project-dev-handler branch from d003ce7 to 3b72b9cCompareAugust 10, 2026 22:55
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3b72b9c to 03f5223CompareAugust 11, 2026 01:12
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 03f5223 to b7c2b24CompareAugust 11, 2026 14:05
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 3 times, most recently from ac10a56 to 17d2047CompareAugust 12, 2026 13:10
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 126d77b to c55046eCompareAugust 12, 2026 13:42
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from c55046e to 37312c9CompareAugust 13, 2026 14:02
Base automatically changed from feat/container-dev-runner to refactorAugust 13, 2026 17:37
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 37312c9 to 73ab887CompareAugust 13, 2026 17:41

@HweinstockHweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only blocking comment is the direct process kill.

Comment threadsrc/core/dev/container.test.ts
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/port.ts Outdated
Comment threadsrc/errors/errors.tsx
Comment threadsrc/handlers/project/dev/index.ts Outdated
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/index.ts Outdated
Comment threadpackage.json
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 73ab887 to 32e0283CompareAugust 14, 2026 15:06
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 74c4f1d to e6c8aa1CompareAugust 14, 2026 15:19
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/dev/environment.ts
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from e6c8aa1 to 85d6498CompareAugust 14, 2026 16:01
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.ts
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 90abf1f to 6118781CompareAugust 17, 2026 17:46
Hweinstock
Hweinstock previously approved these changes Aug 17, 2026
Comment threadsrc/handlers/runtime/invoke/index.tsx Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/handlers/project/index.ts

@aidandaly24aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I will replace the user cancellation error with mine in #1986

@aidandaly24
aidandaly24 merged commit a317a83 into refactorAug 17, 2026
15 checks passed
@aidandaly24
aidandaly24 deleted the feat/project-dev-handler branch August 17, 2026 20:46
@aidandaly24

Copy link
Copy Markdown
Contributor

Saw that Harrison had also approved earlier so merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@aidandaly24@Hweinstock@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(project): wire dev handler - #1966

Merged
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler
Aug 17, 2026
Merged

feat(project): wire dev handler#1966
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • implement agentcore project dev runtime selection, port resolution, runner dispatch, structured output, and signal handling
  • reuse withProject for project discovery and actionable missing-project guidance
  • load runtime and .env.local values directly; containers forward host AWS variables, mount ~/.aws read-only, and fail early when neither credential source exists
  • reuse shared JSON rendering for NDJSON events and generalize command interruption handling

Stacks on #1962.

Verification

  • bun test (1107 pass)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • executable smoke: scaffolded a real Python project, ran project dev, received healthy /ping, interrupted with exit 130, and verified child cleanup and port release
  • executable no-project probe verified the actionable project create guidance

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 10, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 736c095 to 3d6dd24CompareAugust 10, 2026 20:57
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.00990% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.06%. Comparing base (2dba459) to head (f0b65c9).

Files with missing linesPatch %Lines
src/core/dev/path.ts92.59%2 Missing ⚠️
src/handlers/project/dev/environment.ts97.14%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #1966 +/- ##
============================================
+ Coverage 97.04% 97.06% +0.02% 
============================================
Files 370 374 +4 Lines 22287 22542 +255 ============================================
+ Hits 21628 21880 +252 - Misses 659 662 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3d6dd24 to d003ce7CompareAugust 10, 2026 21:25
@jariy17
jariy17force-pushed the feat/project-dev-handler branch from d003ce7 to 3b72b9cCompareAugust 10, 2026 22:55
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3b72b9c to 03f5223CompareAugust 11, 2026 01:12
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 03f5223 to b7c2b24CompareAugust 11, 2026 14:05
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 3 times, most recently from ac10a56 to 17d2047CompareAugust 12, 2026 13:10
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 126d77b to c55046eCompareAugust 12, 2026 13:42
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from c55046e to 37312c9CompareAugust 13, 2026 14:02
Base automatically changed from feat/container-dev-runner to refactorAugust 13, 2026 17:37
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 37312c9 to 73ab887CompareAugust 13, 2026 17:41

@HweinstockHweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only blocking comment is the direct process kill.

Comment threadsrc/core/dev/container.test.ts
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/port.ts Outdated
Comment threadsrc/errors/errors.tsx
Comment threadsrc/handlers/project/dev/index.ts Outdated
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/index.ts Outdated
Comment threadpackage.json
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 73ab887 to 32e0283CompareAugust 14, 2026 15:06
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 74c4f1d to e6c8aa1CompareAugust 14, 2026 15:19
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/dev/environment.ts
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from e6c8aa1 to 85d6498CompareAugust 14, 2026 16:01
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.ts
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 90abf1f to 6118781CompareAugust 17, 2026 17:46
Hweinstock
Hweinstock previously approved these changes Aug 17, 2026
Comment threadsrc/handlers/runtime/invoke/index.tsx Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/handlers/project/index.ts

@aidandaly24aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I will replace the user cancellation error with mine in #1986

@aidandaly24
aidandaly24 merged commit a317a83 into refactorAug 17, 2026
15 checks passed
@aidandaly24
aidandaly24 deleted the feat/project-dev-handler branch August 17, 2026 20:46
@aidandaly24

Copy link
Copy Markdown
Contributor

Saw that Harrison had also approved earlier so merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@aidandaly24@Hweinstock@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(project): wire dev handler - #1966

Merged
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler
Aug 17, 2026
Merged

feat(project): wire dev handler#1966
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • implement agentcore project dev runtime selection, port resolution, runner dispatch, structured output, and signal handling
  • reuse withProject for project discovery and actionable missing-project guidance
  • load runtime and .env.local values directly; containers forward host AWS variables, mount ~/.aws read-only, and fail early when neither credential source exists
  • reuse shared JSON rendering for NDJSON events and generalize command interruption handling

Stacks on #1962.

Verification

  • bun test (1107 pass)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • executable smoke: scaffolded a real Python project, ran project dev, received healthy /ping, interrupted with exit 130, and verified child cleanup and port release
  • executable no-project probe verified the actionable project create guidance

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 10, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 736c095 to 3d6dd24CompareAugust 10, 2026 20:57
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.00990% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.06%. Comparing base (2dba459) to head (f0b65c9).

Files with missing linesPatch %Lines
src/core/dev/path.ts92.59%2 Missing ⚠️
src/handlers/project/dev/environment.ts97.14%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #1966 +/- ##
============================================
+ Coverage 97.04% 97.06% +0.02% 
============================================
Files 370 374 +4 Lines 22287 22542 +255 ============================================
+ Hits 21628 21880 +252 - Misses 659 662 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3d6dd24 to d003ce7CompareAugust 10, 2026 21:25
@jariy17
jariy17force-pushed the feat/project-dev-handler branch from d003ce7 to 3b72b9cCompareAugust 10, 2026 22:55
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3b72b9c to 03f5223CompareAugust 11, 2026 01:12
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 03f5223 to b7c2b24CompareAugust 11, 2026 14:05
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 3 times, most recently from ac10a56 to 17d2047CompareAugust 12, 2026 13:10
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 126d77b to c55046eCompareAugust 12, 2026 13:42
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from c55046e to 37312c9CompareAugust 13, 2026 14:02
Base automatically changed from feat/container-dev-runner to refactorAugust 13, 2026 17:37
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 37312c9 to 73ab887CompareAugust 13, 2026 17:41

@HweinstockHweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only blocking comment is the direct process kill.

Comment threadsrc/core/dev/container.test.ts
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/port.ts Outdated
Comment threadsrc/errors/errors.tsx
Comment threadsrc/handlers/project/dev/index.ts Outdated
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/index.ts Outdated
Comment threadpackage.json
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 73ab887 to 32e0283CompareAugust 14, 2026 15:06
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 74c4f1d to e6c8aa1CompareAugust 14, 2026 15:19
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/dev/environment.ts
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from e6c8aa1 to 85d6498CompareAugust 14, 2026 16:01
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.ts
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 90abf1f to 6118781CompareAugust 17, 2026 17:46
Hweinstock
Hweinstock previously approved these changes Aug 17, 2026
Comment threadsrc/handlers/runtime/invoke/index.tsx Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/handlers/project/index.ts

@aidandaly24aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I will replace the user cancellation error with mine in #1986

@aidandaly24
aidandaly24 merged commit a317a83 into refactorAug 17, 2026
15 checks passed
@aidandaly24
aidandaly24 deleted the feat/project-dev-handler branch August 17, 2026 20:46
@aidandaly24

Copy link
Copy Markdown
Contributor

Saw that Harrison had also approved earlier so merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@aidandaly24@Hweinstock@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(project): wire dev handler - #1966

Merged
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler
Aug 17, 2026
Merged

feat(project): wire dev handler#1966
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • implement agentcore project dev runtime selection, port resolution, runner dispatch, structured output, and signal handling
  • reuse withProject for project discovery and actionable missing-project guidance
  • load runtime and .env.local values directly; containers forward host AWS variables, mount ~/.aws read-only, and fail early when neither credential source exists
  • reuse shared JSON rendering for NDJSON events and generalize command interruption handling

Stacks on #1962.

Verification

  • bun test (1107 pass)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • executable smoke: scaffolded a real Python project, ran project dev, received healthy /ping, interrupted with exit 130, and verified child cleanup and port release
  • executable no-project probe verified the actionable project create guidance

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 10, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 736c095 to 3d6dd24CompareAugust 10, 2026 20:57
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.00990% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.06%. Comparing base (2dba459) to head (f0b65c9).

Files with missing linesPatch %Lines
src/core/dev/path.ts92.59%2 Missing ⚠️
src/handlers/project/dev/environment.ts97.14%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #1966 +/- ##
============================================
+ Coverage 97.04% 97.06% +0.02% 
============================================
Files 370 374 +4 Lines 22287 22542 +255 ============================================
+ Hits 21628 21880 +252 - Misses 659 662 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3d6dd24 to d003ce7CompareAugust 10, 2026 21:25
@jariy17
jariy17force-pushed the feat/project-dev-handler branch from d003ce7 to 3b72b9cCompareAugust 10, 2026 22:55
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3b72b9c to 03f5223CompareAugust 11, 2026 01:12
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 03f5223 to b7c2b24CompareAugust 11, 2026 14:05
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 3 times, most recently from ac10a56 to 17d2047CompareAugust 12, 2026 13:10
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 126d77b to c55046eCompareAugust 12, 2026 13:42
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from c55046e to 37312c9CompareAugust 13, 2026 14:02
Base automatically changed from feat/container-dev-runner to refactorAugust 13, 2026 17:37
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 37312c9 to 73ab887CompareAugust 13, 2026 17:41

@HweinstockHweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only blocking comment is the direct process kill.

Comment threadsrc/core/dev/container.test.ts
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/port.ts Outdated
Comment threadsrc/errors/errors.tsx
Comment threadsrc/handlers/project/dev/index.ts Outdated
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/index.ts Outdated
Comment threadpackage.json
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 73ab887 to 32e0283CompareAugust 14, 2026 15:06
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 74c4f1d to e6c8aa1CompareAugust 14, 2026 15:19
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/dev/environment.ts
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from e6c8aa1 to 85d6498CompareAugust 14, 2026 16:01
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.ts
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 90abf1f to 6118781CompareAugust 17, 2026 17:46
Hweinstock
Hweinstock previously approved these changes Aug 17, 2026
Comment threadsrc/handlers/runtime/invoke/index.tsx Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/handlers/project/index.ts

@aidandaly24aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I will replace the user cancellation error with mine in #1986

@aidandaly24
aidandaly24 merged commit a317a83 into refactorAug 17, 2026
15 checks passed
@aidandaly24
aidandaly24 deleted the feat/project-dev-handler branch August 17, 2026 20:46
@aidandaly24

Copy link
Copy Markdown
Contributor

Saw that Harrison had also approved earlier so merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@aidandaly24@Hweinstock@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(project): wire dev handler - #1966

Merged
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler
Aug 17, 2026
Merged

feat(project): wire dev handler#1966
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • implement agentcore project dev runtime selection, port resolution, runner dispatch, structured output, and signal handling
  • reuse withProject for project discovery and actionable missing-project guidance
  • load runtime and .env.local values directly; containers forward host AWS variables, mount ~/.aws read-only, and fail early when neither credential source exists
  • reuse shared JSON rendering for NDJSON events and generalize command interruption handling

Stacks on #1962.

Verification

  • bun test (1107 pass)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • executable smoke: scaffolded a real Python project, ran project dev, received healthy /ping, interrupted with exit 130, and verified child cleanup and port release
  • executable no-project probe verified the actionable project create guidance

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 10, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 736c095 to 3d6dd24CompareAugust 10, 2026 20:57
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.00990% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.06%. Comparing base (2dba459) to head (f0b65c9).

Files with missing linesPatch %Lines
src/core/dev/path.ts92.59%2 Missing ⚠️
src/handlers/project/dev/environment.ts97.14%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #1966 +/- ##
============================================
+ Coverage 97.04% 97.06% +0.02% 
============================================
Files 370 374 +4 Lines 22287 22542 +255 ============================================
+ Hits 21628 21880 +252 - Misses 659 662 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3d6dd24 to d003ce7CompareAugust 10, 2026 21:25
@jariy17
jariy17force-pushed the feat/project-dev-handler branch from d003ce7 to 3b72b9cCompareAugust 10, 2026 22:55
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3b72b9c to 03f5223CompareAugust 11, 2026 01:12
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 03f5223 to b7c2b24CompareAugust 11, 2026 14:05
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 3 times, most recently from ac10a56 to 17d2047CompareAugust 12, 2026 13:10
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 126d77b to c55046eCompareAugust 12, 2026 13:42
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from c55046e to 37312c9CompareAugust 13, 2026 14:02
Base automatically changed from feat/container-dev-runner to refactorAugust 13, 2026 17:37
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 37312c9 to 73ab887CompareAugust 13, 2026 17:41

@HweinstockHweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only blocking comment is the direct process kill.

Comment threadsrc/core/dev/container.test.ts
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/port.ts Outdated
Comment threadsrc/errors/errors.tsx
Comment threadsrc/handlers/project/dev/index.ts Outdated
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/index.ts Outdated
Comment threadpackage.json
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 73ab887 to 32e0283CompareAugust 14, 2026 15:06
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 74c4f1d to e6c8aa1CompareAugust 14, 2026 15:19
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/dev/environment.ts
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from e6c8aa1 to 85d6498CompareAugust 14, 2026 16:01
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.ts
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 90abf1f to 6118781CompareAugust 17, 2026 17:46
Hweinstock
Hweinstock previously approved these changes Aug 17, 2026
Comment threadsrc/handlers/runtime/invoke/index.tsx Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/handlers/project/index.ts

@aidandaly24aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I will replace the user cancellation error with mine in #1986

@aidandaly24
aidandaly24 merged commit a317a83 into refactorAug 17, 2026
15 checks passed
@aidandaly24
aidandaly24 deleted the feat/project-dev-handler branch August 17, 2026 20:46
@aidandaly24

Copy link
Copy Markdown
Contributor

Saw that Harrison had also approved earlier so merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@aidandaly24@Hweinstock@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(project): wire dev handler - #1966

Merged
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler
Aug 17, 2026
Merged

feat(project): wire dev handler#1966
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • implement agentcore project dev runtime selection, port resolution, runner dispatch, structured output, and signal handling
  • reuse withProject for project discovery and actionable missing-project guidance
  • load runtime and .env.local values directly; containers forward host AWS variables, mount ~/.aws read-only, and fail early when neither credential source exists
  • reuse shared JSON rendering for NDJSON events and generalize command interruption handling

Stacks on #1962.

Verification

  • bun test (1107 pass)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • executable smoke: scaffolded a real Python project, ran project dev, received healthy /ping, interrupted with exit 130, and verified child cleanup and port release
  • executable no-project probe verified the actionable project create guidance

@github-actionsgithub-actionsBot added the size/xl PR size: XL label Aug 10, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 736c095 to 3d6dd24CompareAugust 10, 2026 20:57
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.00990% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.06%. Comparing base (2dba459) to head (f0b65c9).

Files with missing linesPatch %Lines
src/core/dev/path.ts92.59%2 Missing ⚠️
src/handlers/project/dev/environment.ts97.14%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #1966 +/- ##
============================================
+ Coverage 97.04% 97.06% +0.02% 
============================================
Files 370 374 +4 Lines 22287 22542 +255 ============================================
+ Hits 21628 21880 +252 - Misses 659 662 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3d6dd24 to d003ce7CompareAugust 10, 2026 21:25
@jariy17
jariy17force-pushed the feat/project-dev-handler branch from d003ce7 to 3b72b9cCompareAugust 10, 2026 22:55
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 3b72b9c to 03f5223CompareAugust 11, 2026 01:12
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 03f5223 to b7c2b24CompareAugust 11, 2026 14:05
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 3 times, most recently from ac10a56 to 17d2047CompareAugust 12, 2026 13:10
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 126d77b to c55046eCompareAugust 12, 2026 13:42
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from c55046e to 37312c9CompareAugust 13, 2026 14:02
Base automatically changed from feat/container-dev-runner to refactorAugust 13, 2026 17:37
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 37312c9 to 73ab887CompareAugust 13, 2026 17:41

@HweinstockHweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only blocking comment is the direct process kill.

Comment threadsrc/core/dev/container.test.ts
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/core/dev/port.ts Outdated
Comment threadsrc/errors/errors.tsx
Comment threadsrc/handlers/project/dev/index.ts Outdated
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/index.ts Outdated
Comment threadpackage.json
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 73ab887 to 32e0283CompareAugust 14, 2026 15:06
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch 2 times, most recently from 74c4f1d to e6c8aa1CompareAugust 14, 2026 15:19
Comment threadsrc/handlers/project/dev/index.ts
Comment threadsrc/handlers/project/dev/environment.ts
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from e6c8aa1 to 85d6498CompareAugust 14, 2026 16:01
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Comment threadsrc/core/dev/container.ts
Comment threadsrc/core/dev/container.ts
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
@tejaskash
tejaskashforce-pushed the feat/project-dev-handler branch from 90abf1f to 6118781CompareAugust 17, 2026 17:46
Hweinstock
Hweinstock previously approved these changes Aug 17, 2026
Comment threadsrc/handlers/runtime/invoke/index.tsx Outdated
Comment threadsrc/core/dev/container.ts Outdated
Comment threadsrc/handlers/project/index.ts

@aidandaly24aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I will replace the user cancellation error with mine in #1986

@aidandaly24
aidandaly24 merged commit a317a83 into refactorAug 17, 2026
15 checks passed
@aidandaly24
aidandaly24 deleted the feat/project-dev-handler branch August 17, 2026 20:46
@aidandaly24

Copy link
Copy Markdown
Contributor

Saw that Harrison had also approved earlier so merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xlPR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@aidandaly24@Hweinstock@notgitika