Skip to content

feat(dev): supervise every runtime in project dev - #2041

Merged
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor
Aug 25, 2026
Merged

feat(dev): supervise every runtime in project dev#2041
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review after #1980

What this does

agentcore project dev without --agent runs all of the project's runtimes at once. Each agent's output is attributed ([orders] ... in the terminal, an agent field in NDJSON); one agent crashing reports its failure and leaves the others running; Ctrl-C tears the whole set down. Selecting one runtime (--agent, or a single-runtime project) keeps the direct path where a crash fails the command — scripts and CI rely on that exit code.

How

DevSupervisor (core/dev/supervisor.ts) owns per-agent lifecycle: an abort scope per agent chained to the command signal, a per-agent state machine (idle/starting/running/failed) with start dedup, TCP readiness probing, and one merged attributed event stream. It's also what the Inspector UI slice (next PR) drives via its start-on-demand API. Ports resolve sequentially — concurrent resolution raced two HTTP agents onto the same port.

Verification

  • Supervisor: state machine, dedup, retry-after-failure, merge, crash isolation, abort chaining.
  • Handler with fake runners + fake collector, including runners that bind real TCP listeners so the readiness probe runs for real.
  • End to end: built the bundle, scaffolded a project, added a second runtime to agentcore.json, ran project dev — both agents started on distinct ports with attributed logs, both answered real Bedrock invocations, and the trace directory holds spans for both service names (per-runtime OTEL_SERVICE_NAME verified end to end). SIGTERM exits 130.

tsc/lint/format clean.

@github-actionsgithub-actionsBot added the size/l PR size: L label Aug 19, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.79518% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (e51a676) to head (ec9377c).
⚠️ Report is 1 commits behind head on refactor.

Files with missing linesPatch %Lines
src/handlers/project/dev/index.ts95.94%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2041 +/- ##
==========================================
Coverage 97.36% 97.37% ==========================================
Files 424 425 +1 Lines 25571 25761 +190 ==========================================
+ Hits 24897 25084 +187 - Misses 674 677 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat/dev-otel-collector to refactorAugust 21, 2026 21:32
@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from 7b4b60b to 0ca91f0CompareAugust 24, 2026 16:13
@Hweinstock

Copy link
Copy Markdown
Contributor

agentcore project dev without --agent runs all of the project's runtimes at once.

Is this the behavior on the publicly released CLI? I thought we always had to select one?

@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from fc5db62 to 9904ee1CompareAugust 24, 2026 21:51
@notgitika
notgitika self-requested a review August 24, 2026 22:14
The #1980 rebase carried a single-runtime host check (runtime.build) into
the multi-agent dev handler, where the variable is the runtimes array. Bind
all interfaces when any selected runtime runs in a container.
…batch
events() spliced the queue, yielded each event, then installed its wake
callback and blocked. A push landing during the yields ran while wake was
undefined, so its wake was a no-op, and the newly installed waiter never
noticed the queued event until the next push or shutdown. Re-check the queue
inside the wait so a queued event resolves immediately.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
…s review
Remove the runSingleRuntime special case so every runtime, one or many,
runs through DevSupervisor. Start all agents concurrently and stream their
output live rather than awaiting each readiness first. End the event loop
when no agent is starting or running, and exit non-zero when none started.
Make start() async so an unknown name rejects rather than throwing
synchronously. Time readiness off the agent's last output (idle timeout)
so a slow build that keeps logging is not killed. Move waitForPort into
src/io/port.ts to keep socket IO in the IO layer. Rename the environment
accessor to getDevEnvVarsForRuntime and SupervisedEvent.agent to agentName.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed claude-security-reviewing Claude Code /security-review in progress labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
Split renderEvent into renderAgentEvent (agent name required) and
renderStatus for command-level trace-collector lines, so agent output
is always tagged with [name] and the agent-optional branches are gone.
Addresses review feedback on #2041.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@tejaskash
tejaskash merged commit 1d96d1f into refactorAug 25, 2026
22 of 23 checks passed
@tejaskash
tejaskash deleted the feat/dev-supervisor branch August 25, 2026 20:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@Hweinstock@notgitika@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(dev): supervise every runtime in project dev by tejaskash · Pull Request #2041 · aws/agentcore-cli · GitHub
Skip to content

feat(dev): supervise every runtime in project dev - #2041

Merged
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor
Aug 25, 2026
Merged

feat(dev): supervise every runtime in project dev#2041
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review after #1980

What this does

agentcore project dev without --agent runs all of the project's runtimes at once. Each agent's output is attributed ([orders] ... in the terminal, an agent field in NDJSON); one agent crashing reports its failure and leaves the others running; Ctrl-C tears the whole set down. Selecting one runtime (--agent, or a single-runtime project) keeps the direct path where a crash fails the command — scripts and CI rely on that exit code.

How

DevSupervisor (core/dev/supervisor.ts) owns per-agent lifecycle: an abort scope per agent chained to the command signal, a per-agent state machine (idle/starting/running/failed) with start dedup, TCP readiness probing, and one merged attributed event stream. It's also what the Inspector UI slice (next PR) drives via its start-on-demand API. Ports resolve sequentially — concurrent resolution raced two HTTP agents onto the same port.

Verification

  • Supervisor: state machine, dedup, retry-after-failure, merge, crash isolation, abort chaining.
  • Handler with fake runners + fake collector, including runners that bind real TCP listeners so the readiness probe runs for real.
  • End to end: built the bundle, scaffolded a project, added a second runtime to agentcore.json, ran project dev — both agents started on distinct ports with attributed logs, both answered real Bedrock invocations, and the trace directory holds spans for both service names (per-runtime OTEL_SERVICE_NAME verified end to end). SIGTERM exits 130.

tsc/lint/format clean.

@github-actionsgithub-actionsBot added the size/l PR size: L label Aug 19, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.79518% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (e51a676) to head (ec9377c).
⚠️ Report is 1 commits behind head on refactor.

Files with missing linesPatch %Lines
src/handlers/project/dev/index.ts95.94%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2041 +/- ##
==========================================
Coverage 97.36% 97.37% ==========================================
Files 424 425 +1 Lines 25571 25761 +190 ==========================================
+ Hits 24897 25084 +187 - Misses 674 677 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat/dev-otel-collector to refactorAugust 21, 2026 21:32
@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from 7b4b60b to 0ca91f0CompareAugust 24, 2026 16:13
@Hweinstock

Copy link
Copy Markdown
Contributor

agentcore project dev without --agent runs all of the project's runtimes at once.

Is this the behavior on the publicly released CLI? I thought we always had to select one?

@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from fc5db62 to 9904ee1CompareAugust 24, 2026 21:51
@notgitika
notgitika self-requested a review August 24, 2026 22:14
The #1980 rebase carried a single-runtime host check (runtime.build) into
the multi-agent dev handler, where the variable is the runtimes array. Bind
all interfaces when any selected runtime runs in a container.
…batch
events() spliced the queue, yielded each event, then installed its wake
callback and blocked. A push landing during the yields ran while wake was
undefined, so its wake was a no-op, and the newly installed waiter never
noticed the queued event until the next push or shutdown. Re-check the queue
inside the wait so a queued event resolves immediately.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
…s review
Remove the runSingleRuntime special case so every runtime, one or many,
runs through DevSupervisor. Start all agents concurrently and stream their
output live rather than awaiting each readiness first. End the event loop
when no agent is starting or running, and exit non-zero when none started.
Make start() async so an unknown name rejects rather than throwing
synchronously. Time readiness off the agent's last output (idle timeout)
so a slow build that keeps logging is not killed. Move waitForPort into
src/io/port.ts to keep socket IO in the IO layer. Rename the environment
accessor to getDevEnvVarsForRuntime and SupervisedEvent.agent to agentName.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed claude-security-reviewing Claude Code /security-review in progress labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
Split renderEvent into renderAgentEvent (agent name required) and
renderStatus for command-level trace-collector lines, so agent output
is always tagged with [name] and the agent-optional branches are gone.
Addresses review feedback on #2041.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@tejaskash
tejaskash merged commit 1d96d1f into refactorAug 25, 2026
22 of 23 checks passed
@tejaskash
tejaskash deleted the feat/dev-supervisor branch August 25, 2026 20:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@Hweinstock@notgitika@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(dev): supervise every runtime in project dev by tejaskash · Pull Request #2041 · aws/agentcore-cli · GitHub
Skip to content

feat(dev): supervise every runtime in project dev - #2041

Merged
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor
Aug 25, 2026
Merged

feat(dev): supervise every runtime in project dev#2041
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review after #1980

What this does

agentcore project dev without --agent runs all of the project's runtimes at once. Each agent's output is attributed ([orders] ... in the terminal, an agent field in NDJSON); one agent crashing reports its failure and leaves the others running; Ctrl-C tears the whole set down. Selecting one runtime (--agent, or a single-runtime project) keeps the direct path where a crash fails the command — scripts and CI rely on that exit code.

How

DevSupervisor (core/dev/supervisor.ts) owns per-agent lifecycle: an abort scope per agent chained to the command signal, a per-agent state machine (idle/starting/running/failed) with start dedup, TCP readiness probing, and one merged attributed event stream. It's also what the Inspector UI slice (next PR) drives via its start-on-demand API. Ports resolve sequentially — concurrent resolution raced two HTTP agents onto the same port.

Verification

  • Supervisor: state machine, dedup, retry-after-failure, merge, crash isolation, abort chaining.
  • Handler with fake runners + fake collector, including runners that bind real TCP listeners so the readiness probe runs for real.
  • End to end: built the bundle, scaffolded a project, added a second runtime to agentcore.json, ran project dev — both agents started on distinct ports with attributed logs, both answered real Bedrock invocations, and the trace directory holds spans for both service names (per-runtime OTEL_SERVICE_NAME verified end to end). SIGTERM exits 130.

tsc/lint/format clean.

@github-actionsgithub-actionsBot added the size/l PR size: L label Aug 19, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.79518% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (e51a676) to head (ec9377c).
⚠️ Report is 1 commits behind head on refactor.

Files with missing linesPatch %Lines
src/handlers/project/dev/index.ts95.94%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2041 +/- ##
==========================================
Coverage 97.36% 97.37% ==========================================
Files 424 425 +1 Lines 25571 25761 +190 ==========================================
+ Hits 24897 25084 +187 - Misses 674 677 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat/dev-otel-collector to refactorAugust 21, 2026 21:32
@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from 7b4b60b to 0ca91f0CompareAugust 24, 2026 16:13
@Hweinstock

Copy link
Copy Markdown
Contributor

agentcore project dev without --agent runs all of the project's runtimes at once.

Is this the behavior on the publicly released CLI? I thought we always had to select one?

@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from fc5db62 to 9904ee1CompareAugust 24, 2026 21:51
@notgitika
notgitika self-requested a review August 24, 2026 22:14
The #1980 rebase carried a single-runtime host check (runtime.build) into
the multi-agent dev handler, where the variable is the runtimes array. Bind
all interfaces when any selected runtime runs in a container.
…batch
events() spliced the queue, yielded each event, then installed its wake
callback and blocked. A push landing during the yields ran while wake was
undefined, so its wake was a no-op, and the newly installed waiter never
noticed the queued event until the next push or shutdown. Re-check the queue
inside the wait so a queued event resolves immediately.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
…s review
Remove the runSingleRuntime special case so every runtime, one or many,
runs through DevSupervisor. Start all agents concurrently and stream their
output live rather than awaiting each readiness first. End the event loop
when no agent is starting or running, and exit non-zero when none started.
Make start() async so an unknown name rejects rather than throwing
synchronously. Time readiness off the agent's last output (idle timeout)
so a slow build that keeps logging is not killed. Move waitForPort into
src/io/port.ts to keep socket IO in the IO layer. Rename the environment
accessor to getDevEnvVarsForRuntime and SupervisedEvent.agent to agentName.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed claude-security-reviewing Claude Code /security-review in progress labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
Split renderEvent into renderAgentEvent (agent name required) and
renderStatus for command-level trace-collector lines, so agent output
is always tagged with [name] and the agent-optional branches are gone.
Addresses review feedback on #2041.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@tejaskash
tejaskash merged commit 1d96d1f into refactorAug 25, 2026
22 of 23 checks passed
@tejaskash
tejaskash deleted the feat/dev-supervisor branch August 25, 2026 20:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@Hweinstock@notgitika@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(dev): supervise every runtime in project dev by tejaskash · Pull Request #2041 · aws/agentcore-cli · GitHub
Skip to content

feat(dev): supervise every runtime in project dev - #2041

Merged
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor
Aug 25, 2026
Merged

feat(dev): supervise every runtime in project dev#2041
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review after #1980

What this does

agentcore project dev without --agent runs all of the project's runtimes at once. Each agent's output is attributed ([orders] ... in the terminal, an agent field in NDJSON); one agent crashing reports its failure and leaves the others running; Ctrl-C tears the whole set down. Selecting one runtime (--agent, or a single-runtime project) keeps the direct path where a crash fails the command — scripts and CI rely on that exit code.

How

DevSupervisor (core/dev/supervisor.ts) owns per-agent lifecycle: an abort scope per agent chained to the command signal, a per-agent state machine (idle/starting/running/failed) with start dedup, TCP readiness probing, and one merged attributed event stream. It's also what the Inspector UI slice (next PR) drives via its start-on-demand API. Ports resolve sequentially — concurrent resolution raced two HTTP agents onto the same port.

Verification

  • Supervisor: state machine, dedup, retry-after-failure, merge, crash isolation, abort chaining.
  • Handler with fake runners + fake collector, including runners that bind real TCP listeners so the readiness probe runs for real.
  • End to end: built the bundle, scaffolded a project, added a second runtime to agentcore.json, ran project dev — both agents started on distinct ports with attributed logs, both answered real Bedrock invocations, and the trace directory holds spans for both service names (per-runtime OTEL_SERVICE_NAME verified end to end). SIGTERM exits 130.

tsc/lint/format clean.

@github-actionsgithub-actionsBot added the size/l PR size: L label Aug 19, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.79518% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (e51a676) to head (ec9377c).
⚠️ Report is 1 commits behind head on refactor.

Files with missing linesPatch %Lines
src/handlers/project/dev/index.ts95.94%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2041 +/- ##
==========================================
Coverage 97.36% 97.37% ==========================================
Files 424 425 +1 Lines 25571 25761 +190 ==========================================
+ Hits 24897 25084 +187 - Misses 674 677 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat/dev-otel-collector to refactorAugust 21, 2026 21:32
@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from 7b4b60b to 0ca91f0CompareAugust 24, 2026 16:13
@Hweinstock

Copy link
Copy Markdown
Contributor

agentcore project dev without --agent runs all of the project's runtimes at once.

Is this the behavior on the publicly released CLI? I thought we always had to select one?

@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from fc5db62 to 9904ee1CompareAugust 24, 2026 21:51
@notgitika
notgitika self-requested a review August 24, 2026 22:14
The #1980 rebase carried a single-runtime host check (runtime.build) into
the multi-agent dev handler, where the variable is the runtimes array. Bind
all interfaces when any selected runtime runs in a container.
…batch
events() spliced the queue, yielded each event, then installed its wake
callback and blocked. A push landing during the yields ran while wake was
undefined, so its wake was a no-op, and the newly installed waiter never
noticed the queued event until the next push or shutdown. Re-check the queue
inside the wait so a queued event resolves immediately.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
…s review
Remove the runSingleRuntime special case so every runtime, one or many,
runs through DevSupervisor. Start all agents concurrently and stream their
output live rather than awaiting each readiness first. End the event loop
when no agent is starting or running, and exit non-zero when none started.
Make start() async so an unknown name rejects rather than throwing
synchronously. Time readiness off the agent's last output (idle timeout)
so a slow build that keeps logging is not killed. Move waitForPort into
src/io/port.ts to keep socket IO in the IO layer. Rename the environment
accessor to getDevEnvVarsForRuntime and SupervisedEvent.agent to agentName.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed claude-security-reviewing Claude Code /security-review in progress labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
Split renderEvent into renderAgentEvent (agent name required) and
renderStatus for command-level trace-collector lines, so agent output
is always tagged with [name] and the agent-optional branches are gone.
Addresses review feedback on #2041.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@tejaskash
tejaskash merged commit 1d96d1f into refactorAug 25, 2026
22 of 23 checks passed
@tejaskash
tejaskash deleted the feat/dev-supervisor branch August 25, 2026 20:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@Hweinstock@notgitika@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(dev): supervise every runtime in project dev by tejaskash · Pull Request #2041 · aws/agentcore-cli · GitHub
Skip to content

feat(dev): supervise every runtime in project dev - #2041

Merged
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor
Aug 25, 2026
Merged

feat(dev): supervise every runtime in project dev#2041
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review after #1980

What this does

agentcore project dev without --agent runs all of the project's runtimes at once. Each agent's output is attributed ([orders] ... in the terminal, an agent field in NDJSON); one agent crashing reports its failure and leaves the others running; Ctrl-C tears the whole set down. Selecting one runtime (--agent, or a single-runtime project) keeps the direct path where a crash fails the command — scripts and CI rely on that exit code.

How

DevSupervisor (core/dev/supervisor.ts) owns per-agent lifecycle: an abort scope per agent chained to the command signal, a per-agent state machine (idle/starting/running/failed) with start dedup, TCP readiness probing, and one merged attributed event stream. It's also what the Inspector UI slice (next PR) drives via its start-on-demand API. Ports resolve sequentially — concurrent resolution raced two HTTP agents onto the same port.

Verification

  • Supervisor: state machine, dedup, retry-after-failure, merge, crash isolation, abort chaining.
  • Handler with fake runners + fake collector, including runners that bind real TCP listeners so the readiness probe runs for real.
  • End to end: built the bundle, scaffolded a project, added a second runtime to agentcore.json, ran project dev — both agents started on distinct ports with attributed logs, both answered real Bedrock invocations, and the trace directory holds spans for both service names (per-runtime OTEL_SERVICE_NAME verified end to end). SIGTERM exits 130.

tsc/lint/format clean.

@github-actionsgithub-actionsBot added the size/l PR size: L label Aug 19, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.79518% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (e51a676) to head (ec9377c).
⚠️ Report is 1 commits behind head on refactor.

Files with missing linesPatch %Lines
src/handlers/project/dev/index.ts95.94%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2041 +/- ##
==========================================
Coverage 97.36% 97.37% ==========================================
Files 424 425 +1 Lines 25571 25761 +190 ==========================================
+ Hits 24897 25084 +187 - Misses 674 677 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat/dev-otel-collector to refactorAugust 21, 2026 21:32
@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from 7b4b60b to 0ca91f0CompareAugust 24, 2026 16:13
@Hweinstock

Copy link
Copy Markdown
Contributor

agentcore project dev without --agent runs all of the project's runtimes at once.

Is this the behavior on the publicly released CLI? I thought we always had to select one?

@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from fc5db62 to 9904ee1CompareAugust 24, 2026 21:51
@notgitika
notgitika self-requested a review August 24, 2026 22:14
The #1980 rebase carried a single-runtime host check (runtime.build) into
the multi-agent dev handler, where the variable is the runtimes array. Bind
all interfaces when any selected runtime runs in a container.
…batch
events() spliced the queue, yielded each event, then installed its wake
callback and blocked. A push landing during the yields ran while wake was
undefined, so its wake was a no-op, and the newly installed waiter never
noticed the queued event until the next push or shutdown. Re-check the queue
inside the wait so a queued event resolves immediately.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
…s review
Remove the runSingleRuntime special case so every runtime, one or many,
runs through DevSupervisor. Start all agents concurrently and stream their
output live rather than awaiting each readiness first. End the event loop
when no agent is starting or running, and exit non-zero when none started.
Make start() async so an unknown name rejects rather than throwing
synchronously. Time readiness off the agent's last output (idle timeout)
so a slow build that keeps logging is not killed. Move waitForPort into
src/io/port.ts to keep socket IO in the IO layer. Rename the environment
accessor to getDevEnvVarsForRuntime and SupervisedEvent.agent to agentName.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed claude-security-reviewing Claude Code /security-review in progress labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
Split renderEvent into renderAgentEvent (agent name required) and
renderStatus for command-level trace-collector lines, so agent output
is always tagged with [name] and the agent-optional branches are gone.
Addresses review feedback on #2041.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@tejaskash
tejaskash merged commit 1d96d1f into refactorAug 25, 2026
22 of 23 checks passed
@tejaskash
tejaskash deleted the feat/dev-supervisor branch August 25, 2026 20:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@Hweinstock@notgitika@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(dev): supervise every runtime in project dev by tejaskash · Pull Request #2041 · aws/agentcore-cli · GitHub
Skip to content

feat(dev): supervise every runtime in project dev - #2041

Merged
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor
Aug 25, 2026
Merged

feat(dev): supervise every runtime in project dev#2041
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review after #1980

What this does

agentcore project dev without --agent runs all of the project's runtimes at once. Each agent's output is attributed ([orders] ... in the terminal, an agent field in NDJSON); one agent crashing reports its failure and leaves the others running; Ctrl-C tears the whole set down. Selecting one runtime (--agent, or a single-runtime project) keeps the direct path where a crash fails the command — scripts and CI rely on that exit code.

How

DevSupervisor (core/dev/supervisor.ts) owns per-agent lifecycle: an abort scope per agent chained to the command signal, a per-agent state machine (idle/starting/running/failed) with start dedup, TCP readiness probing, and one merged attributed event stream. It's also what the Inspector UI slice (next PR) drives via its start-on-demand API. Ports resolve sequentially — concurrent resolution raced two HTTP agents onto the same port.

Verification

  • Supervisor: state machine, dedup, retry-after-failure, merge, crash isolation, abort chaining.
  • Handler with fake runners + fake collector, including runners that bind real TCP listeners so the readiness probe runs for real.
  • End to end: built the bundle, scaffolded a project, added a second runtime to agentcore.json, ran project dev — both agents started on distinct ports with attributed logs, both answered real Bedrock invocations, and the trace directory holds spans for both service names (per-runtime OTEL_SERVICE_NAME verified end to end). SIGTERM exits 130.

tsc/lint/format clean.

@github-actionsgithub-actionsBot added the size/l PR size: L label Aug 19, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.79518% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (e51a676) to head (ec9377c).
⚠️ Report is 1 commits behind head on refactor.

Files with missing linesPatch %Lines
src/handlers/project/dev/index.ts95.94%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2041 +/- ##
==========================================
Coverage 97.36% 97.37% ==========================================
Files 424 425 +1 Lines 25571 25761 +190 ==========================================
+ Hits 24897 25084 +187 - Misses 674 677 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat/dev-otel-collector to refactorAugust 21, 2026 21:32
@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from 7b4b60b to 0ca91f0CompareAugust 24, 2026 16:13
@Hweinstock

Copy link
Copy Markdown
Contributor

agentcore project dev without --agent runs all of the project's runtimes at once.

Is this the behavior on the publicly released CLI? I thought we always had to select one?

@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from fc5db62 to 9904ee1CompareAugust 24, 2026 21:51
@notgitika
notgitika self-requested a review August 24, 2026 22:14
The #1980 rebase carried a single-runtime host check (runtime.build) into
the multi-agent dev handler, where the variable is the runtimes array. Bind
all interfaces when any selected runtime runs in a container.
…batch
events() spliced the queue, yielded each event, then installed its wake
callback and blocked. A push landing during the yields ran while wake was
undefined, so its wake was a no-op, and the newly installed waiter never
noticed the queued event until the next push or shutdown. Re-check the queue
inside the wait so a queued event resolves immediately.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
…s review
Remove the runSingleRuntime special case so every runtime, one or many,
runs through DevSupervisor. Start all agents concurrently and stream their
output live rather than awaiting each readiness first. End the event loop
when no agent is starting or running, and exit non-zero when none started.
Make start() async so an unknown name rejects rather than throwing
synchronously. Time readiness off the agent's last output (idle timeout)
so a slow build that keeps logging is not killed. Move waitForPort into
src/io/port.ts to keep socket IO in the IO layer. Rename the environment
accessor to getDevEnvVarsForRuntime and SupervisedEvent.agent to agentName.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed claude-security-reviewing Claude Code /security-review in progress labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
Split renderEvent into renderAgentEvent (agent name required) and
renderStatus for command-level trace-collector lines, so agent output
is always tagged with [name] and the agent-optional branches are gone.
Addresses review feedback on #2041.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@tejaskash
tejaskash merged commit 1d96d1f into refactorAug 25, 2026
22 of 23 checks passed
@tejaskash
tejaskash deleted the feat/dev-supervisor branch August 25, 2026 20:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@Hweinstock@notgitika@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(dev): supervise every runtime in project dev by tejaskash · Pull Request #2041 · aws/agentcore-cli · GitHub
Skip to content

feat(dev): supervise every runtime in project dev - #2041

Merged
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor
Aug 25, 2026
Merged

feat(dev): supervise every runtime in project dev#2041
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review after #1980

What this does

agentcore project dev without --agent runs all of the project's runtimes at once. Each agent's output is attributed ([orders] ... in the terminal, an agent field in NDJSON); one agent crashing reports its failure and leaves the others running; Ctrl-C tears the whole set down. Selecting one runtime (--agent, or a single-runtime project) keeps the direct path where a crash fails the command — scripts and CI rely on that exit code.

How

DevSupervisor (core/dev/supervisor.ts) owns per-agent lifecycle: an abort scope per agent chained to the command signal, a per-agent state machine (idle/starting/running/failed) with start dedup, TCP readiness probing, and one merged attributed event stream. It's also what the Inspector UI slice (next PR) drives via its start-on-demand API. Ports resolve sequentially — concurrent resolution raced two HTTP agents onto the same port.

Verification

  • Supervisor: state machine, dedup, retry-after-failure, merge, crash isolation, abort chaining.
  • Handler with fake runners + fake collector, including runners that bind real TCP listeners so the readiness probe runs for real.
  • End to end: built the bundle, scaffolded a project, added a second runtime to agentcore.json, ran project dev — both agents started on distinct ports with attributed logs, both answered real Bedrock invocations, and the trace directory holds spans for both service names (per-runtime OTEL_SERVICE_NAME verified end to end). SIGTERM exits 130.

tsc/lint/format clean.

@github-actionsgithub-actionsBot added the size/l PR size: L label Aug 19, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.79518% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (e51a676) to head (ec9377c).
⚠️ Report is 1 commits behind head on refactor.

Files with missing linesPatch %Lines
src/handlers/project/dev/index.ts95.94%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2041 +/- ##
==========================================
Coverage 97.36% 97.37% ==========================================
Files 424 425 +1 Lines 25571 25761 +190 ==========================================
+ Hits 24897 25084 +187 - Misses 674 677 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat/dev-otel-collector to refactorAugust 21, 2026 21:32
@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from 7b4b60b to 0ca91f0CompareAugust 24, 2026 16:13
@Hweinstock

Copy link
Copy Markdown
Contributor

agentcore project dev without --agent runs all of the project's runtimes at once.

Is this the behavior on the publicly released CLI? I thought we always had to select one?

@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from fc5db62 to 9904ee1CompareAugust 24, 2026 21:51
@notgitika
notgitika self-requested a review August 24, 2026 22:14
The #1980 rebase carried a single-runtime host check (runtime.build) into
the multi-agent dev handler, where the variable is the runtimes array. Bind
all interfaces when any selected runtime runs in a container.
…batch
events() spliced the queue, yielded each event, then installed its wake
callback and blocked. A push landing during the yields ran while wake was
undefined, so its wake was a no-op, and the newly installed waiter never
noticed the queued event until the next push or shutdown. Re-check the queue
inside the wait so a queued event resolves immediately.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
…s review
Remove the runSingleRuntime special case so every runtime, one or many,
runs through DevSupervisor. Start all agents concurrently and stream their
output live rather than awaiting each readiness first. End the event loop
when no agent is starting or running, and exit non-zero when none started.
Make start() async so an unknown name rejects rather than throwing
synchronously. Time readiness off the agent's last output (idle timeout)
so a slow build that keeps logging is not killed. Move waitForPort into
src/io/port.ts to keep socket IO in the IO layer. Rename the environment
accessor to getDevEnvVarsForRuntime and SupervisedEvent.agent to agentName.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed claude-security-reviewing Claude Code /security-review in progress labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
Split renderEvent into renderAgentEvent (agent name required) and
renderStatus for command-level trace-collector lines, so agent output
is always tagged with [name] and the agent-optional branches are gone.
Addresses review feedback on #2041.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@tejaskash
tejaskash merged commit 1d96d1f into refactorAug 25, 2026
22 of 23 checks passed
@tejaskash
tejaskash deleted the feat/dev-supervisor branch August 25, 2026 20:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@Hweinstock@notgitika@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(dev): supervise every runtime in project dev by tejaskash · Pull Request #2041 · aws/agentcore-cli · GitHub
Skip to content

feat(dev): supervise every runtime in project dev - #2041

Merged
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor
Aug 25, 2026
Merged

feat(dev): supervise every runtime in project dev#2041
tejaskash merged 6 commits into
refactorfrom
feat/dev-supervisor

Conversation

@tejaskash

@tejaskashtejaskash commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review after #1980

What this does

agentcore project dev without --agent runs all of the project's runtimes at once. Each agent's output is attributed ([orders] ... in the terminal, an agent field in NDJSON); one agent crashing reports its failure and leaves the others running; Ctrl-C tears the whole set down. Selecting one runtime (--agent, or a single-runtime project) keeps the direct path where a crash fails the command — scripts and CI rely on that exit code.

How

DevSupervisor (core/dev/supervisor.ts) owns per-agent lifecycle: an abort scope per agent chained to the command signal, a per-agent state machine (idle/starting/running/failed) with start dedup, TCP readiness probing, and one merged attributed event stream. It's also what the Inspector UI slice (next PR) drives via its start-on-demand API. Ports resolve sequentially — concurrent resolution raced two HTTP agents onto the same port.

Verification

  • Supervisor: state machine, dedup, retry-after-failure, merge, crash isolation, abort chaining.
  • Handler with fake runners + fake collector, including runners that bind real TCP listeners so the readiness probe runs for real.
  • End to end: built the bundle, scaffolded a project, added a second runtime to agentcore.json, ran project dev — both agents started on distinct ports with attributed logs, both answered real Bedrock invocations, and the trace directory holds spans for both service names (per-runtime OTEL_SERVICE_NAME verified end to end). SIGTERM exits 130.

tsc/lint/format clean.

@github-actionsgithub-actionsBot added the size/l PR size: L label Aug 19, 2026
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 19, 2026
@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.79518% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (e51a676) to head (ec9377c).
⚠️ Report is 1 commits behind head on refactor.

Files with missing linesPatch %Lines
src/handlers/project/dev/index.ts95.94%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2041 +/- ##
==========================================
Coverage 97.36% 97.37% ==========================================
Files 424 425 +1 Lines 25571 25761 +190 ==========================================
+ Hits 24897 25084 +187 - Misses 674 677 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat/dev-otel-collector to refactorAugust 21, 2026 21:32
@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from 7b4b60b to 0ca91f0CompareAugust 24, 2026 16:13
@Hweinstock

Copy link
Copy Markdown
Contributor

agentcore project dev without --agent runs all of the project's runtimes at once.

Is this the behavior on the publicly released CLI? I thought we always had to select one?

@tejaskash
tejaskashforce-pushed the feat/dev-supervisor branch 2 times, most recently from fc5db62 to 9904ee1CompareAugust 24, 2026 21:51
@notgitika
notgitika self-requested a review August 24, 2026 22:14
The #1980 rebase carried a single-runtime host check (runtime.build) into
the multi-agent dev handler, where the variable is the runtimes array. Bind
all interfaces when any selected runtime runs in a container.
…batch
events() spliced the queue, yielded each event, then installed its wake
callback and blocked. A push landing during the yields ran while wake was
undefined, so its wake was a no-op, and the newly installed waiter never
noticed the queued event until the next push or shutdown. Re-check the queue
inside the wait so a queued event resolves immediately.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
…s review
Remove the runSingleRuntime special case so every runtime, one or many,
runs through DevSupervisor. Start all agents concurrently and stream their
output live rather than awaiting each readiness first. End the event loop
when no agent is starting or running, and exit non-zero when none started.
Make start() async so an unknown name rejects rather than throwing
synchronously. Time readiness off the agent's last output (idle timeout)
so a slow build that keeps logging is not killed. Move waitForPort into
src/io/port.ts to keep socket IO in the IO layer. Rename the environment
accessor to getDevEnvVarsForRuntime and SupervisedEvent.agent to agentName.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress and removed claude-security-reviewing Claude Code /security-review in progress labels Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
Split renderEvent into renderAgentEvent (agent name required) and
renderStatus for command-level trace-collector lines, so agent output
is always tagged with [name] and the agent-optional branches are gone.
Addresses review feedback on #2041.
@github-actionsgithub-actionsBot added size/l PR size: L and removed size/l PR size: L labels Aug 25, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 25, 2026
@tejaskash
tejaskash merged commit 1d96d1f into refactorAug 25, 2026
22 of 23 checks passed
@tejaskash
tejaskash deleted the feat/dev-supervisor branch August 25, 2026 20:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lPR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tejaskash@codecov-commenter@Hweinstock@notgitika@jariy17