Skip to content

fix(dev): cancel readiness retries on abort - #2109

Merged
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test
Aug 26, 2026
Merged

fix(dev): cancel readiness retries on abort#2109
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test

Conversation

@Hweinstock

@HweinstockHweinstock commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Problem

waitForPort left active sockets and scheduled retries alive after abort. In CI, the supervisor's 60ms abort test instead ran for about 60 seconds and timed out; the original #2041 Windows run eventually lost its runner.

Solution

Abort now destroys the active socket, clears the pending retry, removes its listener, and rejects immediately. The TCP test also closes accepted sockets and awaits listener shutdown.

Testing

  • Windows unit CI passed in 3m24s.
  • Supervisor suite passed 25 consecutive runs; the abort test completes in about 60ms.
  • Supervisor, project dev, and port tests passed: 31/31.
  • Prettier and tsc --noEmit passed.

@github-actionsgithub-actionsBot added the size/xs PR size: XS label Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, well-scoped test-only fix. The change correctly addresses both sides of the lingering handle problem:

  1. createServer((socket) => socket.destroy())waitForPort opens a real TCP connection (src/io/port.ts:60) that the server accepts. Previously nothing destroyed the server-side accepted socket, so its handle could keep Bun's event loop alive on Windows.
  2. Awaiting server.close() via its callback ensures the listener is fully released before the test returns, rather than relying on the previous fire-and-forget call.

The PR description accurately explains the Windows CI hang, the fix matches the described root cause, and no production code is touched. Nothing to change here.

@agentcore-devx-automationagentcore-devx-automationBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.41%. Comparing base (f1a651c) to head (5ae5799).

Files with missing linesPatch %Lines
src/io/port.ts85.71%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2109 +/- ##
============================================
- Coverage 97.42% 97.41% -0.02% 
============================================
Files 429 429 Lines 26314 26330 +16 ============================================
+ Hits 25637 25649 +12 - Misses 677 681 +4 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@HweinstockHweinstock changed the title fix(test): await readiness server shutdownfix(dev): abort readiness socket attemptsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): abort readiness socket attemptsfix(dev): cancel active readiness socketsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): cancel active readiness socketsfix(dev): cancel readiness retries on abortAug 26, 2026
@github-actionsgithub-actionsBot added size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@Hweinstock

Copy link
Copy Markdown
ContributorAuthor

Related: #2110

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Aug 26, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review August 26, 2026 12:58

@tejaskashtejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jariy17
jariy17 merged commit 097e1f0 into aws:refactorAug 26, 2026
27 of 30 checks passed
@Hweinstock
Hweinstock deleted the fix/windows-test branch August 26, 2026 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Hweinstock@codecov-commenter@tejaskash@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(dev): cancel readiness retries on abort by Hweinstock · Pull Request #2109 · aws/agentcore-cli · GitHub
Skip to content

fix(dev): cancel readiness retries on abort - #2109

Merged
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test
Aug 26, 2026
Merged

fix(dev): cancel readiness retries on abort#2109
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test

Conversation

@Hweinstock

@HweinstockHweinstock commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Problem

waitForPort left active sockets and scheduled retries alive after abort. In CI, the supervisor's 60ms abort test instead ran for about 60 seconds and timed out; the original #2041 Windows run eventually lost its runner.

Solution

Abort now destroys the active socket, clears the pending retry, removes its listener, and rejects immediately. The TCP test also closes accepted sockets and awaits listener shutdown.

Testing

  • Windows unit CI passed in 3m24s.
  • Supervisor suite passed 25 consecutive runs; the abort test completes in about 60ms.
  • Supervisor, project dev, and port tests passed: 31/31.
  • Prettier and tsc --noEmit passed.

@github-actionsgithub-actionsBot added the size/xs PR size: XS label Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, well-scoped test-only fix. The change correctly addresses both sides of the lingering handle problem:

  1. createServer((socket) => socket.destroy())waitForPort opens a real TCP connection (src/io/port.ts:60) that the server accepts. Previously nothing destroyed the server-side accepted socket, so its handle could keep Bun's event loop alive on Windows.
  2. Awaiting server.close() via its callback ensures the listener is fully released before the test returns, rather than relying on the previous fire-and-forget call.

The PR description accurately explains the Windows CI hang, the fix matches the described root cause, and no production code is touched. Nothing to change here.

@agentcore-devx-automationagentcore-devx-automationBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.41%. Comparing base (f1a651c) to head (5ae5799).

Files with missing linesPatch %Lines
src/io/port.ts85.71%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2109 +/- ##
============================================
- Coverage 97.42% 97.41% -0.02% 
============================================
Files 429 429 Lines 26314 26330 +16 ============================================
+ Hits 25637 25649 +12 - Misses 677 681 +4 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@HweinstockHweinstock changed the title fix(test): await readiness server shutdownfix(dev): abort readiness socket attemptsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): abort readiness socket attemptsfix(dev): cancel active readiness socketsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): cancel active readiness socketsfix(dev): cancel readiness retries on abortAug 26, 2026
@github-actionsgithub-actionsBot added size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@Hweinstock

Copy link
Copy Markdown
ContributorAuthor

Related: #2110

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Aug 26, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review August 26, 2026 12:58

@tejaskashtejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jariy17
jariy17 merged commit 097e1f0 into aws:refactorAug 26, 2026
27 of 30 checks passed
@Hweinstock
Hweinstock deleted the fix/windows-test branch August 26, 2026 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Hweinstock@codecov-commenter@tejaskash@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(dev): cancel readiness retries on abort by Hweinstock · Pull Request #2109 · aws/agentcore-cli · GitHub
Skip to content

fix(dev): cancel readiness retries on abort - #2109

Merged
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test
Aug 26, 2026
Merged

fix(dev): cancel readiness retries on abort#2109
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test

Conversation

@Hweinstock

@HweinstockHweinstock commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Problem

waitForPort left active sockets and scheduled retries alive after abort. In CI, the supervisor's 60ms abort test instead ran for about 60 seconds and timed out; the original #2041 Windows run eventually lost its runner.

Solution

Abort now destroys the active socket, clears the pending retry, removes its listener, and rejects immediately. The TCP test also closes accepted sockets and awaits listener shutdown.

Testing

  • Windows unit CI passed in 3m24s.
  • Supervisor suite passed 25 consecutive runs; the abort test completes in about 60ms.
  • Supervisor, project dev, and port tests passed: 31/31.
  • Prettier and tsc --noEmit passed.

@github-actionsgithub-actionsBot added the size/xs PR size: XS label Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, well-scoped test-only fix. The change correctly addresses both sides of the lingering handle problem:

  1. createServer((socket) => socket.destroy())waitForPort opens a real TCP connection (src/io/port.ts:60) that the server accepts. Previously nothing destroyed the server-side accepted socket, so its handle could keep Bun's event loop alive on Windows.
  2. Awaiting server.close() via its callback ensures the listener is fully released before the test returns, rather than relying on the previous fire-and-forget call.

The PR description accurately explains the Windows CI hang, the fix matches the described root cause, and no production code is touched. Nothing to change here.

@agentcore-devx-automationagentcore-devx-automationBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.41%. Comparing base (f1a651c) to head (5ae5799).

Files with missing linesPatch %Lines
src/io/port.ts85.71%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2109 +/- ##
============================================
- Coverage 97.42% 97.41% -0.02% 
============================================
Files 429 429 Lines 26314 26330 +16 ============================================
+ Hits 25637 25649 +12 - Misses 677 681 +4 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@HweinstockHweinstock changed the title fix(test): await readiness server shutdownfix(dev): abort readiness socket attemptsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): abort readiness socket attemptsfix(dev): cancel active readiness socketsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): cancel active readiness socketsfix(dev): cancel readiness retries on abortAug 26, 2026
@github-actionsgithub-actionsBot added size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@Hweinstock

Copy link
Copy Markdown
ContributorAuthor

Related: #2110

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Aug 26, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review August 26, 2026 12:58

@tejaskashtejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jariy17
jariy17 merged commit 097e1f0 into aws:refactorAug 26, 2026
27 of 30 checks passed
@Hweinstock
Hweinstock deleted the fix/windows-test branch August 26, 2026 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Hweinstock@codecov-commenter@tejaskash@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(dev): cancel readiness retries on abort by Hweinstock · Pull Request #2109 · aws/agentcore-cli · GitHub
Skip to content

fix(dev): cancel readiness retries on abort - #2109

Merged
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test
Aug 26, 2026
Merged

fix(dev): cancel readiness retries on abort#2109
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test

Conversation

@Hweinstock

@HweinstockHweinstock commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Problem

waitForPort left active sockets and scheduled retries alive after abort. In CI, the supervisor's 60ms abort test instead ran for about 60 seconds and timed out; the original #2041 Windows run eventually lost its runner.

Solution

Abort now destroys the active socket, clears the pending retry, removes its listener, and rejects immediately. The TCP test also closes accepted sockets and awaits listener shutdown.

Testing

  • Windows unit CI passed in 3m24s.
  • Supervisor suite passed 25 consecutive runs; the abort test completes in about 60ms.
  • Supervisor, project dev, and port tests passed: 31/31.
  • Prettier and tsc --noEmit passed.

@github-actionsgithub-actionsBot added the size/xs PR size: XS label Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, well-scoped test-only fix. The change correctly addresses both sides of the lingering handle problem:

  1. createServer((socket) => socket.destroy())waitForPort opens a real TCP connection (src/io/port.ts:60) that the server accepts. Previously nothing destroyed the server-side accepted socket, so its handle could keep Bun's event loop alive on Windows.
  2. Awaiting server.close() via its callback ensures the listener is fully released before the test returns, rather than relying on the previous fire-and-forget call.

The PR description accurately explains the Windows CI hang, the fix matches the described root cause, and no production code is touched. Nothing to change here.

@agentcore-devx-automationagentcore-devx-automationBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.41%. Comparing base (f1a651c) to head (5ae5799).

Files with missing linesPatch %Lines
src/io/port.ts85.71%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2109 +/- ##
============================================
- Coverage 97.42% 97.41% -0.02% 
============================================
Files 429 429 Lines 26314 26330 +16 ============================================
+ Hits 25637 25649 +12 - Misses 677 681 +4 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@HweinstockHweinstock changed the title fix(test): await readiness server shutdownfix(dev): abort readiness socket attemptsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): abort readiness socket attemptsfix(dev): cancel active readiness socketsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): cancel active readiness socketsfix(dev): cancel readiness retries on abortAug 26, 2026
@github-actionsgithub-actionsBot added size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@Hweinstock

Copy link
Copy Markdown
ContributorAuthor

Related: #2110

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Aug 26, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review August 26, 2026 12:58

@tejaskashtejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jariy17
jariy17 merged commit 097e1f0 into aws:refactorAug 26, 2026
27 of 30 checks passed
@Hweinstock
Hweinstock deleted the fix/windows-test branch August 26, 2026 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Hweinstock@codecov-commenter@tejaskash@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(dev): cancel readiness retries on abort by Hweinstock · Pull Request #2109 · aws/agentcore-cli · GitHub
Skip to content

fix(dev): cancel readiness retries on abort - #2109

Merged
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test
Aug 26, 2026
Merged

fix(dev): cancel readiness retries on abort#2109
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test

Conversation

@Hweinstock

@HweinstockHweinstock commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Problem

waitForPort left active sockets and scheduled retries alive after abort. In CI, the supervisor's 60ms abort test instead ran for about 60 seconds and timed out; the original #2041 Windows run eventually lost its runner.

Solution

Abort now destroys the active socket, clears the pending retry, removes its listener, and rejects immediately. The TCP test also closes accepted sockets and awaits listener shutdown.

Testing

  • Windows unit CI passed in 3m24s.
  • Supervisor suite passed 25 consecutive runs; the abort test completes in about 60ms.
  • Supervisor, project dev, and port tests passed: 31/31.
  • Prettier and tsc --noEmit passed.

@github-actionsgithub-actionsBot added the size/xs PR size: XS label Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, well-scoped test-only fix. The change correctly addresses both sides of the lingering handle problem:

  1. createServer((socket) => socket.destroy())waitForPort opens a real TCP connection (src/io/port.ts:60) that the server accepts. Previously nothing destroyed the server-side accepted socket, so its handle could keep Bun's event loop alive on Windows.
  2. Awaiting server.close() via its callback ensures the listener is fully released before the test returns, rather than relying on the previous fire-and-forget call.

The PR description accurately explains the Windows CI hang, the fix matches the described root cause, and no production code is touched. Nothing to change here.

@agentcore-devx-automationagentcore-devx-automationBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.41%. Comparing base (f1a651c) to head (5ae5799).

Files with missing linesPatch %Lines
src/io/port.ts85.71%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2109 +/- ##
============================================
- Coverage 97.42% 97.41% -0.02% 
============================================
Files 429 429 Lines 26314 26330 +16 ============================================
+ Hits 25637 25649 +12 - Misses 677 681 +4 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@HweinstockHweinstock changed the title fix(test): await readiness server shutdownfix(dev): abort readiness socket attemptsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): abort readiness socket attemptsfix(dev): cancel active readiness socketsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): cancel active readiness socketsfix(dev): cancel readiness retries on abortAug 26, 2026
@github-actionsgithub-actionsBot added size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@Hweinstock

Copy link
Copy Markdown
ContributorAuthor

Related: #2110

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Aug 26, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review August 26, 2026 12:58

@tejaskashtejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jariy17
jariy17 merged commit 097e1f0 into aws:refactorAug 26, 2026
27 of 30 checks passed
@Hweinstock
Hweinstock deleted the fix/windows-test branch August 26, 2026 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Hweinstock@codecov-commenter@tejaskash@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(dev): cancel readiness retries on abort by Hweinstock · Pull Request #2109 · aws/agentcore-cli · GitHub
Skip to content

fix(dev): cancel readiness retries on abort - #2109

Merged
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test
Aug 26, 2026
Merged

fix(dev): cancel readiness retries on abort#2109
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test

Conversation

@Hweinstock

@HweinstockHweinstock commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Problem

waitForPort left active sockets and scheduled retries alive after abort. In CI, the supervisor's 60ms abort test instead ran for about 60 seconds and timed out; the original #2041 Windows run eventually lost its runner.

Solution

Abort now destroys the active socket, clears the pending retry, removes its listener, and rejects immediately. The TCP test also closes accepted sockets and awaits listener shutdown.

Testing

  • Windows unit CI passed in 3m24s.
  • Supervisor suite passed 25 consecutive runs; the abort test completes in about 60ms.
  • Supervisor, project dev, and port tests passed: 31/31.
  • Prettier and tsc --noEmit passed.

@github-actionsgithub-actionsBot added the size/xs PR size: XS label Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, well-scoped test-only fix. The change correctly addresses both sides of the lingering handle problem:

  1. createServer((socket) => socket.destroy())waitForPort opens a real TCP connection (src/io/port.ts:60) that the server accepts. Previously nothing destroyed the server-side accepted socket, so its handle could keep Bun's event loop alive on Windows.
  2. Awaiting server.close() via its callback ensures the listener is fully released before the test returns, rather than relying on the previous fire-and-forget call.

The PR description accurately explains the Windows CI hang, the fix matches the described root cause, and no production code is touched. Nothing to change here.

@agentcore-devx-automationagentcore-devx-automationBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.41%. Comparing base (f1a651c) to head (5ae5799).

Files with missing linesPatch %Lines
src/io/port.ts85.71%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2109 +/- ##
============================================
- Coverage 97.42% 97.41% -0.02% 
============================================
Files 429 429 Lines 26314 26330 +16 ============================================
+ Hits 25637 25649 +12 - Misses 677 681 +4 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@HweinstockHweinstock changed the title fix(test): await readiness server shutdownfix(dev): abort readiness socket attemptsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): abort readiness socket attemptsfix(dev): cancel active readiness socketsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): cancel active readiness socketsfix(dev): cancel readiness retries on abortAug 26, 2026
@github-actionsgithub-actionsBot added size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@Hweinstock

Copy link
Copy Markdown
ContributorAuthor

Related: #2110

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Aug 26, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review August 26, 2026 12:58

@tejaskashtejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jariy17
jariy17 merged commit 097e1f0 into aws:refactorAug 26, 2026
27 of 30 checks passed
@Hweinstock
Hweinstock deleted the fix/windows-test branch August 26, 2026 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Hweinstock@codecov-commenter@tejaskash@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(dev): cancel readiness retries on abort by Hweinstock · Pull Request #2109 · aws/agentcore-cli · GitHub
Skip to content

fix(dev): cancel readiness retries on abort - #2109

Merged
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test
Aug 26, 2026
Merged

fix(dev): cancel readiness retries on abort#2109
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test

Conversation

@Hweinstock

@HweinstockHweinstock commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Problem

waitForPort left active sockets and scheduled retries alive after abort. In CI, the supervisor's 60ms abort test instead ran for about 60 seconds and timed out; the original #2041 Windows run eventually lost its runner.

Solution

Abort now destroys the active socket, clears the pending retry, removes its listener, and rejects immediately. The TCP test also closes accepted sockets and awaits listener shutdown.

Testing

  • Windows unit CI passed in 3m24s.
  • Supervisor suite passed 25 consecutive runs; the abort test completes in about 60ms.
  • Supervisor, project dev, and port tests passed: 31/31.
  • Prettier and tsc --noEmit passed.

@github-actionsgithub-actionsBot added the size/xs PR size: XS label Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, well-scoped test-only fix. The change correctly addresses both sides of the lingering handle problem:

  1. createServer((socket) => socket.destroy())waitForPort opens a real TCP connection (src/io/port.ts:60) that the server accepts. Previously nothing destroyed the server-side accepted socket, so its handle could keep Bun's event loop alive on Windows.
  2. Awaiting server.close() via its callback ensures the listener is fully released before the test returns, rather than relying on the previous fire-and-forget call.

The PR description accurately explains the Windows CI hang, the fix matches the described root cause, and no production code is touched. Nothing to change here.

@agentcore-devx-automationagentcore-devx-automationBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.41%. Comparing base (f1a651c) to head (5ae5799).

Files with missing linesPatch %Lines
src/io/port.ts85.71%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2109 +/- ##
============================================
- Coverage 97.42% 97.41% -0.02% 
============================================
Files 429 429 Lines 26314 26330 +16 ============================================
+ Hits 25637 25649 +12 - Misses 677 681 +4 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@HweinstockHweinstock changed the title fix(test): await readiness server shutdownfix(dev): abort readiness socket attemptsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): abort readiness socket attemptsfix(dev): cancel active readiness socketsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): cancel active readiness socketsfix(dev): cancel readiness retries on abortAug 26, 2026
@github-actionsgithub-actionsBot added size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@Hweinstock

Copy link
Copy Markdown
ContributorAuthor

Related: #2110

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Aug 26, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review August 26, 2026 12:58

@tejaskashtejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jariy17
jariy17 merged commit 097e1f0 into aws:refactorAug 26, 2026
27 of 30 checks passed
@Hweinstock
Hweinstock deleted the fix/windows-test branch August 26, 2026 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Hweinstock@codecov-commenter@tejaskash@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(dev): cancel readiness retries on abort by Hweinstock · Pull Request #2109 · aws/agentcore-cli · GitHub
Skip to content

fix(dev): cancel readiness retries on abort - #2109

Merged
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test
Aug 26, 2026
Merged

fix(dev): cancel readiness retries on abort#2109
jariy17 merged 4 commits into
aws:refactorfrom
Hweinstock:fix/windows-test

Conversation

@Hweinstock

@HweinstockHweinstock commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Problem

waitForPort left active sockets and scheduled retries alive after abort. In CI, the supervisor's 60ms abort test instead ran for about 60 seconds and timed out; the original #2041 Windows run eventually lost its runner.

Solution

Abort now destroys the active socket, clears the pending retry, removes its listener, and rejects immediately. The TCP test also closes accepted sockets and awaits listener shutdown.

Testing

  • Windows unit CI passed in 3m24s.
  • Supervisor suite passed 25 consecutive runs; the abort test completes in about 60ms.
  • Supervisor, project dev, and port tests passed: 31/31.
  • Prettier and tsc --noEmit passed.

@github-actionsgithub-actionsBot added the size/xs PR size: XS label Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

@agentcore-devx-automationagentcore-devx-automationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, well-scoped test-only fix. The change correctly addresses both sides of the lingering handle problem:

  1. createServer((socket) => socket.destroy())waitForPort opens a real TCP connection (src/io/port.ts:60) that the server accepts. Previously nothing destroyed the server-side accepted socket, so its handle could keep Bun's event loop alive on Windows.
  2. Awaiting server.close() via its callback ensures the listener is fully released before the test returns, rather than relying on the previous fire-and-forget call.

The PR description accurately explains the Windows CI hang, the fix matches the described root cause, and no production code is touched. Nothing to change here.

@agentcore-devx-automationagentcore-devx-automationBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.41%. Comparing base (f1a651c) to head (5ae5799).

Files with missing linesPatch %Lines
src/io/port.ts85.71%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## refactor #2109 +/- ##
============================================
- Coverage 97.42% 97.41% -0.02% 
============================================
Files 429 429 Lines 26314 26330 +16 ============================================
+ Hits 25637 25649 +12 - Misses 677 681 +4 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@HweinstockHweinstock changed the title fix(test): await readiness server shutdownfix(dev): abort readiness socket attemptsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): abort readiness socket attemptsfix(dev): cancel active readiness socketsAug 26, 2026
@github-actionsgithub-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@HweinstockHweinstock changed the title fix(dev): cancel active readiness socketsfix(dev): cancel readiness retries on abortAug 26, 2026
@github-actionsgithub-actionsBot added size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Aug 26, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026
@Hweinstock

Copy link
Copy Markdown
ContributorAuthor

Related: #2110

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Aug 26, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review August 26, 2026 12:58

@tejaskashtejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jariy17
jariy17 merged commit 097e1f0 into aws:refactorAug 26, 2026
27 of 30 checks passed
@Hweinstock
Hweinstock deleted the fix/windows-test branch August 26, 2026 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Hweinstock@codecov-commenter@tejaskash@jariy17