feat(project): add deploy command contract by notgitika · Pull Request #2056 · aws/agentcore-cli

notgitika · 2026-08-20T03:11:51Z

Summary

add the project deploy handler and --target contract
define deployment target validation and deployment result types
synchronize the closed AgentCore region enum with the current supported-region list
wire manager/backend deploy interfaces with an intentionally unimplemented CDK operation

Stack

This is PR 2 of 4 decomposing #2001. The command remains nonfunctional until the final PR. Review and merge bottom-up.

refactor(project): move build behind a project backend #2055 - backend build boundary
feat(project): add deploy command contract #2056 - deploy command contract (this PR)
feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter
feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

Hweinstock

small questions, but approach lgtm. I can take another look once the dependent changes are merged.

codecov-commenter · 2026-08-20T17:09:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (38c30ae) to head (8bee57f).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2056 +/- ##
============================================
+ Coverage 97.24% 97.25% +0.01% 
============================================
Files 396 397 +1 Lines 24019 24125 +106 ============================================
+ Hits 23357 23463 +106 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hweinstock · 2026-08-21T17:08:56Z

I think there are some merge conflicts: src/handlers/project/project.test.ts.

nborges-aws

LGTM thanks for fixes!

Hweinstock

few comments on testing and some nits, but I like the direction!

Hweinstock · 2026-08-21T18:25:08Z

- throw new DeserializationError(filePath, { cause: parseResult.error });
+ throw new DeserializationError(filePath, {
+ cause: parseResult.error,
+ details: z.prettifyError(parseResult.error),


haha I refreshed and you implemented exactly what I was thinking, crazy!

The test assembled its own ValueContext with ProjectKey, JsonKey and a stub JsonRenderer, which re-implemented what createRootHandler installs — so it could pass while the real wiring was wrong. It now goes through createRootHandler with the fake manager injected via TestCoreClient, the same pattern project.test.ts and add/harness/index.test.ts use, exercising the real --json group flag, the real JSON renderer and the real withProject wrap. Verified by unwrapping deploy from withProject: both tests now fail, where the hand-built context passed. No fixture setup needed since the fake's resolve() returns a project. Also drops the CloudFormation wording from DeployResult.outputs. The shape is already backend-neutral; only the doc comment implied CDK.

Resolve the named aws-targets.json entry in FsProjectManager and pass the resolved account and region to the backend, mirroring build(). deploy() previously threw NotImplementedError before dispatching, which left CdkBackend.deploy unreachable and duplicated the same message in two places; the backend is now the single place that reports deployment as unimplemented. Narrow the TestCoreClient seam from a whole-manager override to a single backend override. Handler tests keep the real FsProjectManager, so target resolution and withProject run for real and only the deploy boundary is faked.

Match the name pattern the schema on main already enforces. The CDK normalizes underscores to hyphens, so accepting them here would let a target be written one way and deployed under another.

The root handler prints only `error.message`, so the zod detail that `FsReadWriteJson.read` put in `cause` never reached the user: a typo'd region or a duplicated target name in a hand-edited file produced only `Failed to deserialize file at "<path>"`, naming the file but not the field. DeserializationError now requires a `details` string and appends it to the message, and json.ts passes the prettified zod error (or the parse error) through. Fixing it in the IO layer rather than catching in `ProjectManager.deploy` covers every hand-edited file at once. Making `details` required rather than optional keeps the opaque message from being reintroduced. Tested at the handler level, since the schema tests pass in isolation without proving the detail reaches stderr.

- Inline runDeploy and renderResult. Neither is reused; the manual .next() loop only exists because the outputs are the generator's return value, which `for await` discards, so that reason is now a comment where the loop lives. `build` already drains its generator inline. - Rename the test factory `harness` to `testDeployCommand`. "Harness" is a real AgentCore resource in this codebase, and the name matches the existing `testMemoryCommand` convention. - Collapse inProjectWithRawTargets/inProjectWithTargets into one helper that takes the file contents. Callers pass JSON.stringify(...), so the malformed-JSON case is just another call rather than a second function. - Drop the TestCoreClientOptions comment; the Partial already says it. - Drop the comment above the aws-targets.json tests describing the opaque message, which no longer exists now that DeserializationError requires `details`. The describe name carries the intent.

tejaskash

All actionable review comments are addressed. I verified the final head against current refactor and reran the full local test, typecheck, lint, and formatting checks.

notgitika · 2026-08-20T03:11:51Z

Summary

add the project deploy handler and --target contract
define deployment target validation and deployment result types
synchronize the closed AgentCore region enum with the current supported-region list
wire manager/backend deploy interfaces with an intentionally unimplemented CDK operation

Stack

This is PR 2 of 4 decomposing #2001. The command remains nonfunctional until the final PR. Review and merge bottom-up.

refactor(project): move build behind a project backend #2055 - backend build boundary
feat(project): add deploy command contract #2056 - deploy command contract (this PR)
feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter
feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

Hweinstock

small questions, but approach lgtm. I can take another look once the dependent changes are merged.

codecov-commenter · 2026-08-20T17:09:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (38c30ae) to head (8bee57f).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2056 +/- ##
============================================
+ Coverage 97.24% 97.25% +0.01% 
============================================
Files 396 397 +1 Lines 24019 24125 +106 ============================================
+ Hits 23357 23463 +106 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hweinstock · 2026-08-21T17:08:56Z

I think there are some merge conflicts: src/handlers/project/project.test.ts.

nborges-aws

LGTM thanks for fixes!

Hweinstock

few comments on testing and some nits, but I like the direction!

Hweinstock · 2026-08-21T18:25:08Z

- throw new DeserializationError(filePath, { cause: parseResult.error });
+ throw new DeserializationError(filePath, {
+ cause: parseResult.error,
+ details: z.prettifyError(parseResult.error),


haha I refreshed and you implemented exactly what I was thinking, crazy!

The test assembled its own ValueContext with ProjectKey, JsonKey and a stub JsonRenderer, which re-implemented what createRootHandler installs — so it could pass while the real wiring was wrong. It now goes through createRootHandler with the fake manager injected via TestCoreClient, the same pattern project.test.ts and add/harness/index.test.ts use, exercising the real --json group flag, the real JSON renderer and the real withProject wrap. Verified by unwrapping deploy from withProject: both tests now fail, where the hand-built context passed. No fixture setup needed since the fake's resolve() returns a project. Also drops the CloudFormation wording from DeployResult.outputs. The shape is already backend-neutral; only the doc comment implied CDK.

Resolve the named aws-targets.json entry in FsProjectManager and pass the resolved account and region to the backend, mirroring build(). deploy() previously threw NotImplementedError before dispatching, which left CdkBackend.deploy unreachable and duplicated the same message in two places; the backend is now the single place that reports deployment as unimplemented. Narrow the TestCoreClient seam from a whole-manager override to a single backend override. Handler tests keep the real FsProjectManager, so target resolution and withProject run for real and only the deploy boundary is faked.

Match the name pattern the schema on main already enforces. The CDK normalizes underscores to hyphens, so accepting them here would let a target be written one way and deployed under another.

The root handler prints only `error.message`, so the zod detail that `FsReadWriteJson.read` put in `cause` never reached the user: a typo'd region or a duplicated target name in a hand-edited file produced only `Failed to deserialize file at "<path>"`, naming the file but not the field. DeserializationError now requires a `details` string and appends it to the message, and json.ts passes the prettified zod error (or the parse error) through. Fixing it in the IO layer rather than catching in `ProjectManager.deploy` covers every hand-edited file at once. Making `details` required rather than optional keeps the opaque message from being reintroduced. Tested at the handler level, since the schema tests pass in isolation without proving the detail reaches stderr.

- Inline runDeploy and renderResult. Neither is reused; the manual .next() loop only exists because the outputs are the generator's return value, which `for await` discards, so that reason is now a comment where the loop lives. `build` already drains its generator inline. - Rename the test factory `harness` to `testDeployCommand`. "Harness" is a real AgentCore resource in this codebase, and the name matches the existing `testMemoryCommand` convention. - Collapse inProjectWithRawTargets/inProjectWithTargets into one helper that takes the file contents. Callers pass JSON.stringify(...), so the malformed-JSON case is just another call rather than a second function. - Drop the TestCoreClientOptions comment; the Partial already says it. - Drop the comment above the aws-targets.json tests describing the opaque message, which no longer exists now that DeserializationError requires `details`. The describe name carries the intent.

tejaskash

All actionable review comments are addressed. I verified the final head against current refactor and reran the full local test, typecheck, lint, and formatting checks.

notgitika · 2026-08-20T03:11:51Z

Summary

add the project deploy handler and --target contract
define deployment target validation and deployment result types
synchronize the closed AgentCore region enum with the current supported-region list
wire manager/backend deploy interfaces with an intentionally unimplemented CDK operation

Stack

This is PR 2 of 4 decomposing #2001. The command remains nonfunctional until the final PR. Review and merge bottom-up.

refactor(project): move build behind a project backend #2055 - backend build boundary
feat(project): add deploy command contract #2056 - deploy command contract (this PR)
feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter
feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

Hweinstock

small questions, but approach lgtm. I can take another look once the dependent changes are merged.

codecov-commenter · 2026-08-20T17:09:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (38c30ae) to head (8bee57f).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2056 +/- ##
============================================
+ Coverage 97.24% 97.25% +0.01% 
============================================
Files 396 397 +1 Lines 24019 24125 +106 ============================================
+ Hits 23357 23463 +106 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hweinstock · 2026-08-21T17:08:56Z

I think there are some merge conflicts: src/handlers/project/project.test.ts.

nborges-aws

LGTM thanks for fixes!

Hweinstock

few comments on testing and some nits, but I like the direction!

Hweinstock · 2026-08-21T18:25:08Z

- throw new DeserializationError(filePath, { cause: parseResult.error });
+ throw new DeserializationError(filePath, {
+ cause: parseResult.error,
+ details: z.prettifyError(parseResult.error),


haha I refreshed and you implemented exactly what I was thinking, crazy!

The test assembled its own ValueContext with ProjectKey, JsonKey and a stub JsonRenderer, which re-implemented what createRootHandler installs — so it could pass while the real wiring was wrong. It now goes through createRootHandler with the fake manager injected via TestCoreClient, the same pattern project.test.ts and add/harness/index.test.ts use, exercising the real --json group flag, the real JSON renderer and the real withProject wrap. Verified by unwrapping deploy from withProject: both tests now fail, where the hand-built context passed. No fixture setup needed since the fake's resolve() returns a project. Also drops the CloudFormation wording from DeployResult.outputs. The shape is already backend-neutral; only the doc comment implied CDK.

Resolve the named aws-targets.json entry in FsProjectManager and pass the resolved account and region to the backend, mirroring build(). deploy() previously threw NotImplementedError before dispatching, which left CdkBackend.deploy unreachable and duplicated the same message in two places; the backend is now the single place that reports deployment as unimplemented. Narrow the TestCoreClient seam from a whole-manager override to a single backend override. Handler tests keep the real FsProjectManager, so target resolution and withProject run for real and only the deploy boundary is faked.

Match the name pattern the schema on main already enforces. The CDK normalizes underscores to hyphens, so accepting them here would let a target be written one way and deployed under another.

The root handler prints only `error.message`, so the zod detail that `FsReadWriteJson.read` put in `cause` never reached the user: a typo'd region or a duplicated target name in a hand-edited file produced only `Failed to deserialize file at "<path>"`, naming the file but not the field. DeserializationError now requires a `details` string and appends it to the message, and json.ts passes the prettified zod error (or the parse error) through. Fixing it in the IO layer rather than catching in `ProjectManager.deploy` covers every hand-edited file at once. Making `details` required rather than optional keeps the opaque message from being reintroduced. Tested at the handler level, since the schema tests pass in isolation without proving the detail reaches stderr.

- Inline runDeploy and renderResult. Neither is reused; the manual .next() loop only exists because the outputs are the generator's return value, which `for await` discards, so that reason is now a comment where the loop lives. `build` already drains its generator inline. - Rename the test factory `harness` to `testDeployCommand`. "Harness" is a real AgentCore resource in this codebase, and the name matches the existing `testMemoryCommand` convention. - Collapse inProjectWithRawTargets/inProjectWithTargets into one helper that takes the file contents. Callers pass JSON.stringify(...), so the malformed-JSON case is just another call rather than a second function. - Drop the TestCoreClientOptions comment; the Partial already says it. - Drop the comment above the aws-targets.json tests describing the opaque message, which no longer exists now that DeserializationError requires `details`. The describe name carries the intent.

tejaskash

All actionable review comments are addressed. I verified the final head against current refactor and reran the full local test, typecheck, lint, and formatting checks.

notgitika · 2026-08-20T03:11:51Z

Summary

add the project deploy handler and --target contract
define deployment target validation and deployment result types
synchronize the closed AgentCore region enum with the current supported-region list
wire manager/backend deploy interfaces with an intentionally unimplemented CDK operation

Stack

This is PR 2 of 4 decomposing #2001. The command remains nonfunctional until the final PR. Review and merge bottom-up.

refactor(project): move build behind a project backend #2055 - backend build boundary
feat(project): add deploy command contract #2056 - deploy command contract (this PR)
feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter
feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

Hweinstock

small questions, but approach lgtm. I can take another look once the dependent changes are merged.

codecov-commenter · 2026-08-20T17:09:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (38c30ae) to head (8bee57f).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2056 +/- ##
============================================
+ Coverage 97.24% 97.25% +0.01% 
============================================
Files 396 397 +1 Lines 24019 24125 +106 ============================================
+ Hits 23357 23463 +106 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hweinstock · 2026-08-21T17:08:56Z

I think there are some merge conflicts: src/handlers/project/project.test.ts.

nborges-aws

LGTM thanks for fixes!

Hweinstock

few comments on testing and some nits, but I like the direction!

Hweinstock · 2026-08-21T18:25:08Z

- throw new DeserializationError(filePath, { cause: parseResult.error });
+ throw new DeserializationError(filePath, {
+ cause: parseResult.error,
+ details: z.prettifyError(parseResult.error),


haha I refreshed and you implemented exactly what I was thinking, crazy!

The test assembled its own ValueContext with ProjectKey, JsonKey and a stub JsonRenderer, which re-implemented what createRootHandler installs — so it could pass while the real wiring was wrong. It now goes through createRootHandler with the fake manager injected via TestCoreClient, the same pattern project.test.ts and add/harness/index.test.ts use, exercising the real --json group flag, the real JSON renderer and the real withProject wrap. Verified by unwrapping deploy from withProject: both tests now fail, where the hand-built context passed. No fixture setup needed since the fake's resolve() returns a project. Also drops the CloudFormation wording from DeployResult.outputs. The shape is already backend-neutral; only the doc comment implied CDK.

Resolve the named aws-targets.json entry in FsProjectManager and pass the resolved account and region to the backend, mirroring build(). deploy() previously threw NotImplementedError before dispatching, which left CdkBackend.deploy unreachable and duplicated the same message in two places; the backend is now the single place that reports deployment as unimplemented. Narrow the TestCoreClient seam from a whole-manager override to a single backend override. Handler tests keep the real FsProjectManager, so target resolution and withProject run for real and only the deploy boundary is faked.

Match the name pattern the schema on main already enforces. The CDK normalizes underscores to hyphens, so accepting them here would let a target be written one way and deployed under another.

The root handler prints only `error.message`, so the zod detail that `FsReadWriteJson.read` put in `cause` never reached the user: a typo'd region or a duplicated target name in a hand-edited file produced only `Failed to deserialize file at "<path>"`, naming the file but not the field. DeserializationError now requires a `details` string and appends it to the message, and json.ts passes the prettified zod error (or the parse error) through. Fixing it in the IO layer rather than catching in `ProjectManager.deploy` covers every hand-edited file at once. Making `details` required rather than optional keeps the opaque message from being reintroduced. Tested at the handler level, since the schema tests pass in isolation without proving the detail reaches stderr.

- Inline runDeploy and renderResult. Neither is reused; the manual .next() loop only exists because the outputs are the generator's return value, which `for await` discards, so that reason is now a comment where the loop lives. `build` already drains its generator inline. - Rename the test factory `harness` to `testDeployCommand`. "Harness" is a real AgentCore resource in this codebase, and the name matches the existing `testMemoryCommand` convention. - Collapse inProjectWithRawTargets/inProjectWithTargets into one helper that takes the file contents. Callers pass JSON.stringify(...), so the malformed-JSON case is just another call rather than a second function. - Drop the TestCoreClientOptions comment; the Partial already says it. - Drop the comment above the aws-targets.json tests describing the opaque message, which no longer exists now that DeserializationError requires `details`. The describe name carries the intent.

tejaskash

All actionable review comments are addressed. I verified the final head against current refactor and reran the full local test, typecheck, lint, and formatting checks.

notgitika · 2026-08-20T03:11:51Z

Summary

add the project deploy handler and --target contract
define deployment target validation and deployment result types
synchronize the closed AgentCore region enum with the current supported-region list
wire manager/backend deploy interfaces with an intentionally unimplemented CDK operation

Stack

This is PR 2 of 4 decomposing #2001. The command remains nonfunctional until the final PR. Review and merge bottom-up.

refactor(project): move build behind a project backend #2055 - backend build boundary
feat(project): add deploy command contract #2056 - deploy command contract (this PR)
feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter
feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

Hweinstock

small questions, but approach lgtm. I can take another look once the dependent changes are merged.

codecov-commenter · 2026-08-20T17:09:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (38c30ae) to head (8bee57f).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2056 +/- ##
============================================
+ Coverage 97.24% 97.25% +0.01% 
============================================
Files 396 397 +1 Lines 24019 24125 +106 ============================================
+ Hits 23357 23463 +106 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hweinstock · 2026-08-21T17:08:56Z

I think there are some merge conflicts: src/handlers/project/project.test.ts.

nborges-aws

LGTM thanks for fixes!

Hweinstock

few comments on testing and some nits, but I like the direction!

Hweinstock · 2026-08-21T18:25:08Z

- throw new DeserializationError(filePath, { cause: parseResult.error });
+ throw new DeserializationError(filePath, {
+ cause: parseResult.error,
+ details: z.prettifyError(parseResult.error),


haha I refreshed and you implemented exactly what I was thinking, crazy!

The test assembled its own ValueContext with ProjectKey, JsonKey and a stub JsonRenderer, which re-implemented what createRootHandler installs — so it could pass while the real wiring was wrong. It now goes through createRootHandler with the fake manager injected via TestCoreClient, the same pattern project.test.ts and add/harness/index.test.ts use, exercising the real --json group flag, the real JSON renderer and the real withProject wrap. Verified by unwrapping deploy from withProject: both tests now fail, where the hand-built context passed. No fixture setup needed since the fake's resolve() returns a project. Also drops the CloudFormation wording from DeployResult.outputs. The shape is already backend-neutral; only the doc comment implied CDK.

Resolve the named aws-targets.json entry in FsProjectManager and pass the resolved account and region to the backend, mirroring build(). deploy() previously threw NotImplementedError before dispatching, which left CdkBackend.deploy unreachable and duplicated the same message in two places; the backend is now the single place that reports deployment as unimplemented. Narrow the TestCoreClient seam from a whole-manager override to a single backend override. Handler tests keep the real FsProjectManager, so target resolution and withProject run for real and only the deploy boundary is faked.

Match the name pattern the schema on main already enforces. The CDK normalizes underscores to hyphens, so accepting them here would let a target be written one way and deployed under another.

The root handler prints only `error.message`, so the zod detail that `FsReadWriteJson.read` put in `cause` never reached the user: a typo'd region or a duplicated target name in a hand-edited file produced only `Failed to deserialize file at "<path>"`, naming the file but not the field. DeserializationError now requires a `details` string and appends it to the message, and json.ts passes the prettified zod error (or the parse error) through. Fixing it in the IO layer rather than catching in `ProjectManager.deploy` covers every hand-edited file at once. Making `details` required rather than optional keeps the opaque message from being reintroduced. Tested at the handler level, since the schema tests pass in isolation without proving the detail reaches stderr.

- Inline runDeploy and renderResult. Neither is reused; the manual .next() loop only exists because the outputs are the generator's return value, which `for await` discards, so that reason is now a comment where the loop lives. `build` already drains its generator inline. - Rename the test factory `harness` to `testDeployCommand`. "Harness" is a real AgentCore resource in this codebase, and the name matches the existing `testMemoryCommand` convention. - Collapse inProjectWithRawTargets/inProjectWithTargets into one helper that takes the file contents. Callers pass JSON.stringify(...), so the malformed-JSON case is just another call rather than a second function. - Drop the TestCoreClientOptions comment; the Partial already says it. - Drop the comment above the aws-targets.json tests describing the opaque message, which no longer exists now that DeserializationError requires `details`. The describe name carries the intent.

tejaskash

All actionable review comments are addressed. I verified the final head against current refactor and reran the full local test, typecheck, lint, and formatting checks.

notgitika · 2026-08-20T03:11:51Z

Summary

add the project deploy handler and --target contract
define deployment target validation and deployment result types
synchronize the closed AgentCore region enum with the current supported-region list
wire manager/backend deploy interfaces with an intentionally unimplemented CDK operation

Stack

This is PR 2 of 4 decomposing #2001. The command remains nonfunctional until the final PR. Review and merge bottom-up.

refactor(project): move build behind a project backend #2055 - backend build boundary
feat(project): add deploy command contract #2056 - deploy command contract (this PR)
feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter
feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

Hweinstock

small questions, but approach lgtm. I can take another look once the dependent changes are merged.

codecov-commenter · 2026-08-20T17:09:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (38c30ae) to head (8bee57f).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2056 +/- ##
============================================
+ Coverage 97.24% 97.25% +0.01% 
============================================
Files 396 397 +1 Lines 24019 24125 +106 ============================================
+ Hits 23357 23463 +106 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hweinstock · 2026-08-21T17:08:56Z

I think there are some merge conflicts: src/handlers/project/project.test.ts.

nborges-aws

LGTM thanks for fixes!

Hweinstock

few comments on testing and some nits, but I like the direction!

Hweinstock · 2026-08-21T18:25:08Z

- throw new DeserializationError(filePath, { cause: parseResult.error });
+ throw new DeserializationError(filePath, {
+ cause: parseResult.error,
+ details: z.prettifyError(parseResult.error),


haha I refreshed and you implemented exactly what I was thinking, crazy!

The test assembled its own ValueContext with ProjectKey, JsonKey and a stub JsonRenderer, which re-implemented what createRootHandler installs — so it could pass while the real wiring was wrong. It now goes through createRootHandler with the fake manager injected via TestCoreClient, the same pattern project.test.ts and add/harness/index.test.ts use, exercising the real --json group flag, the real JSON renderer and the real withProject wrap. Verified by unwrapping deploy from withProject: both tests now fail, where the hand-built context passed. No fixture setup needed since the fake's resolve() returns a project. Also drops the CloudFormation wording from DeployResult.outputs. The shape is already backend-neutral; only the doc comment implied CDK.

Resolve the named aws-targets.json entry in FsProjectManager and pass the resolved account and region to the backend, mirroring build(). deploy() previously threw NotImplementedError before dispatching, which left CdkBackend.deploy unreachable and duplicated the same message in two places; the backend is now the single place that reports deployment as unimplemented. Narrow the TestCoreClient seam from a whole-manager override to a single backend override. Handler tests keep the real FsProjectManager, so target resolution and withProject run for real and only the deploy boundary is faked.

Match the name pattern the schema on main already enforces. The CDK normalizes underscores to hyphens, so accepting them here would let a target be written one way and deployed under another.

The root handler prints only `error.message`, so the zod detail that `FsReadWriteJson.read` put in `cause` never reached the user: a typo'd region or a duplicated target name in a hand-edited file produced only `Failed to deserialize file at "<path>"`, naming the file but not the field. DeserializationError now requires a `details` string and appends it to the message, and json.ts passes the prettified zod error (or the parse error) through. Fixing it in the IO layer rather than catching in `ProjectManager.deploy` covers every hand-edited file at once. Making `details` required rather than optional keeps the opaque message from being reintroduced. Tested at the handler level, since the schema tests pass in isolation without proving the detail reaches stderr.

- Inline runDeploy and renderResult. Neither is reused; the manual .next() loop only exists because the outputs are the generator's return value, which `for await` discards, so that reason is now a comment where the loop lives. `build` already drains its generator inline. - Rename the test factory `harness` to `testDeployCommand`. "Harness" is a real AgentCore resource in this codebase, and the name matches the existing `testMemoryCommand` convention. - Collapse inProjectWithRawTargets/inProjectWithTargets into one helper that takes the file contents. Callers pass JSON.stringify(...), so the malformed-JSON case is just another call rather than a second function. - Drop the TestCoreClientOptions comment; the Partial already says it. - Drop the comment above the aws-targets.json tests describing the opaque message, which no longer exists now that DeserializationError requires `details`. The describe name carries the intent.

tejaskash

All actionable review comments are addressed. I verified the final head against current refactor and reran the full local test, typecheck, lint, and formatting checks.

notgitika · 2026-08-20T03:11:51Z

Summary

add the project deploy handler and --target contract
define deployment target validation and deployment result types
synchronize the closed AgentCore region enum with the current supported-region list
wire manager/backend deploy interfaces with an intentionally unimplemented CDK operation

Stack

This is PR 2 of 4 decomposing #2001. The command remains nonfunctional until the final PR. Review and merge bottom-up.

refactor(project): move build behind a project backend #2055 - backend build boundary
feat(project): add deploy command contract #2056 - deploy command contract (this PR)
feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter
feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

Hweinstock

small questions, but approach lgtm. I can take another look once the dependent changes are merged.

codecov-commenter · 2026-08-20T17:09:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (38c30ae) to head (8bee57f).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2056 +/- ##
============================================
+ Coverage 97.24% 97.25% +0.01% 
============================================
Files 396 397 +1 Lines 24019 24125 +106 ============================================
+ Hits 23357 23463 +106 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hweinstock · 2026-08-21T17:08:56Z

I think there are some merge conflicts: src/handlers/project/project.test.ts.

nborges-aws

LGTM thanks for fixes!

Hweinstock

few comments on testing and some nits, but I like the direction!

Hweinstock · 2026-08-21T18:25:08Z

- throw new DeserializationError(filePath, { cause: parseResult.error });
+ throw new DeserializationError(filePath, {
+ cause: parseResult.error,
+ details: z.prettifyError(parseResult.error),


haha I refreshed and you implemented exactly what I was thinking, crazy!

The test assembled its own ValueContext with ProjectKey, JsonKey and a stub JsonRenderer, which re-implemented what createRootHandler installs — so it could pass while the real wiring was wrong. It now goes through createRootHandler with the fake manager injected via TestCoreClient, the same pattern project.test.ts and add/harness/index.test.ts use, exercising the real --json group flag, the real JSON renderer and the real withProject wrap. Verified by unwrapping deploy from withProject: both tests now fail, where the hand-built context passed. No fixture setup needed since the fake's resolve() returns a project. Also drops the CloudFormation wording from DeployResult.outputs. The shape is already backend-neutral; only the doc comment implied CDK.

Resolve the named aws-targets.json entry in FsProjectManager and pass the resolved account and region to the backend, mirroring build(). deploy() previously threw NotImplementedError before dispatching, which left CdkBackend.deploy unreachable and duplicated the same message in two places; the backend is now the single place that reports deployment as unimplemented. Narrow the TestCoreClient seam from a whole-manager override to a single backend override. Handler tests keep the real FsProjectManager, so target resolution and withProject run for real and only the deploy boundary is faked.

Match the name pattern the schema on main already enforces. The CDK normalizes underscores to hyphens, so accepting them here would let a target be written one way and deployed under another.

The root handler prints only `error.message`, so the zod detail that `FsReadWriteJson.read` put in `cause` never reached the user: a typo'd region or a duplicated target name in a hand-edited file produced only `Failed to deserialize file at "<path>"`, naming the file but not the field. DeserializationError now requires a `details` string and appends it to the message, and json.ts passes the prettified zod error (or the parse error) through. Fixing it in the IO layer rather than catching in `ProjectManager.deploy` covers every hand-edited file at once. Making `details` required rather than optional keeps the opaque message from being reintroduced. Tested at the handler level, since the schema tests pass in isolation without proving the detail reaches stderr.

- Inline runDeploy and renderResult. Neither is reused; the manual .next() loop only exists because the outputs are the generator's return value, which `for await` discards, so that reason is now a comment where the loop lives. `build` already drains its generator inline. - Rename the test factory `harness` to `testDeployCommand`. "Harness" is a real AgentCore resource in this codebase, and the name matches the existing `testMemoryCommand` convention. - Collapse inProjectWithRawTargets/inProjectWithTargets into one helper that takes the file contents. Callers pass JSON.stringify(...), so the malformed-JSON case is just another call rather than a second function. - Drop the TestCoreClientOptions comment; the Partial already says it. - Drop the comment above the aws-targets.json tests describing the opaque message, which no longer exists now that DeserializationError requires `details`. The describe name carries the intent.

tejaskash

All actionable review comments are addressed. I verified the final head against current refactor and reran the full local test, typecheck, lint, and formatting checks.

notgitika · 2026-08-20T03:11:51Z

Summary

add the project deploy handler and --target contract
define deployment target validation and deployment result types
synchronize the closed AgentCore region enum with the current supported-region list
wire manager/backend deploy interfaces with an intentionally unimplemented CDK operation

Stack

This is PR 2 of 4 decomposing #2001. The command remains nonfunctional until the final PR. Review and merge bottom-up.

refactor(project): move build behind a project backend #2055 - backend build boundary
feat(project): add deploy command contract #2056 - deploy command contract (this PR)
feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter
feat(project): implement safe CDK deployment #2058 - safe deployment implementation

typecheck, lint, format, test all pass

Hweinstock

small questions, but approach lgtm. I can take another look once the dependent changes are merged.

codecov-commenter · 2026-08-20T17:09:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (38c30ae) to head (8bee57f).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2056 +/- ##
============================================
+ Coverage 97.24% 97.25% +0.01% 
============================================
Files 396 397 +1 Lines 24019 24125 +106 ============================================
+ Hits 23357 23463 +106 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hweinstock · 2026-08-21T17:08:56Z

I think there are some merge conflicts: src/handlers/project/project.test.ts.

nborges-aws

LGTM thanks for fixes!

Hweinstock

few comments on testing and some nits, but I like the direction!

Hweinstock · 2026-08-21T18:25:08Z

- throw new DeserializationError(filePath, { cause: parseResult.error });
+ throw new DeserializationError(filePath, {
+ cause: parseResult.error,
+ details: z.prettifyError(parseResult.error),


haha I refreshed and you implemented exactly what I was thinking, crazy!

The test assembled its own ValueContext with ProjectKey, JsonKey and a stub JsonRenderer, which re-implemented what createRootHandler installs — so it could pass while the real wiring was wrong. It now goes through createRootHandler with the fake manager injected via TestCoreClient, the same pattern project.test.ts and add/harness/index.test.ts use, exercising the real --json group flag, the real JSON renderer and the real withProject wrap. Verified by unwrapping deploy from withProject: both tests now fail, where the hand-built context passed. No fixture setup needed since the fake's resolve() returns a project. Also drops the CloudFormation wording from DeployResult.outputs. The shape is already backend-neutral; only the doc comment implied CDK.

Resolve the named aws-targets.json entry in FsProjectManager and pass the resolved account and region to the backend, mirroring build(). deploy() previously threw NotImplementedError before dispatching, which left CdkBackend.deploy unreachable and duplicated the same message in two places; the backend is now the single place that reports deployment as unimplemented. Narrow the TestCoreClient seam from a whole-manager override to a single backend override. Handler tests keep the real FsProjectManager, so target resolution and withProject run for real and only the deploy boundary is faked.

Match the name pattern the schema on main already enforces. The CDK normalizes underscores to hyphens, so accepting them here would let a target be written one way and deployed under another.

The root handler prints only `error.message`, so the zod detail that `FsReadWriteJson.read` put in `cause` never reached the user: a typo'd region or a duplicated target name in a hand-edited file produced only `Failed to deserialize file at "<path>"`, naming the file but not the field. DeserializationError now requires a `details` string and appends it to the message, and json.ts passes the prettified zod error (or the parse error) through. Fixing it in the IO layer rather than catching in `ProjectManager.deploy` covers every hand-edited file at once. Making `details` required rather than optional keeps the opaque message from being reintroduced. Tested at the handler level, since the schema tests pass in isolation without proving the detail reaches stderr.

- Inline runDeploy and renderResult. Neither is reused; the manual .next() loop only exists because the outputs are the generator's return value, which `for await` discards, so that reason is now a comment where the loop lives. `build` already drains its generator inline. - Rename the test factory `harness` to `testDeployCommand`. "Harness" is a real AgentCore resource in this codebase, and the name matches the existing `testMemoryCommand` convention. - Collapse inProjectWithRawTargets/inProjectWithTargets into one helper that takes the file contents. Callers pass JSON.stringify(...), so the malformed-JSON case is just another call rather than a second function. - Drop the TestCoreClientOptions comment; the Partial already says it. - Drop the comment above the aws-targets.json tests describing the opaque message, which no longer exists now that DeserializationError requires `details`. The describe name carries the intent.

tejaskash

All actionable review comments are addressed. I verified the final head against current refactor and reran the full local test, typecheck, lint, and formatting checks.

github-actionsBot added the size/m PR size: M label Aug 20, 2026

notgitika had a problem deploying to e2e-testing August 20, 2026 03:12 — with GitHub Actions Failure

This was referenced Aug 20, 2026
refactor(project): move build behind a project backend #2055
Merged
feat(project): add CDK Toolkit adapter #2057
Merged
feat(project): implement safe CDK deployment #2058
Merged

github-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress size/m PR size: M and removed size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 20, 2026

notgitika marked this pull request as ready for review August 20, 2026 04:10

notgitika mentioned this pull request Aug 20, 2026
feat: implement project deploy command #2001
Closed

notgitika marked this pull request as draft August 20, 2026 04:19

github-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 20, 2026

notgitika had a problem deploying to e2e-testing August 20, 2026 04:19 — with GitHub Actions Failure

github-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 20, 2026

notgitika marked this pull request as ready for review August 20, 2026 04:24

github-actionsBot added size/m PR size: M and removed size/m PR size: M labels Aug 20, 2026

Hweinstock reviewed Aug 20, 2026
View reviewed changes

Comment threadsrc/handlers/project/project.test.ts
Comment threadsrc/handlers/project/types.ts Outdated
Comment threadsrc/handlers/project/deploy/index.test.ts Outdated

Base automatically changed from feat/project-backend-build to refactorAugust 20, 2026 16:07

notgitika force-pushed the feat/project-deploy-contract branch from 81c98a5 to e485e02Compare August 20, 2026 17:06

notgitika force-pushed the feat/project-deploy-contract branch from 53bd2b5 to 78a8644Compare August 21, 2026 16:16

nborges-aws reviewed Aug 21, 2026
View reviewed changes

Comment threadsrc/projectSchemas/aws-targets.ts Outdated

notgitika force-pushed the feat/project-deploy-contract branch from 78a8644 to f3c53bfCompare August 21, 2026 17:40

tejaskash reviewed Aug 21, 2026
View reviewed changes

Comment threadsrc/core/project/manager.tsx

notgitika force-pushed the feat/project-deploy-contract branch from b9422f7 to e5af2c4Compare August 21, 2026 18:21

nborges-aws previously approved these changes Aug 21, 2026
View reviewed changes

Hweinstock reviewed Aug 21, 2026
View reviewed changes

notgitika dismissed nborges-aws’s stale review via e8aabe3August 21, 2026 19:34

notgitika force-pushed the feat/project-deploy-contract branch from e5af2c4 to e8aabe3Compare August 21, 2026 19:34

notgitika added 7 commits August 24, 2026 10:46

feat(project): add deploy command contract
94d13c3

fix(project): sync supported deployment regions
8c51e3f

fix(project): reject underscores in deployment target names
bebfee4
Match the name pattern the schema on main already enforces. The CDK normalizes underscores to hyphens, so accepting them here would let a target be written one way and deployed under another.

notgitika force-pushed the feat/project-deploy-contract branch from e8aabe3 to 8bee57fCompare August 24, 2026 14:46

tejaskash approved these changes Aug 24, 2026
View reviewed changes

nborges-aws approved these changes Aug 24, 2026
View reviewed changes

notgitika merged commit fee25e2 into refactorAug 24, 2026
11 checks passed

notgitika deleted the feat/project-deploy-contract branch August 24, 2026 16:01